POOL-340 correct validateObject With the corrected behaviour of ValidateObject we now pass the test. Seems like the original error was already fixed in our last few commits.
Project: http://git-wip-us.apache.org/repos/asf/commons-pool/repo Commit: http://git-wip-us.apache.org/repos/asf/commons-pool/commit/75a47ee1 Tree: http://git-wip-us.apache.org/repos/asf/commons-pool/tree/75a47ee1 Diff: http://git-wip-us.apache.org/repos/asf/commons-pool/diff/75a47ee1 Branch: refs/heads/master Commit: 75a47ee1fd232b54876f5f9042f53ab751dae6ea Parents: ad9a0d8 Author: Mark Struberg <strub...@apache.org> Authored: Sat Oct 27 20:49:49 2018 +0200 Committer: Mark Struberg <strub...@apache.org> Committed: Sat Oct 27 20:49:49 2018 +0200 ---------------------------------------------------------------------- .../TestGenericObjectPoolFactoryCreateFailure.java | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/commons-pool/blob/75a47ee1/src/test/java/org/apache/commons/pool2/impl/TestGenericObjectPoolFactoryCreateFailure.java ---------------------------------------------------------------------- diff --git a/src/test/java/org/apache/commons/pool2/impl/TestGenericObjectPoolFactoryCreateFailure.java b/src/test/java/org/apache/commons/pool2/impl/TestGenericObjectPoolFactoryCreateFailure.java index ca5a454..0715b42 100644 --- a/src/test/java/org/apache/commons/pool2/impl/TestGenericObjectPoolFactoryCreateFailure.java +++ b/src/test/java/org/apache/commons/pool2/impl/TestGenericObjectPoolFactoryCreateFailure.java @@ -44,7 +44,10 @@ public class TestGenericObjectPoolFactoryCreateFailure { // now borrow barrier.countDown(); try { - pool.borrowObject(); + System.out.println("try borrow in main thread"); + + Object o = pool.borrowObject(); + System.out.println("Success borrow in main thread " + o); } catch (Exception e) { e.printStackTrace(); } @@ -71,12 +74,7 @@ public class TestGenericObjectPoolFactoryCreateFailure { @Override public boolean validateObject(PooledObject<Object> p) { - // return valid once - if (!validated.getAndSet(true)) { - return true; - } - System.out.println("invalid"); - return false; + return true; } } @@ -92,6 +90,7 @@ public class TestGenericObjectPoolFactoryCreateFailure { @Override public void run() { try { + System.out.println("start borrowing in parallel thread"); Object obj = pool.borrowObject(); // wait for another thread to start borrowObject @@ -104,6 +103,7 @@ public class TestGenericObjectPoolFactoryCreateFailure { } pool.returnObject(obj); + System.out.println("ended borrowing in parallel thread"); } catch (Exception e) { failed.set(true); e.printStackTrace();
