This is an automated email from the ASF dual-hosted git repository. erans pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-geometry.git
commit 96323030da8191dca82b3d854d64edf5ce39b1ea Author: Gilles Sadowski <gil...@harfang.homelinux.org> AuthorDate: Mon Sep 17 15:32:27 2018 +0200 Nit. Avoid floating-point as loop boundaries. --- .../java/org/apache/commons/geometry/euclidean/twod/Vector2DTest.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/commons-geometry-euclidean/src/test/java/org/apache/commons/geometry/euclidean/twod/Vector2DTest.java b/commons-geometry-euclidean/src/test/java/org/apache/commons/geometry/euclidean/twod/Vector2DTest.java index 0beb633..a3e43fe 100644 --- a/commons-geometry-euclidean/src/test/java/org/apache/commons/geometry/euclidean/twod/Vector2DTest.java +++ b/commons-geometry-euclidean/src/test/java/org/apache/commons/geometry/euclidean/twod/Vector2DTest.java @@ -189,8 +189,8 @@ public class Vector2DTest { checkVector(Vector2D.PLUS_X.withMagnitude(2.5), 2.5, 0.0); checkVector(Vector2D.MINUS_Y.withMagnitude(3.14), 0.0, -3.14); - for (double mag = -10.0; mag <= 10.0; ++mag) - { + for (int i = -10; i <= 10; i++) { + final double mag = i; Assert.assertEquals(Math.abs(mag), v.withMagnitude(mag).getMagnitude(), eps); } }