Repository: commons-text Updated Branches: refs/heads/master 9273e5eda -> 9dd0e051e
tests: fix junit usage in a few instances - for assertNotNull the order is value, message. In this case the wrong order impact is that nothing is tested. Im - for assertEquals the order is expected, actual. In this case the wrong order just results in a weird error message. Project: http://git-wip-us.apache.org/repos/asf/commons-text/repo Commit: http://git-wip-us.apache.org/repos/asf/commons-text/commit/9dd0e051 Tree: http://git-wip-us.apache.org/repos/asf/commons-text/tree/9dd0e051 Diff: http://git-wip-us.apache.org/repos/asf/commons-text/diff/9dd0e051 Branch: refs/heads/master Commit: 9dd0e051e44e842bc3ee81fdd3bb32b42279be82 Parents: 9273e5e Author: Eitan Adler <li...@eitanadler.com> Authored: Thu Aug 23 23:21:59 2018 -0700 Committer: Eitan Adler <li...@eitanadler.com> Committed: Thu Aug 23 23:29:40 2018 -0700 ---------------------------------------------------------------------- .../java/org/apache/commons/text/ExtendedMessageFormatTest.java | 2 +- .../java/org/apache/commons/text/lookup/DateStringLookupTest.java | 2 +- .../apache/commons/text/lookup/InterpolatorStringLookupTest.java | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/commons-text/blob/9dd0e051/src/test/java/org/apache/commons/text/ExtendedMessageFormatTest.java ---------------------------------------------------------------------- diff --git a/src/test/java/org/apache/commons/text/ExtendedMessageFormatTest.java b/src/test/java/org/apache/commons/text/ExtendedMessageFormatTest.java index 0563826..626ae93 100644 --- a/src/test/java/org/apache/commons/text/ExtendedMessageFormatTest.java +++ b/src/test/java/org/apache/commons/text/ExtendedMessageFormatTest.java @@ -84,7 +84,7 @@ public class ExtendedMessageFormatTest { public void testEmbeddedPatternInChoice() { final String pattern = "Hi {0,lower}, got {1,choice,0#none|1#one|1<{1,number}}, {2,upper}!"; final ExtendedMessageFormat emf = new ExtendedMessageFormat(pattern, registry); - assertEquals(emf.format(new Object[] {"there", 3, "great"}), "Hi there, got 3, GREAT!"); + assertEquals("Hi there, got 3, GREAT!", emf.format(new Object[] {"there", 3, "great"})); } /** http://git-wip-us.apache.org/repos/asf/commons-text/blob/9dd0e051/src/test/java/org/apache/commons/text/lookup/DateStringLookupTest.java ---------------------------------------------------------------------- diff --git a/src/test/java/org/apache/commons/text/lookup/DateStringLookupTest.java b/src/test/java/org/apache/commons/text/lookup/DateStringLookupTest.java index 020baf3..7a46c94 100644 --- a/src/test/java/org/apache/commons/text/lookup/DateStringLookupTest.java +++ b/src/test/java/org/apache/commons/text/lookup/DateStringLookupTest.java @@ -40,7 +40,7 @@ public class DateStringLookupTest { public void testFormat() { final String fomat = "yyyy-MM-dd"; final String value = DateStringLookup.INSTANCE.lookup(fomat); - assertNotNull("No Date", value); + assertNotNull(value, "No Date"); final SimpleDateFormat format = new SimpleDateFormat(fomat); final String today = format.format(new Date()); assertEquals(value, today); http://git-wip-us.apache.org/repos/asf/commons-text/blob/9dd0e051/src/test/java/org/apache/commons/text/lookup/InterpolatorStringLookupTest.java ---------------------------------------------------------------------- diff --git a/src/test/java/org/apache/commons/text/lookup/InterpolatorStringLookupTest.java b/src/test/java/org/apache/commons/text/lookup/InterpolatorStringLookupTest.java index 595d20c..3954c5a 100644 --- a/src/test/java/org/apache/commons/text/lookup/InterpolatorStringLookupTest.java +++ b/src/test/java/org/apache/commons/text/lookup/InterpolatorStringLookupTest.java @@ -81,7 +81,7 @@ public class InterpolatorStringLookupTest { value = lookup.lookup("env:PATH"); assertNotNull(value); value = lookup.lookup("date:yyyy-MM-dd"); - assertNotNull("No Date", value); + assertNotNull(value, "No Date"); final SimpleDateFormat format = new SimpleDateFormat("yyyy-MM-dd"); final String today = format.format(new Date()); assertEquals(value, today);
