Repository: commons-dbcp Updated Branches: refs/heads/master 16c46bdb4 -> 749e5b391
Add comment. Project: http://git-wip-us.apache.org/repos/asf/commons-dbcp/repo Commit: http://git-wip-us.apache.org/repos/asf/commons-dbcp/commit/749e5b39 Tree: http://git-wip-us.apache.org/repos/asf/commons-dbcp/tree/749e5b39 Diff: http://git-wip-us.apache.org/repos/asf/commons-dbcp/diff/749e5b39 Branch: refs/heads/master Commit: 749e5b3918721a1143905e1482916d8674128a5e Parents: 16c46bd Author: Gary Gregory <garydgreg...@gmail.com> Authored: Thu Aug 16 13:13:57 2018 -0600 Committer: Gary Gregory <garydgreg...@gmail.com> Committed: Thu Aug 16 13:13:57 2018 -0600 ---------------------------------------------------------------------- .../org/apache/commons/dbcp2/cpdsadapter/DriverAdapterCPDS.java | 4 ++++ 1 file changed, 4 insertions(+) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/commons-dbcp/blob/749e5b39/src/main/java/org/apache/commons/dbcp2/cpdsadapter/DriverAdapterCPDS.java ---------------------------------------------------------------------- diff --git a/src/main/java/org/apache/commons/dbcp2/cpdsadapter/DriverAdapterCPDS.java b/src/main/java/org/apache/commons/dbcp2/cpdsadapter/DriverAdapterCPDS.java index eb0d472..58aafcc 100644 --- a/src/main/java/org/apache/commons/dbcp2/cpdsadapter/DriverAdapterCPDS.java +++ b/src/main/java/org/apache/commons/dbcp2/cpdsadapter/DriverAdapterCPDS.java @@ -19,6 +19,9 @@ package org.apache.commons.dbcp2.cpdsadapter; import java.io.PrintWriter; import java.io.Serializable; +import java.net.URI; +import java.net.URISyntaxException; +import java.net.URL; import java.sql.DriverManager; import java.sql.SQLException; import java.sql.SQLFeatureNotSupportedException; @@ -742,6 +745,7 @@ public class DriverAdapterCPDS implements ConnectionPoolDataSource, Referenceabl builder.append("[description="); builder.append(description); builder.append(", url="); + // TODO What if the connection string contains a 'password' query parameter but that connection string is not in a legal URL format? builder.append(url); builder.append(", userName="); builder.append(userName);
