Refactor to type cast once. Project: http://git-wip-us.apache.org/repos/asf/commons-dbcp/repo Commit: http://git-wip-us.apache.org/repos/asf/commons-dbcp/commit/e5707c51 Tree: http://git-wip-us.apache.org/repos/asf/commons-dbcp/tree/e5707c51 Diff: http://git-wip-us.apache.org/repos/asf/commons-dbcp/diff/e5707c51
Branch: refs/heads/release Commit: e5707c51408626d40bc07c70e337494386343feb Parents: bba1b11 Author: Gary Gregory <garydgreg...@gmail.com> Authored: Wed Jun 20 11:27:25 2018 -0600 Committer: Gary Gregory <garydgreg...@gmail.com> Committed: Wed Jun 20 11:27:25 2018 -0600 ---------------------------------------------------------------------- .../org/apache/commons/dbcp2/PoolableConnectionFactory.java | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/commons-dbcp/blob/e5707c51/src/main/java/org/apache/commons/dbcp2/PoolableConnectionFactory.java ---------------------------------------------------------------------- diff --git a/src/main/java/org/apache/commons/dbcp2/PoolableConnectionFactory.java b/src/main/java/org/apache/commons/dbcp2/PoolableConnectionFactory.java index 581d3ad..427bd36 100644 --- a/src/main/java/org/apache/commons/dbcp2/PoolableConnectionFactory.java +++ b/src/main/java/org/apache/commons/dbcp2/PoolableConnectionFactory.java @@ -324,10 +324,11 @@ public class PoolableConnectionFactory implements PooledObjectFactory<PoolableCo } else { config.setJmxEnabled(false); } + final PoolingConnection poolingConn = (PoolingConnection) conn; final KeyedObjectPool<PStmtKey, DelegatingPreparedStatement> stmtPool = new GenericKeyedObjectPool<>( - (PoolingConnection) conn, config); - ((PoolingConnection) conn).setStatementPool(stmtPool); - ((PoolingConnection) conn).setCacheState(cacheState); + poolingConn, config); + poolingConn.setStatementPool(stmtPool); + poolingConn.setCacheState(cacheState); } // Register this connection with JMX
