Repository: commons-dbcp Updated Branches: refs/heads/master 040cc81c3 -> 9f6fd35b1
Add missing Javadoc. Better param name. Project: http://git-wip-us.apache.org/repos/asf/commons-dbcp/repo Commit: http://git-wip-us.apache.org/repos/asf/commons-dbcp/commit/9f6fd35b Tree: http://git-wip-us.apache.org/repos/asf/commons-dbcp/tree/9f6fd35b Diff: http://git-wip-us.apache.org/repos/asf/commons-dbcp/diff/9f6fd35b Branch: refs/heads/master Commit: 9f6fd35b16cdd19bf5fa3e8abaed17852bc1dbd8 Parents: 040cc81 Author: Gary Gregory <garydgreg...@gmail.com> Authored: Mon Jun 11 17:03:08 2018 -0600 Committer: Gary Gregory <garydgreg...@gmail.com> Committed: Mon Jun 11 17:03:08 2018 -0600 ---------------------------------------------------------------------- .../apache/commons/dbcp2/PoolingConnection.java | 24 +++++++++++++------- 1 file changed, 16 insertions(+), 8 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/commons-dbcp/blob/9f6fd35b/src/main/java/org/apache/commons/dbcp2/PoolingConnection.java ---------------------------------------------------------------------- diff --git a/src/main/java/org/apache/commons/dbcp2/PoolingConnection.java b/src/main/java/org/apache/commons/dbcp2/PoolingConnection.java index 07d60ae..edf07e1 100644 --- a/src/main/java/org/apache/commons/dbcp2/PoolingConnection.java +++ b/src/main/java/org/apache/commons/dbcp2/PoolingConnection.java @@ -80,12 +80,13 @@ public class PoolingConnection extends DelegatingConnection<Connection> * * @param key * ignored - * @param p + * @param pooledObject * wrapped pooled statement to be activated */ @Override - public void activateObject(final PStmtKey key, final PooledObject<DelegatingPreparedStatement> p) throws Exception { - p.getObject().activate(); + public void activateObject(final PStmtKey key, final PooledObject<DelegatingPreparedStatement> pooledObject) + throws Exception { + pooledObject.getObject().activate(); } /** @@ -293,12 +294,13 @@ public class PoolingConnection extends DelegatingConnection<Connection> * * @param key * ignored - * @param p + * @param pooledObject * the wrapped pooled statement to be destroyed. */ @Override - public void destroyObject(final PStmtKey key, final PooledObject<DelegatingPreparedStatement> p) throws Exception { - p.getObject().getInnermostDelegate().close(); + public void destroyObject(final PStmtKey key, final PooledObject<DelegatingPreparedStatement> pooledObject) + throws Exception { + pooledObject.getObject().getInnermostDelegate().close(); } /** @@ -579,6 +581,12 @@ public class PoolingConnection extends DelegatingConnection<Connection> } } + /** + * Sets the prepared statement pool. + * + * @param pool + * the prepared statement pool. + */ public void setStatementPool(final KeyedObjectPool<PStmtKey, DelegatingPreparedStatement> pool) { pstmtPool = pool; } @@ -596,12 +604,12 @@ public class PoolingConnection extends DelegatingConnection<Connection> * * @param key * ignored - * @param p + * @param pooledObject * ignored * @return {@code true} */ @Override - public boolean validateObject(final PStmtKey key, final PooledObject<DelegatingPreparedStatement> p) { + public boolean validateObject(final PStmtKey key, final PooledObject<DelegatingPreparedStatement> pooledObject) { return true; } }