Repository: commons-dbcp Updated Branches: refs/heads/master b68e9f59c -> 43b203c81
Remove old comment. Project: http://git-wip-us.apache.org/repos/asf/commons-dbcp/repo Commit: http://git-wip-us.apache.org/repos/asf/commons-dbcp/commit/43b203c8 Tree: http://git-wip-us.apache.org/repos/asf/commons-dbcp/tree/43b203c8 Diff: http://git-wip-us.apache.org/repos/asf/commons-dbcp/diff/43b203c8 Branch: refs/heads/master Commit: 43b203c81c7d6d6deadce5c25e815c82fe74ec49 Parents: b68e9f5 Author: Gary Gregory <garydgreg...@gmail.com> Authored: Sun Jun 10 09:20:43 2018 -0600 Committer: Gary Gregory <garydgreg...@gmail.com> Committed: Sun Jun 10 09:20:43 2018 -0600 ---------------------------------------------------------------------- .../dbcp2/cpdsadapter/PooledConnectionImpl.java | 23 -------------------- 1 file changed, 23 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/commons-dbcp/blob/43b203c8/src/main/java/org/apache/commons/dbcp2/cpdsadapter/PooledConnectionImpl.java ---------------------------------------------------------------------- diff --git a/src/main/java/org/apache/commons/dbcp2/cpdsadapter/PooledConnectionImpl.java b/src/main/java/org/apache/commons/dbcp2/cpdsadapter/PooledConnectionImpl.java index ba3105d..e09dd3a 100644 --- a/src/main/java/org/apache/commons/dbcp2/cpdsadapter/PooledConnectionImpl.java +++ b/src/main/java/org/apache/commons/dbcp2/cpdsadapter/PooledConnectionImpl.java @@ -338,29 +338,6 @@ class PooledConnectionImpl @SuppressWarnings("resource") @Override public PooledObject<DelegatingPreparedStatement> makeObject(final PStmtKey key) throws Exception { -// if (null == key) { -// throw new IllegalArgumentException(); -// } -// // _openPstmts++; -// if (null == key.getResultSetType() -// && null == key.getResultSetConcurrency()) { -// if (null == key.getAutoGeneratedKeys()) { -// return new DefaultPooledObject<>(new PoolablePreparedStatement<>( -// connection.prepareStatement(key.getSql()), -// key, pstmtPool, delegatingConnection)); -// } -// return new DefaultPooledObject<>(new PoolablePreparedStatement<>( -// connection.prepareStatement(key.getSql(), -// key.getAutoGeneratedKeys().intValue()), -// key, pstmtPool, delegatingConnection)); -// } -// return new DefaultPooledObject<>(new PoolablePreparedStatement<>( -// connection.prepareStatement(key.getSql(), -// key.getResultSetType().intValue(), -// key.getResultSetConcurrency().intValue()), -// key, pstmtPool, delegatingConnection)); - // - if (null == key) { throw new IllegalArgumentException("Prepared statement key is null or invalid."); }
