Repository: commons-release-plugin Updated Branches: refs/heads/master c476f024e -> 77dd4b425
Make some ivars final. Project: http://git-wip-us.apache.org/repos/asf/commons-release-plugin/repo Commit: http://git-wip-us.apache.org/repos/asf/commons-release-plugin/commit/77dd4b42 Tree: http://git-wip-us.apache.org/repos/asf/commons-release-plugin/tree/77dd4b42 Diff: http://git-wip-us.apache.org/repos/asf/commons-release-plugin/diff/77dd4b42 Branch: refs/heads/master Commit: 77dd4b425e8d511819960a1827994ccab2f95e4e Parents: c476f02 Author: Gary Gregory <garydgreg...@gmail.com> Authored: Wed May 30 11:14:00 2018 -0600 Committer: Gary Gregory <garydgreg...@gmail.com> Committed: Wed May 30 11:14:00 2018 -0600 ---------------------------------------------------------------------- .../plugin/mojos/CommonsDistributionDetachmentMojo.java | 6 +++--- .../release/plugin/velocity/ReadmeHtmlVelocityDelegate.java | 6 +++--- .../plugin/stubs/DistributionDetachmentProjectStub.java | 4 ++-- 3 files changed, 8 insertions(+), 8 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/commons-release-plugin/blob/77dd4b42/src/main/java/org/apache/commons/release/plugin/mojos/CommonsDistributionDetachmentMojo.java ---------------------------------------------------------------------- diff --git a/src/main/java/org/apache/commons/release/plugin/mojos/CommonsDistributionDetachmentMojo.java b/src/main/java/org/apache/commons/release/plugin/mojos/CommonsDistributionDetachmentMojo.java index 05f8816..821b4d1 100755 --- a/src/main/java/org/apache/commons/release/plugin/mojos/CommonsDistributionDetachmentMojo.java +++ b/src/main/java/org/apache/commons/release/plugin/mojos/CommonsDistributionDetachmentMojo.java @@ -74,21 +74,21 @@ public class CommonsDistributionDetachmentMojo extends AbstractMojo { * This list is supposed to hold the Maven references to the aforementioned artifacts so that we * can upload them to svn after they've been detached from the Maven deployment. */ - private List<Artifact> detachedArtifacts = new ArrayList<>(); + private final List<Artifact> detachedArtifacts = new ArrayList<>(); /** * A {@link Properties} of {@link Artifact} â {@link String} containing the sha1 signatures * for the individual artifacts, where the {@link Artifact} is represented as: * <code>groupId:artifactId:version:type=sha1</code>. */ - private Properties artifactSha1s = new Properties(); + private final Properties artifactSha1s = new Properties(); /** * A {@link Properties} of {@link Artifact} â {@link String} containing the sha256 signatures * for the individual artifacts, where the {@link Artifact} is represented as: * <code>groupId:artifactId:version:type=sha1</code>. */ - private Properties artifactSha256s = new Properties(); + private final Properties artifactSha256s = new Properties(); /** * The maven project context injection so that we can get a hold of the variables at hand. http://git-wip-us.apache.org/repos/asf/commons-release-plugin/blob/77dd4b42/src/main/java/org/apache/commons/release/plugin/velocity/ReadmeHtmlVelocityDelegate.java ---------------------------------------------------------------------- diff --git a/src/main/java/org/apache/commons/release/plugin/velocity/ReadmeHtmlVelocityDelegate.java b/src/main/java/org/apache/commons/release/plugin/velocity/ReadmeHtmlVelocityDelegate.java index 2524a11..148f8eb 100755 --- a/src/main/java/org/apache/commons/release/plugin/velocity/ReadmeHtmlVelocityDelegate.java +++ b/src/main/java/org/apache/commons/release/plugin/velocity/ReadmeHtmlVelocityDelegate.java @@ -36,11 +36,11 @@ public class ReadmeHtmlVelocityDelegate { private static final String TEMPLATE = "resources/org/apache/commons/release/plugin" + "/velocity/README.vm"; /** This is supposed to represent the maven artifactId. */ - private String artifactId; + private final String artifactId; /** This is supposed to represent the maven version of the release. */ - private String version; + private final String version; /** The url of the site that gets set into the <code>README.html</code>. */ - private String siteUrl; + private final String siteUrl; /** * The private constructor to be used by the {@link ReadmeHtmlVelocityDelegateBuilder}. http://git-wip-us.apache.org/repos/asf/commons-release-plugin/blob/77dd4b42/src/test/java/org/apache/commons/release/plugin/stubs/DistributionDetachmentProjectStub.java ---------------------------------------------------------------------- diff --git a/src/test/java/org/apache/commons/release/plugin/stubs/DistributionDetachmentProjectStub.java b/src/test/java/org/apache/commons/release/plugin/stubs/DistributionDetachmentProjectStub.java index 7f4fb12..ab201d2 100755 --- a/src/test/java/org/apache/commons/release/plugin/stubs/DistributionDetachmentProjectStub.java +++ b/src/test/java/org/apache/commons/release/plugin/stubs/DistributionDetachmentProjectStub.java @@ -134,9 +134,9 @@ public class DistributionDetachmentProjectStub extends MavenProjectStub { public class DistributionDetachmentArtifactStub extends ArtifactStub { - private File artifact; + private final File artifact; - private String type; + private final String type; public DistributionDetachmentArtifactStub(File file, String type, String artifactId) { this.setArtifactId(artifactId);
