svn commit: r1832451 - /commons/proper/codec/trunk/src/test/java/org/apache/commons/codec/language/ColognePhoneticTest.java

[ggregory]

Author: ggregory
Date: Tue May 29 14:35:14 2018
New Revision: 1832451

URL: http://svn.apache.org/viewvc?rev=1832451&view=rev
Log:
[CODEC-246] ColognePhoneticTest.testIsEncodeEquals missing assertions.

Modified:
    
commons/proper/codec/trunk/src/test/java/org/apache/commons/codec/language/ColognePhoneticTest.java

Modified: 
commons/proper/codec/trunk/src/test/java/org/apache/commons/codec/language/ColognePhoneticTest.java
URL: 
http://svn.apache.org/viewvc/commons/proper/codec/trunk/src/test/java/org/apache/commons/codec/language/ColognePhoneticTest.java?rev=1832451&r1=1832450&r2=1832451&view=diff
==============================================================================
--- 
commons/proper/codec/trunk/src/test/java/org/apache/commons/codec/language/ColognePhoneticTest.java
 (original)
+++ 
commons/proper/codec/trunk/src/test/java/org/apache/commons/codec/language/ColognePhoneticTest.java
 Tue May 29 14:35:14 2018
@@ -20,6 +20,7 @@ package org.apache.commons.codec.languag
 import org.apache.commons.codec.EncoderException;
 import org.apache.commons.codec.StringEncoderAbstractTest;
 import org.junit.Assert;
+import org.junit.Ignore;
 import org.junit.Test;
 
 /**
@@ -133,8 +134,8 @@ public class ColognePhoneticTest extends
 
     @Test
     public void testIsEncodeEquals() {
+        //@formatter:off
         final String[][] data = {
-            {"Meyer", "M\u00fcller"}, // Müller
             {"Meyer", "Mayr"},
             {"house", "house"},
             {"House", "house"},
@@ -142,11 +143,26 @@ public class ColognePhoneticTest extends
             {"ganz", "Gans"},
             {"ganz", "G\u00e4nse"}, // Gänse
             {"Miyagi", "Miyako"}};
+        //@formatter:on
+        for (final String[] element : data) {
+            final boolean encodeEqual = 
this.getStringEncoder().isEncodeEqual(element[1], element[0]);
+            Assert.assertTrue(element[1] + " != " + element[0], encodeEqual);
+        }
+    }
+
+    @Test
+    @Ignore("https://issues.apache.org/jira/browse/CODEC-246";)
+    public void testIsEncodeEqualsCodec246() {
+        //@formatter:off
+        final String[][] data = {
+            {"Meyer", "M\u00fcller"}, // Müller
+            };
+        //@formatter:on
         for (final String[] element : data) {
             // This just compares and only shows we do not blow up
             final boolean encodeEqual = 
this.getStringEncoder().isEncodeEqual(element[1], element[0]);
             // Fails for https://issues.apache.org/jira/browse/CODEC-246
-            // Assert.assertTrue(element[1] + " != " + element[0], 
encodeEqual);
+            Assert.assertTrue(element[1] + " != " + element[0], encodeEqual);
         }
     }