Repository: commons-release-plugin Updated Branches: refs/heads/master 9eda2649c -> 20ed13cd7
Use Apache Commons IO to copy streams instead of custom code. Project: http://git-wip-us.apache.org/repos/asf/commons-release-plugin/repo Commit: http://git-wip-us.apache.org/repos/asf/commons-release-plugin/commit/20ed13cd Tree: http://git-wip-us.apache.org/repos/asf/commons-release-plugin/tree/20ed13cd Diff: http://git-wip-us.apache.org/repos/asf/commons-release-plugin/diff/20ed13cd Branch: refs/heads/master Commit: 20ed13cd7aa90f4fd88711feee6f064bb108a9b7 Parents: 9eda264 Author: Gary Gregory <garydgreg...@gmail.com> Authored: Fri May 18 09:43:03 2018 -0600 Committer: Gary Gregory <garydgreg...@gmail.com> Committed: Fri May 18 09:43:03 2018 -0600 ---------------------------------------------------------------------- .../mojos/CommonsSiteCompressionMojo.java | 27 ++++++++------------ 1 file changed, 11 insertions(+), 16 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/commons-release-plugin/blob/20ed13cd/src/main/java/org/apache/commons/release/plugin/mojos/CommonsSiteCompressionMojo.java ---------------------------------------------------------------------- diff --git a/src/main/java/org/apache/commons/release/plugin/mojos/CommonsSiteCompressionMojo.java b/src/main/java/org/apache/commons/release/plugin/mojos/CommonsSiteCompressionMojo.java index c27d83e..74983f1 100644 --- a/src/main/java/org/apache/commons/release/plugin/mojos/CommonsSiteCompressionMojo.java +++ b/src/main/java/org/apache/commons/release/plugin/mojos/CommonsSiteCompressionMojo.java @@ -16,10 +16,19 @@ */ package org.apache.commons.release.plugin.mojos; +import java.io.File; +import java.io.FileInputStream; +import java.io.FileOutputStream; +import java.io.IOException; +import java.util.ArrayList; +import java.util.List; +import java.util.zip.ZipEntry; +import java.util.zip.ZipOutputStream; + import org.apache.commons.compress.archivers.zip.ParallelScatterZipCreator; import org.apache.commons.compress.archivers.zip.ScatterZipOutputStream; +import org.apache.commons.io.IOUtils; import org.apache.commons.lang3.StringUtils; -import org.apache.commons.release.plugin.SharedFunctions; import org.apache.maven.plugin.AbstractMojo; import org.apache.maven.plugin.MojoExecutionException; import org.apache.maven.plugin.MojoFailureException; @@ -27,15 +36,6 @@ import org.apache.maven.plugins.annotations.LifecyclePhase; import org.apache.maven.plugins.annotations.Mojo; import org.apache.maven.plugins.annotations.Parameter; -import java.io.File; -import java.io.FileInputStream; -import java.io.FileOutputStream; -import java.io.IOException; -import java.util.ArrayList; -import java.util.List; -import java.util.zip.ZipEntry; -import java.util.zip.ZipOutputStream; - /** * Takes the built <code>./target/site</code> directory and compresses it to * <code>./target/commons-release-plugin/site.zip</code>. @@ -183,12 +183,7 @@ public class CommonsSiteCompressionMojo extends AbstractMojo { file.getCanonicalPath().length()); ZipEntry zipEntry = new ZipEntry(zipFilePath); zos.putNextEntry(zipEntry); - byte[] bytes = new byte[SharedFunctions.BUFFER_BYTE_SIZE]; - int length; - while ((length = fis.read(bytes)) >= 0) { - zos.write(bytes, 0, length); - } - zos.closeEntry(); + IOUtils.copy(fis, zos); } } }
