Nit-picking.
Project: http://git-wip-us.apache.org/repos/asf/commons-rng/repo Commit: http://git-wip-us.apache.org/repos/asf/commons-rng/commit/cb807a1a Tree: http://git-wip-us.apache.org/repos/asf/commons-rng/tree/cb807a1a Diff: http://git-wip-us.apache.org/repos/asf/commons-rng/diff/cb807a1a Branch: refs/heads/master Commit: cb807a1afc44feacb580f5ec1d0e4a16cc7e7396 Parents: 84acbf3 Author: Gilles <er...@apache.org> Authored: Fri Jan 12 13:50:07 2018 +0100 Committer: Gilles <er...@apache.org> Committed: Fri Jan 12 13:50:07 2018 +0100 ---------------------------------------------------------------------- .../commons/rng/sampling/distribution/PoissonSampler.java | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/commons-rng/blob/cb807a1a/commons-rng-sampling/src/main/java/org/apache/commons/rng/sampling/distribution/PoissonSampler.java ---------------------------------------------------------------------- diff --git a/commons-rng-sampling/src/main/java/org/apache/commons/rng/sampling/distribution/PoissonSampler.java b/commons-rng-sampling/src/main/java/org/apache/commons/rng/sampling/distribution/PoissonSampler.java index 2e2d46d..195e725 100644 --- a/commons-rng-sampling/src/main/java/org/apache/commons/rng/sampling/distribution/PoissonSampler.java +++ b/commons-rng-sampling/src/main/java/org/apache/commons/rng/sampling/distribution/PoissonSampler.java @@ -129,8 +129,9 @@ public class PoissonSampler final double u = nextDouble(); if (u <= p1) { final double n = gaussian.sample(); - x = n * Math.sqrt(lambda + halfDelta) - 0.5d; - if (x > delta || x < -lambda) { + x = n * Math.sqrt(lambda + halfDelta) - 0.5; + if (x > delta || + x < -lambda) { continue; } y = x < 0 ? Math.floor(x) : Math.ceil(x);
