Repository: commons-pool Updated Branches: refs/heads/master 3a09397eb -> ffb4f541c
Comment empty blocks. Project: http://git-wip-us.apache.org/repos/asf/commons-pool/repo Commit: http://git-wip-us.apache.org/repos/asf/commons-pool/commit/ffb4f541 Tree: http://git-wip-us.apache.org/repos/asf/commons-pool/tree/ffb4f541 Diff: http://git-wip-us.apache.org/repos/asf/commons-pool/diff/ffb4f541 Branch: refs/heads/master Commit: ffb4f541cc57166f249af1106b9c65722c419c7b Parents: 3a09397 Author: Gary Gregory <ggreg...@apache.org> Authored: Wed Nov 1 09:22:50 2017 -0600 Committer: Gary Gregory <ggreg...@apache.org> Committed: Wed Nov 1 09:22:50 2017 -0600 ---------------------------------------------------------------------- .../org/apache/commons/pool2/BaseKeyedPooledObjectFactory.java | 3 +++ .../java/org/apache/commons/pool2/BasePooledObjectFactory.java | 3 +++ .../org/apache/commons/pool2/impl/SoftReferenceObjectPool.java | 4 +++- 3 files changed, 9 insertions(+), 1 deletion(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/commons-pool/blob/ffb4f541/src/main/java/org/apache/commons/pool2/BaseKeyedPooledObjectFactory.java ---------------------------------------------------------------------- diff --git a/src/main/java/org/apache/commons/pool2/BaseKeyedPooledObjectFactory.java b/src/main/java/org/apache/commons/pool2/BaseKeyedPooledObjectFactory.java index 2d5577b..4ea9265 100644 --- a/src/main/java/org/apache/commons/pool2/BaseKeyedPooledObjectFactory.java +++ b/src/main/java/org/apache/commons/pool2/BaseKeyedPooledObjectFactory.java @@ -71,6 +71,7 @@ public abstract class BaseKeyedPooledObjectFactory<K,V> extends BaseObject @Override public void destroyObject(final K key, final PooledObject<V> p) throws Exception { + // The default implementation is a no-op. } /** @@ -98,6 +99,7 @@ public abstract class BaseKeyedPooledObjectFactory<K,V> extends BaseObject @Override public void activateObject(final K key, final PooledObject<V> p) throws Exception { + // The default implementation is a no-op. } /** @@ -111,5 +113,6 @@ public abstract class BaseKeyedPooledObjectFactory<K,V> extends BaseObject @Override public void passivateObject(final K key, final PooledObject<V> p) throws Exception { + // The default implementation is a no-op. } } http://git-wip-us.apache.org/repos/asf/commons-pool/blob/ffb4f541/src/main/java/org/apache/commons/pool2/BasePooledObjectFactory.java ---------------------------------------------------------------------- diff --git a/src/main/java/org/apache/commons/pool2/BasePooledObjectFactory.java b/src/main/java/org/apache/commons/pool2/BasePooledObjectFactory.java index 41d85c4..000632b 100644 --- a/src/main/java/org/apache/commons/pool2/BasePooledObjectFactory.java +++ b/src/main/java/org/apache/commons/pool2/BasePooledObjectFactory.java @@ -66,6 +66,7 @@ public abstract class BasePooledObjectFactory<T> extends BaseObject implements P @Override public void destroyObject(final PooledObject<T> p) throws Exception { + // The default implementation is a no-op. } /** @@ -87,6 +88,7 @@ public abstract class BasePooledObjectFactory<T> extends BaseObject implements P */ @Override public void activateObject(final PooledObject<T> p) throws Exception { + // The default implementation is a no-op. } /** @@ -97,5 +99,6 @@ public abstract class BasePooledObjectFactory<T> extends BaseObject implements P @Override public void passivateObject(final PooledObject<T> p) throws Exception { + // The default implementation is a no-op. } } http://git-wip-us.apache.org/repos/asf/commons-pool/blob/ffb4f541/src/main/java/org/apache/commons/pool2/impl/SoftReferenceObjectPool.java ---------------------------------------------------------------------- diff --git a/src/main/java/org/apache/commons/pool2/impl/SoftReferenceObjectPool.java b/src/main/java/org/apache/commons/pool2/impl/SoftReferenceObjectPool.java index 0f6bcc5..c5533f9 100644 --- a/src/main/java/org/apache/commons/pool2/impl/SoftReferenceObjectPool.java +++ b/src/main/java/org/apache/commons/pool2/impl/SoftReferenceObjectPool.java @@ -376,7 +376,9 @@ public class SoftReferenceObjectPool<T> extends BaseObjectPool<T> { // Remove wrappers for enqueued references from idle and allReferences lists removeClearedReferences(idleReferences.iterator()); removeClearedReferences(allReferences.iterator()); - while (refQueue.poll() != null) {} + while (refQueue.poll() != null) { + // empty + } } /**
