Repository: commons-text Updated Branches: refs/heads/master f90572543 -> 61cbf0afe
WordUtils: use StringBuilder#append(CharSequence, int, int) were possible to improve performance (similar to LANG-1358, thanks to Stephane Landelle for the suggestion) Project: http://git-wip-us.apache.org/repos/asf/commons-text/repo Commit: http://git-wip-us.apache.org/repos/asf/commons-text/commit/61cbf0af Tree: http://git-wip-us.apache.org/repos/asf/commons-text/tree/61cbf0af Diff: http://git-wip-us.apache.org/repos/asf/commons-text/diff/61cbf0af Branch: refs/heads/master Commit: 61cbf0afe04d86a546e7094513328c9f7a7363ae Parents: f905725 Author: Pascal Schumacher <pascalschumac...@gmx.net> Authored: Thu Oct 12 20:05:50 2017 +0200 Committer: Pascal Schumacher <pascalschumac...@gmx.net> Committed: Thu Oct 12 20:13:40 2017 +0200 ---------------------------------------------------------------------- .../java/org/apache/commons/text/WordUtils.java | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/commons-text/blob/61cbf0af/src/main/java/org/apache/commons/text/WordUtils.java ---------------------------------------------------------------------- diff --git a/src/main/java/org/apache/commons/text/WordUtils.java b/src/main/java/org/apache/commons/text/WordUtils.java index 6871467..1a6a407 100644 --- a/src/main/java/org/apache/commons/text/WordUtils.java +++ b/src/main/java/org/apache/commons/text/WordUtils.java @@ -323,7 +323,7 @@ public class WordUtils { if (spaceToWrapAt >= offset) { // normal case - wrappedLine.append(str.substring(offset, spaceToWrapAt)); + wrappedLine.append(str, offset, spaceToWrapAt); wrappedLine.append(newLineStr); offset = spaceToWrapAt + 1; @@ -331,7 +331,7 @@ public class WordUtils { // really long word or URL if (wrapLongWords) { // wrap really long word one line at a time - wrappedLine.append(str.substring(offset, wrapLength + offset)); + wrappedLine.append(str, offset, wrapLength + offset); wrappedLine.append(newLineStr); offset += wrapLength; } else { @@ -342,11 +342,11 @@ public class WordUtils { } if (spaceToWrapAt >= 0) { - wrappedLine.append(str.substring(offset, spaceToWrapAt)); + wrappedLine.append(str, offset, spaceToWrapAt); wrappedLine.append(newLineStr); offset = spaceToWrapAt + 1; } else { - wrappedLine.append(str.substring(offset)); + wrappedLine.append(str, offset, str.length()); offset = inputLineLength; } } @@ -354,7 +354,7 @@ public class WordUtils { } // Whatever is left in line is short enough to just pass through - wrappedLine.append(str.substring(offset)); + wrappedLine.append(str, offset, str.length()); return wrappedLine.toString(); } @@ -856,16 +856,16 @@ public class WordUtils { final StringBuilder result = new StringBuilder(); final int index = StringUtils.indexOf(str, " ", lower); if (index == -1) { - result.append(str.substring(0, upper)); + result.append(str, 0, upper); // only if abbreviation has occured do we append the appendToEnd value if (upper != str.length()) { result.append(StringUtils.defaultString(appendToEnd)); } } else if (index > upper) { - result.append(str.substring(0, upper)); + result.append(str, 0, upper); result.append(StringUtils.defaultString(appendToEnd)); } else { - result.append(str.substring(0, index)); + result.append(str, 0, index); result.append(StringUtils.defaultString(appendToEnd)); }