Repository: commons-io Updated Branches: refs/heads/master c4c86e2d3 -> fcca356d6
Remove unnecessary casts. Project: http://git-wip-us.apache.org/repos/asf/commons-io/repo Commit: http://git-wip-us.apache.org/repos/asf/commons-io/commit/fcca356d Tree: http://git-wip-us.apache.org/repos/asf/commons-io/tree/fcca356d Diff: http://git-wip-us.apache.org/repos/asf/commons-io/diff/fcca356d Branch: refs/heads/master Commit: fcca356d6a1bf190d335ed1db4cba5233f7b24d2 Parents: c4c86e2 Author: Gary Gregory <ggreg...@apache.org> Authored: Wed Sep 27 13:28:20 2017 -0600 Committer: Gary Gregory <ggreg...@apache.org> Committed: Wed Sep 27 13:28:20 2017 -0600 ---------------------------------------------------------------------- .../org/apache/commons/io/CopyUtilsTest.java | 2 +- .../commons/io/FileCleaningTrackerTestCase.java | 2 +- .../commons/io/FileDeleteStrategyTestCase.java | 6 +- .../commons/io/FileUtilsFileNewerTestCase.java | 4 +- .../apache/commons/io/FileUtilsTestCase.java | 60 ++++++++++---------- .../commons/io/FilenameUtilsTestCase.java | 8 +-- .../apache/commons/io/IOUtilsCopyTestCase.java | 2 +- .../org/apache/commons/io/IOUtilsTestCase.java | 2 +- .../apache/commons/io/IOUtilsWriteTestCase.java | 2 +- .../comparator/CompositeFileComparatorTest.java | 8 +-- .../LastModifiedFileComparatorTest.java | 6 +- .../io/comparator/SizeFileComparatorTest.java | 6 +- .../io/filefilter/FileFilterTestCase.java | 42 +++++++------- .../io/output/AppendableOutputStreamTest.java | 2 +- .../commons/io/output/ProxyWriterTest.java | 2 +- 15 files changed, 77 insertions(+), 77 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/commons-io/blob/fcca356d/src/test/java/org/apache/commons/io/CopyUtilsTest.java ---------------------------------------------------------------------- diff --git a/src/test/java/org/apache/commons/io/CopyUtilsTest.java b/src/test/java/org/apache/commons/io/CopyUtilsTest.java index 93e186c..6df9afa 100644 --- a/src/test/java/org/apache/commons/io/CopyUtilsTest.java +++ b/src/test/java/org/apache/commons/io/CopyUtilsTest.java @@ -62,7 +62,7 @@ public class CopyUtilsTest { private static final int FILE_SIZE = 1024 * 4 + 1; - private final byte[] inData = TestUtils.generateTestData((long) FILE_SIZE); + private final byte[] inData = TestUtils.generateTestData(FILE_SIZE); // ---------------------------------------------------------------- // Tests http://git-wip-us.apache.org/repos/asf/commons-io/blob/fcca356d/src/test/java/org/apache/commons/io/FileCleaningTrackerTestCase.java ---------------------------------------------------------------------- diff --git a/src/test/java/org/apache/commons/io/FileCleaningTrackerTestCase.java b/src/test/java/org/apache/commons/io/FileCleaningTrackerTestCase.java index 37ae0dd..72d2d6f 100644 --- a/src/test/java/org/apache/commons/io/FileCleaningTrackerTestCase.java +++ b/src/test/java/org/apache/commons/io/FileCleaningTrackerTestCase.java @@ -159,7 +159,7 @@ public class FileCleaningTrackerTestCase { } try (final BufferedOutputStream output = new BufferedOutputStream(new FileOutputStream(testFile))) { - TestUtils.generateTestData(output, (long) 100); + TestUtils.generateTestData(output, 100); } assertTrue(testFile.exists()); assertTrue(getTestDirectory().exists()); http://git-wip-us.apache.org/repos/asf/commons-io/blob/fcca356d/src/test/java/org/apache/commons/io/FileDeleteStrategyTestCase.java ---------------------------------------------------------------------- diff --git a/src/test/java/org/apache/commons/io/FileDeleteStrategyTestCase.java b/src/test/java/org/apache/commons/io/FileDeleteStrategyTestCase.java index 3d76ea6..51df9e7 100644 --- a/src/test/java/org/apache/commons/io/FileDeleteStrategyTestCase.java +++ b/src/test/java/org/apache/commons/io/FileDeleteStrategyTestCase.java @@ -59,7 +59,7 @@ public class FileDeleteStrategyTestCase { } try (final BufferedOutputStream output = new BufferedOutputStream(new FileOutputStream(subFile))) { - TestUtils.generateTestData(output, (long) 16); + TestUtils.generateTestData(output, 16); } assertTrue(subDir.exists()); @@ -97,7 +97,7 @@ public class FileDeleteStrategyTestCase { } try (final BufferedOutputStream output = new BufferedOutputStream(new FileOutputStream(subFile))) { - TestUtils.generateTestData(output, (long) 16); + TestUtils.generateTestData(output, 16); } assertTrue(subDir.exists()); @@ -130,7 +130,7 @@ public class FileDeleteStrategyTestCase { } try (final BufferedOutputStream output = new BufferedOutputStream(new FileOutputStream(subFile))) { - TestUtils.generateTestData(output, (long) 16); + TestUtils.generateTestData(output, 16); } assertTrue(subDir.exists()); http://git-wip-us.apache.org/repos/asf/commons-io/blob/fcca356d/src/test/java/org/apache/commons/io/FileUtilsFileNewerTestCase.java ---------------------------------------------------------------------- diff --git a/src/test/java/org/apache/commons/io/FileUtilsFileNewerTestCase.java b/src/test/java/org/apache/commons/io/FileUtilsFileNewerTestCase.java index 1f35b3d..53f81ff 100644 --- a/src/test/java/org/apache/commons/io/FileUtilsFileNewerTestCase.java +++ b/src/test/java/org/apache/commons/io/FileUtilsFileNewerTestCase.java @@ -66,7 +66,7 @@ public class FileUtilsFileNewerTestCase { } try (final BufferedOutputStream output1 = new BufferedOutputStream(new FileOutputStream(m_testFile1))) { - TestUtils.generateTestData(output1, (long) FILE1_SIZE); + TestUtils.generateTestData(output1, FILE1_SIZE); } if (!m_testFile2.getParentFile().exists()) { throw new IOException("Cannot create file " + m_testFile2 @@ -74,7 +74,7 @@ public class FileUtilsFileNewerTestCase { } try (final BufferedOutputStream output = new BufferedOutputStream(new FileOutputStream(m_testFile2))) { - TestUtils.generateTestData(output, (long) FILE2_SIZE); + TestUtils.generateTestData(output, FILE2_SIZE); } } http://git-wip-us.apache.org/repos/asf/commons-io/blob/fcca356d/src/test/java/org/apache/commons/io/FileUtilsTestCase.java ---------------------------------------------------------------------- diff --git a/src/test/java/org/apache/commons/io/FileUtilsTestCase.java b/src/test/java/org/apache/commons/io/FileUtilsTestCase.java index 3d10a76..e4a7e45 100644 --- a/src/test/java/org/apache/commons/io/FileUtilsTestCase.java +++ b/src/test/java/org/apache/commons/io/FileUtilsTestCase.java @@ -124,7 +124,7 @@ public class FileUtilsTestCase { } try (final BufferedOutputStream output3 = new BufferedOutputStream(new FileOutputStream(testFile1))) { - TestUtils.generateTestData(output3, (long) testFile1Size); + TestUtils.generateTestData(output3, testFile1Size); } if (!testFile2.getParentFile().exists()) { throw new IOException("Cannot create file " + testFile2 @@ -132,7 +132,7 @@ public class FileUtilsTestCase { } try (final BufferedOutputStream output2 = new BufferedOutputStream(new FileOutputStream(testFile2))) { - TestUtils.generateTestData(output2, (long) testFile2Size); + TestUtils.generateTestData(output2, testFile2Size); } FileUtils.deleteDirectory(getTestDirectory()); getTestDirectory().mkdirs(); @@ -142,7 +142,7 @@ public class FileUtilsTestCase { } try (final BufferedOutputStream output1 = new BufferedOutputStream(new FileOutputStream(testFile1))) { - TestUtils.generateTestData(output1, (long) testFile1Size); + TestUtils.generateTestData(output1, testFile1Size); } if (!testFile2.getParentFile().exists()) { throw new IOException("Cannot create file " + testFile2 @@ -150,7 +150,7 @@ public class FileUtilsTestCase { } try (final BufferedOutputStream output = new BufferedOutputStream(new FileOutputStream(testFile2))) { - TestUtils.generateTestData(output, (long) testFile2Size); + TestUtils.generateTestData(output, testFile2Size); } } @@ -1012,7 +1012,7 @@ public class FileUtilsTestCase { final BufferedOutputStream output1 = new BufferedOutputStream(new FileOutputStream(oldFile)); try { - TestUtils.generateTestData(output1, (long) 0); + TestUtils.generateTestData(output1, 0); } finally { IOUtils.closeQuietly(output1); } @@ -1030,7 +1030,7 @@ public class FileUtilsTestCase { final BufferedOutputStream output = new BufferedOutputStream(new FileOutputStream(reference)); try { - TestUtils.generateTestData(output, (long) 0); + TestUtils.generateTestData(output, 0); } finally { IOUtils.closeQuietly(output); } @@ -1052,7 +1052,7 @@ public class FileUtilsTestCase { final BufferedOutputStream output = new BufferedOutputStream(new FileOutputStream(newFile)); try { - TestUtils.generateTestData(output, (long) 0); + TestUtils.generateTestData(output, 0); } finally { IOUtils.closeQuietly(output); } @@ -1270,7 +1270,7 @@ public class FileUtilsTestCase { final BufferedOutputStream output1 = new BufferedOutputStream(new FileOutputStream(testFile1)); try { - TestUtils.generateTestData(output1, (long) 1234); + TestUtils.generateTestData(output1, 1234); } finally { IOUtils.closeQuietly(output1); } @@ -1281,7 +1281,7 @@ public class FileUtilsTestCase { final BufferedOutputStream output = new BufferedOutputStream(new FileOutputStream(testFile2)); try { - TestUtils.generateTestData(output, (long) 4321); + TestUtils.generateTestData(output, 4321); } finally { IOUtils.closeQuietly(output); } @@ -1314,7 +1314,7 @@ public class FileUtilsTestCase { final BufferedOutputStream output1 = new BufferedOutputStream(new FileOutputStream(testFile1)); try { - TestUtils.generateTestData(output1, (long) 1234); + TestUtils.generateTestData(output1, 1234); } finally { IOUtils.closeQuietly(output1); } @@ -1325,7 +1325,7 @@ public class FileUtilsTestCase { final BufferedOutputStream output = new BufferedOutputStream(new FileOutputStream(testFile2)); try { - TestUtils.generateTestData(output, (long) 4321); + TestUtils.generateTestData(output, 4321); } finally { IOUtils.closeQuietly(output); } @@ -1356,7 +1356,7 @@ public class FileUtilsTestCase { final BufferedOutputStream output1 = new BufferedOutputStream(new FileOutputStream(testFile1)); try { - TestUtils.generateTestData(output1, (long) 1234); + TestUtils.generateTestData(output1, 1234); } finally { IOUtils.closeQuietly(output1); } @@ -1367,7 +1367,7 @@ public class FileUtilsTestCase { final BufferedOutputStream output = new BufferedOutputStream(new FileOutputStream(testFile2)); try { - TestUtils.generateTestData(output, (long) 4321); + TestUtils.generateTestData(output, 4321); } finally { IOUtils.closeQuietly(output); } @@ -1820,7 +1820,7 @@ public class FileUtilsTestCase { final BufferedOutputStream output = new BufferedOutputStream(new FileOutputStream(theFile)); try { - TestUtils.generateTestData(output, (long) fileSizes[i]); + TestUtils.generateTestData(output, fileSizes[i]); } finally { IOUtils.closeQuietly(output); } @@ -1870,7 +1870,7 @@ public class FileUtilsTestCase { final BufferedOutputStream output = new BufferedOutputStream(new FileOutputStream(someFile)); try { - TestUtils.generateTestData(output, (long) 100); + TestUtils.generateTestData(output, 100); } finally { IOUtils.closeQuietly(output); } @@ -1908,7 +1908,7 @@ public class FileUtilsTestCase { final BufferedOutputStream output = new BufferedOutputStream(new FileOutputStream(theFile)); try { - TestUtils.generateTestData(output, (long) fileSizes[i]); + TestUtils.generateTestData(output, fileSizes[i]); } finally { IOUtils.closeQuietly(output); } @@ -1955,7 +1955,7 @@ public class FileUtilsTestCase { final BufferedOutputStream output = new BufferedOutputStream(new FileOutputStream(someFile)); try { - TestUtils.generateTestData(output, (long) 100); + TestUtils.generateTestData(output, 100); } finally { IOUtils.closeQuietly(output); } @@ -2552,7 +2552,7 @@ public class FileUtilsTestCase { final BufferedOutputStream output = new BufferedOutputStream(new FileOutputStream(testFile)); try { - TestUtils.generateTestData(output, (long) 0); + TestUtils.generateTestData(output, 0); } finally { IOUtils.closeQuietly(output); } @@ -2574,7 +2574,7 @@ public class FileUtilsTestCase { final BufferedOutputStream output = new BufferedOutputStream(new FileOutputStream(testFile)); try { - TestUtils.generateTestData(output, (long) 0); + TestUtils.generateTestData(output, 0); } finally { IOUtils.closeQuietly(output); } @@ -2688,7 +2688,7 @@ public class FileUtilsTestCase { final BufferedOutputStream output1 = new BufferedOutputStream(new FileOutputStream(testSourceFile)); try { - TestUtils.generateTestData(output1, (long) 0); + TestUtils.generateTestData(output1, 0); } finally { IOUtils.closeQuietly(output1); } @@ -2699,7 +2699,7 @@ public class FileUtilsTestCase { final BufferedOutputStream output = new BufferedOutputStream(new FileOutputStream(testDestFile)); try { - TestUtils.generateTestData(output, (long) 0); + TestUtils.generateTestData(output, 0); } finally { IOUtils.closeQuietly(output); } @@ -2746,7 +2746,7 @@ public class FileUtilsTestCase { final BufferedOutputStream output1 = new BufferedOutputStream(new FileOutputStream(testFile1)); try { - TestUtils.generateTestData(output1, (long) 0); + TestUtils.generateTestData(output1, 0); } finally { IOUtils.closeQuietly(output1); } @@ -2757,7 +2757,7 @@ public class FileUtilsTestCase { final BufferedOutputStream output = new BufferedOutputStream(new FileOutputStream(testFile2)); try { - TestUtils.generateTestData(output, (long) 0); + TestUtils.generateTestData(output, 0); } finally { IOUtils.closeQuietly(output); } @@ -2792,7 +2792,7 @@ public class FileUtilsTestCase { final BufferedOutputStream output = new BufferedOutputStream(new FileOutputStream(testFile)); try { - TestUtils.generateTestData(output, (long) 0); + TestUtils.generateTestData(output, 0); } finally { IOUtils.closeQuietly(output); } @@ -2834,7 +2834,7 @@ public class FileUtilsTestCase { final BufferedOutputStream output = new BufferedOutputStream(new FileOutputStream(testFile)); try { - TestUtils.generateTestData(output, (long) 0); + TestUtils.generateTestData(output, 0); } finally { IOUtils.closeQuietly(output); } @@ -2881,7 +2881,7 @@ public class FileUtilsTestCase { final BufferedOutputStream output = new BufferedOutputStream(new FileOutputStream(testFile)); try { - TestUtils.generateTestData(output, (long) 0); + TestUtils.generateTestData(output, 0); } finally { IOUtils.closeQuietly(output); } @@ -2917,7 +2917,7 @@ public class FileUtilsTestCase { final BufferedOutputStream output = new BufferedOutputStream(new FileOutputStream(testFile)); try { - TestUtils.generateTestData(output, (long) 0); + TestUtils.generateTestData(output, 0); } finally { IOUtils.closeQuietly(output); } @@ -2962,7 +2962,7 @@ public class FileUtilsTestCase { final BufferedOutputStream output1 = new BufferedOutputStream(new FileOutputStream(testFile1)); try { - TestUtils.generateTestData(output1, (long) 0); + TestUtils.generateTestData(output1, 0); } finally { IOUtils.closeQuietly(output1); } @@ -2973,7 +2973,7 @@ public class FileUtilsTestCase { final BufferedOutputStream output = new BufferedOutputStream(new FileOutputStream(testFile2)); try { - TestUtils.generateTestData(output, (long) 0); + TestUtils.generateTestData(output, 0); } finally { IOUtils.closeQuietly(output); } @@ -3006,7 +3006,7 @@ public class FileUtilsTestCase { final BufferedOutputStream output = new BufferedOutputStream(new FileOutputStream(testFile)); try { - TestUtils.generateTestData(output, (long) 0); + TestUtils.generateTestData(output, 0); } finally { IOUtils.closeQuietly(output); } http://git-wip-us.apache.org/repos/asf/commons-io/blob/fcca356d/src/test/java/org/apache/commons/io/FilenameUtilsTestCase.java ---------------------------------------------------------------------- diff --git a/src/test/java/org/apache/commons/io/FilenameUtilsTestCase.java b/src/test/java/org/apache/commons/io/FilenameUtilsTestCase.java index 50bfc38..dc69616 100644 --- a/src/test/java/org/apache/commons/io/FilenameUtilsTestCase.java +++ b/src/test/java/org/apache/commons/io/FilenameUtilsTestCase.java @@ -75,7 +75,7 @@ public class FilenameUtilsTestCase { } try (final BufferedOutputStream output3 = new BufferedOutputStream(new FileOutputStream(testFile1))) { - TestUtils.generateTestData(output3, (long) testFile1Size); + TestUtils.generateTestData(output3, testFile1Size); } if (!testFile2.getParentFile().exists()) { throw new IOException("Cannot create file " + testFile2 @@ -83,7 +83,7 @@ public class FilenameUtilsTestCase { } try (final BufferedOutputStream output2 = new BufferedOutputStream(new FileOutputStream(testFile2))) { - TestUtils.generateTestData(output2, (long) testFile2Size); + TestUtils.generateTestData(output2, testFile2Size); } if (!testFile1.getParentFile().exists()) { throw new IOException("Cannot create file " + testFile1 @@ -91,7 +91,7 @@ public class FilenameUtilsTestCase { } try (final BufferedOutputStream output1 = new BufferedOutputStream(new FileOutputStream(testFile1))) { - TestUtils.generateTestData(output1, (long) testFile1Size); + TestUtils.generateTestData(output1, testFile1Size); } if (!testFile2.getParentFile().exists()) { throw new IOException("Cannot create file " + testFile2 @@ -99,7 +99,7 @@ public class FilenameUtilsTestCase { } try (final BufferedOutputStream output = new BufferedOutputStream(new FileOutputStream(testFile2))) { - TestUtils.generateTestData(output, (long) testFile2Size); + TestUtils.generateTestData(output, testFile2Size); } } http://git-wip-us.apache.org/repos/asf/commons-io/blob/fcca356d/src/test/java/org/apache/commons/io/IOUtilsCopyTestCase.java ---------------------------------------------------------------------- diff --git a/src/test/java/org/apache/commons/io/IOUtilsCopyTestCase.java b/src/test/java/org/apache/commons/io/IOUtilsCopyTestCase.java index c6d08e8..ef836c7 100644 --- a/src/test/java/org/apache/commons/io/IOUtilsCopyTestCase.java +++ b/src/test/java/org/apache/commons/io/IOUtilsCopyTestCase.java @@ -65,7 +65,7 @@ public class IOUtilsCopyTestCase { private static final int FILE_SIZE = 1024 * 4 + 1; - private final byte[] inData = TestUtils.generateTestData((long) FILE_SIZE); + private final byte[] inData = TestUtils.generateTestData(FILE_SIZE); //----------------------------------------------------------------------- @SuppressWarnings("resource") // 'in' is deliberately not closed http://git-wip-us.apache.org/repos/asf/commons-io/blob/fcca356d/src/test/java/org/apache/commons/io/IOUtilsTestCase.java ---------------------------------------------------------------------- diff --git a/src/test/java/org/apache/commons/io/IOUtilsTestCase.java b/src/test/java/org/apache/commons/io/IOUtilsTestCase.java index e261f72..b359a8e 100644 --- a/src/test/java/org/apache/commons/io/IOUtilsTestCase.java +++ b/src/test/java/org/apache/commons/io/IOUtilsTestCase.java @@ -120,7 +120,7 @@ public class IOUtilsTestCase { final BufferedOutputStream output = new BufferedOutputStream(new FileOutputStream(m_testFile)); try { - TestUtils.generateTestData(output, (long) FILE_SIZE); + TestUtils.generateTestData(output, FILE_SIZE); } finally { IOUtils.closeQuietly(output); } http://git-wip-us.apache.org/repos/asf/commons-io/blob/fcca356d/src/test/java/org/apache/commons/io/IOUtilsWriteTestCase.java ---------------------------------------------------------------------- diff --git a/src/test/java/org/apache/commons/io/IOUtilsWriteTestCase.java b/src/test/java/org/apache/commons/io/IOUtilsWriteTestCase.java index 5f00a88..6675aae 100644 --- a/src/test/java/org/apache/commons/io/IOUtilsWriteTestCase.java +++ b/src/test/java/org/apache/commons/io/IOUtilsWriteTestCase.java @@ -51,7 +51,7 @@ public class IOUtilsWriteTestCase { private static final int FILE_SIZE = 1024 * 4 + 1; - private final byte[] inData = TestUtils.generateTestData((long) FILE_SIZE); + private final byte[] inData = TestUtils.generateTestData(FILE_SIZE); // ---------------------------------------------------------------- // Tests http://git-wip-us.apache.org/repos/asf/commons-io/blob/fcca356d/src/test/java/org/apache/commons/io/comparator/CompositeFileComparatorTest.java ---------------------------------------------------------------------- diff --git a/src/test/java/org/apache/commons/io/comparator/CompositeFileComparatorTest.java b/src/test/java/org/apache/commons/io/comparator/CompositeFileComparatorTest.java index 9d98791..6c543b9 100644 --- a/src/test/java/org/apache/commons/io/comparator/CompositeFileComparatorTest.java +++ b/src/test/java/org/apache/commons/io/comparator/CompositeFileComparatorTest.java @@ -55,7 +55,7 @@ public class CompositeFileComparatorTest extends ComparatorAbstractTestCase { try (final BufferedOutputStream output3 = new BufferedOutputStream(new FileOutputStream(lessFile))) { - TestUtils.generateTestData(output3, (long) 32); + TestUtils.generateTestData(output3, 32); } if (!equalFile1.getParentFile().exists()) { throw new IOException("Cannot create file " + equalFile1 @@ -63,7 +63,7 @@ public class CompositeFileComparatorTest extends ComparatorAbstractTestCase { } try (final BufferedOutputStream output2 = new BufferedOutputStream(new FileOutputStream(equalFile1))) { - TestUtils.generateTestData(output2, (long) 48); + TestUtils.generateTestData(output2, 48); } if (!equalFile2.getParentFile().exists()) { throw new IOException("Cannot create file " + equalFile2 @@ -71,7 +71,7 @@ public class CompositeFileComparatorTest extends ComparatorAbstractTestCase { } try (final BufferedOutputStream output1 = new BufferedOutputStream(new FileOutputStream(equalFile2))) { - TestUtils.generateTestData(output1, (long) 48); + TestUtils.generateTestData(output1, 48); } if (!moreFile.getParentFile().exists()) { throw new IOException("Cannot create file " + moreFile @@ -79,7 +79,7 @@ public class CompositeFileComparatorTest extends ComparatorAbstractTestCase { } try (final BufferedOutputStream output = new BufferedOutputStream(new FileOutputStream(moreFile))) { - TestUtils.generateTestData(output, (long) 48); + TestUtils.generateTestData(output, 48); } } http://git-wip-us.apache.org/repos/asf/commons-io/blob/fcca356d/src/test/java/org/apache/commons/io/comparator/LastModifiedFileComparatorTest.java ---------------------------------------------------------------------- diff --git a/src/test/java/org/apache/commons/io/comparator/LastModifiedFileComparatorTest.java b/src/test/java/org/apache/commons/io/comparator/LastModifiedFileComparatorTest.java index 0fa5750..887303a 100644 --- a/src/test/java/org/apache/commons/io/comparator/LastModifiedFileComparatorTest.java +++ b/src/test/java/org/apache/commons/io/comparator/LastModifiedFileComparatorTest.java @@ -41,7 +41,7 @@ public class LastModifiedFileComparatorTest extends ComparatorAbstractTestCase { } try (final BufferedOutputStream output2 = new BufferedOutputStream(new FileOutputStream(olderFile))) { - TestUtils.generateTestData(output2, (long) 0); + TestUtils.generateTestData(output2, 0); } final File equalFile = new File(dir, "equal.txt"); @@ -51,7 +51,7 @@ public class LastModifiedFileComparatorTest extends ComparatorAbstractTestCase { } try (final BufferedOutputStream output1 = new BufferedOutputStream(new FileOutputStream(equalFile))) { - TestUtils.generateTestData(output1, (long) 0); + TestUtils.generateTestData(output1, 0); } do { TestUtils.sleepQuietly(300); @@ -65,7 +65,7 @@ public class LastModifiedFileComparatorTest extends ComparatorAbstractTestCase { } try (final BufferedOutputStream output = new BufferedOutputStream(new FileOutputStream(newerFile))){ - TestUtils.generateTestData(output, (long) 0); + TestUtils.generateTestData(output, 0); } do { TestUtils.sleepQuietly(300); http://git-wip-us.apache.org/repos/asf/commons-io/blob/fcca356d/src/test/java/org/apache/commons/io/comparator/SizeFileComparatorTest.java ---------------------------------------------------------------------- diff --git a/src/test/java/org/apache/commons/io/comparator/SizeFileComparatorTest.java b/src/test/java/org/apache/commons/io/comparator/SizeFileComparatorTest.java index f698b02..5c3d61b 100644 --- a/src/test/java/org/apache/commons/io/comparator/SizeFileComparatorTest.java +++ b/src/test/java/org/apache/commons/io/comparator/SizeFileComparatorTest.java @@ -58,7 +58,7 @@ public class SizeFileComparatorTest extends ComparatorAbstractTestCase { } try (final BufferedOutputStream output2 = new BufferedOutputStream(new FileOutputStream(smallerFile))) { - TestUtils.generateTestData(output2, (long) 32); + TestUtils.generateTestData(output2, 32); } if (!equalFile.getParentFile().exists()) { throw new IOException("Cannot create file " + equalFile @@ -66,7 +66,7 @@ public class SizeFileComparatorTest extends ComparatorAbstractTestCase { } try (final BufferedOutputStream output1 = new BufferedOutputStream(new FileOutputStream(equalFile))) { - TestUtils.generateTestData(output1, (long) 48); + TestUtils.generateTestData(output1, 48); } if (!largerFile.getParentFile().exists()) { throw new IOException("Cannot create file " + largerFile @@ -74,7 +74,7 @@ public class SizeFileComparatorTest extends ComparatorAbstractTestCase { } try (final BufferedOutputStream output = new BufferedOutputStream(new FileOutputStream(largerFile))) { - TestUtils.generateTestData(output, (long) 64); + TestUtils.generateTestData(output, 64); } equalFile1 = equalFile; equalFile2 = equalFile; http://git-wip-us.apache.org/repos/asf/commons-io/blob/fcca356d/src/test/java/org/apache/commons/io/filefilter/FileFilterTestCase.java ---------------------------------------------------------------------- diff --git a/src/test/java/org/apache/commons/io/filefilter/FileFilterTestCase.java b/src/test/java/org/apache/commons/io/filefilter/FileFilterTestCase.java index 063fb6e..29aedd4 100644 --- a/src/test/java/org/apache/commons/io/filefilter/FileFilterTestCase.java +++ b/src/test/java/org/apache/commons/io/filefilter/FileFilterTestCase.java @@ -725,7 +725,7 @@ public class FileFilterTestCase { } try (final BufferedOutputStream output2 = new BufferedOutputStream(new FileOutputStream(file))) { - TestUtils.generateTestData(output2, (long) 0); + TestUtils.generateTestData(output2, 0); } assertFiltering(filter1, file, true); assertFiltering(filter2, file, true); @@ -737,7 +737,7 @@ public class FileFilterTestCase { } try (final BufferedOutputStream output1 = new BufferedOutputStream(new FileOutputStream(file))) { - TestUtils.generateTestData(output1, (long) 0); + TestUtils.generateTestData(output1, 0); } assertFiltering(filter1, file, true); assertFiltering(filter2, file, false); @@ -749,7 +749,7 @@ public class FileFilterTestCase { } try (final BufferedOutputStream output = new BufferedOutputStream(new FileOutputStream(file))) { - TestUtils.generateTestData(output, (long) 0); + TestUtils.generateTestData(output, 0); } assertFiltering(filter1, file, true); assertFiltering(filter2, file, false); @@ -774,7 +774,7 @@ public class FileFilterTestCase { } try (final BufferedOutputStream output2 = new BufferedOutputStream(new FileOutputStream(file))) { - TestUtils.generateTestData(output2, (long) 0); + TestUtils.generateTestData(output2, 0); } assertFiltering(filter1, file, true); assertFiltering(filter2, file, true); @@ -786,7 +786,7 @@ public class FileFilterTestCase { } try (final BufferedOutputStream output1 = new BufferedOutputStream(new FileOutputStream(file))) { - TestUtils.generateTestData(output1, (long) 0); + TestUtils.generateTestData(output1, 0); } assertFiltering(filter1, file, true); assertFiltering(filter2, file, false); @@ -798,7 +798,7 @@ public class FileFilterTestCase { } try (final BufferedOutputStream output = new BufferedOutputStream(new FileOutputStream(file))) { - TestUtils.generateTestData(output, (long) 0); + TestUtils.generateTestData(output, 0); } assertFiltering(filter1, file, true); assertFiltering(filter2, file, false); @@ -816,7 +816,7 @@ public class FileFilterTestCase { } try (final BufferedOutputStream output1 = new BufferedOutputStream(new FileOutputStream(oldFile))) { - TestUtils.generateTestData(output1, (long) 0); + TestUtils.generateTestData(output1, 0); } do { @@ -831,7 +831,7 @@ public class FileFilterTestCase { } try (final BufferedOutputStream output = new BufferedOutputStream(new FileOutputStream(reference))) { - TestUtils.generateTestData(output, (long) 0); + TestUtils.generateTestData(output, 0); } } while( oldFile.lastModified() == reference.lastModified() ); @@ -850,7 +850,7 @@ public class FileFilterTestCase { } try (final BufferedOutputStream output = new BufferedOutputStream(new FileOutputStream(newFile))) { - TestUtils.generateTestData(output, (long) 0); + TestUtils.generateTestData(output, 0); } } while( reference.lastModified() == newFile.lastModified() ); @@ -893,7 +893,7 @@ public class FileFilterTestCase { } try (final BufferedOutputStream output1 = new BufferedOutputStream(new FileOutputStream(smallFile))) { - TestUtils.generateTestData(output1, (long) 32); + TestUtils.generateTestData(output1, 32); } final File largeFile = new File(getTestDirectory(), "large.txt"); if (!largeFile.getParentFile().exists()) { @@ -902,7 +902,7 @@ public class FileFilterTestCase { } try (final BufferedOutputStream output = new BufferedOutputStream(new FileOutputStream(largeFile))){ - TestUtils.generateTestData(output, (long) 128); + TestUtils.generateTestData(output, 128); } final IOFileFilter filter1 = FileFilterUtils.sizeFileFilter(64); final IOFileFilter filter2 = FileFilterUtils.sizeFileFilter(64, true); @@ -960,7 +960,7 @@ public class FileFilterTestCase { } try (final BufferedOutputStream output = new BufferedOutputStream(new FileOutputStream(readOnlyFile))){ - TestUtils.generateTestData(output, (long) 32); + TestUtils.generateTestData(output, 32); } readOnlyFile.setReadOnly(); assertFiltering(CanReadFileFilter.CAN_READ, readOnlyFile, true); @@ -978,7 +978,7 @@ public class FileFilterTestCase { } try (final BufferedOutputStream output = new BufferedOutputStream(new FileOutputStream(readOnlyFile))){ - TestUtils.generateTestData(output, (long) 32); + TestUtils.generateTestData(output, 32); } readOnlyFile.setReadOnly(); assertFiltering(CanWriteFileFilter.CAN_WRITE, getTestDirectory(), true); @@ -1005,7 +1005,7 @@ public class FileFilterTestCase { } try (final BufferedOutputStream output1 = new BufferedOutputStream(new FileOutputStream(emptyFile))){ - TestUtils.generateTestData(output1, (long) 0); + TestUtils.generateTestData(output1, 0); } assertFiltering(EmptyFileFilter.EMPTY, emptyFile, true); assertFiltering(EmptyFileFilter.NOT_EMPTY, emptyFile, false); @@ -1022,7 +1022,7 @@ public class FileFilterTestCase { } try (final BufferedOutputStream output = new BufferedOutputStream(new FileOutputStream(notEmptyFile))){ - TestUtils.generateTestData(output, (long) 32); + TestUtils.generateTestData(output, 32); } assertFiltering(EmptyFileFilter.EMPTY, notEmptyFile, false); assertFiltering(EmptyFileFilter.NOT_EMPTY, notEmptyFile, true); @@ -1055,7 +1055,7 @@ public class FileFilterTestCase { } try (final BufferedOutputStream output1 = new BufferedOutputStream(new FileOutputStream(fileA))) { - TestUtils.generateTestData(output1, (long) 32); + TestUtils.generateTestData(output1, 32); } if (!fileB.getParentFile().exists()) { throw new IOException("Cannot create file " + fileB @@ -1063,7 +1063,7 @@ public class FileFilterTestCase { } try (final BufferedOutputStream output = new BufferedOutputStream(new FileOutputStream(fileB))) { - TestUtils.generateTestData(output, (long) 32); + TestUtils.generateTestData(output, 32); } assertFiltering(filter, fileA, false); @@ -1099,7 +1099,7 @@ public class FileFilterTestCase { } try (final BufferedOutputStream output1 = new BufferedOutputStream(new FileOutputStream(fileA))){ - TestUtils.generateTestData(output1, (long) 32); + TestUtils.generateTestData(output1, 32); } if (!fileB.getParentFile().exists()) { throw new IOException("Cannot create file " + fileB @@ -1107,7 +1107,7 @@ public class FileFilterTestCase { } try (final BufferedOutputStream output = new BufferedOutputStream(new FileOutputStream(fileB))){ - TestUtils.generateTestData(output, (long) 32); + TestUtils.generateTestData(output, 32); } assertFiltering(filter, fileA, false); @@ -1134,7 +1134,7 @@ public class FileFilterTestCase { final OutputStream classFileAStream = FileUtils.openOutputStream(classFileA); IOUtils.write(classFileMagicNumber, classFileAStream); - TestUtils.generateTestData(classFileAStream, (long) 32); + TestUtils.generateTestData(classFileAStream, 32); classFileAStream.close(); FileUtils.write(xmlFileB, xmlFileContent, StandardCharsets.UTF_8); @@ -1210,7 +1210,7 @@ public class FileFilterTestCase { final OutputStream classFileAStream = FileUtils.openOutputStream(classFileA); IOUtils.write(classFileMagicNumber, classFileAStream); - TestUtils.generateTestData(classFileAStream, (long) 32); + TestUtils.generateTestData(classFileAStream, 32); classFileAStream.close(); FileUtils.write(xmlFileB, xmlFileContent, StandardCharsets.UTF_8); http://git-wip-us.apache.org/repos/asf/commons-io/blob/fcca356d/src/test/java/org/apache/commons/io/output/AppendableOutputStreamTest.java ---------------------------------------------------------------------- diff --git a/src/test/java/org/apache/commons/io/output/AppendableOutputStreamTest.java b/src/test/java/org/apache/commons/io/output/AppendableOutputStreamTest.java index 0675ee4..6ea664f 100644 --- a/src/test/java/org/apache/commons/io/output/AppendableOutputStreamTest.java +++ b/src/test/java/org/apache/commons/io/output/AppendableOutputStreamTest.java @@ -45,7 +45,7 @@ public class AppendableOutputStreamTest { @Test public void testWriteInt() throws Exception { - out.write((int) 'F'); + out.write('F'); assertEquals("F", out.getAppendable().toString()); } http://git-wip-us.apache.org/repos/asf/commons-io/blob/fcca356d/src/test/java/org/apache/commons/io/output/ProxyWriterTest.java ---------------------------------------------------------------------- diff --git a/src/test/java/org/apache/commons/io/output/ProxyWriterTest.java b/src/test/java/org/apache/commons/io/output/ProxyWriterTest.java index c9e1c28..5f163f4 100644 --- a/src/test/java/org/apache/commons/io/output/ProxyWriterTest.java +++ b/src/test/java/org/apache/commons/io/output/ProxyWriterTest.java @@ -182,7 +182,7 @@ public class ProxyWriterTest { } }; try (ProxyWriter proxy = new ProxyWriter(osw)) { - proxy.write((int) 'a'); + proxy.write('a'); } }
