Remove magical number, using a local final variable (following current approach)
Project: http://git-wip-us.apache.org/repos/asf/commons-lang/repo Commit: http://git-wip-us.apache.org/repos/asf/commons-lang/commit/0344ca3f Tree: http://git-wip-us.apache.org/repos/asf/commons-lang/tree/0344ca3f Diff: http://git-wip-us.apache.org/repos/asf/commons-lang/diff/0344ca3f Branch: refs/heads/release Commit: 0344ca3f2d43e3732bf16370262303be8761a523 Parents: 65b08c4 Author: Bruno P. Kinoshita <ki...@apache.org> Authored: Wed Jun 7 18:50:19 2017 +1200 Committer: Bruno P. Kinoshita <ki...@apache.org> Committed: Wed Jun 7 18:50:19 2017 +1200 ---------------------------------------------------------------------- .../org/apache/commons/lang3/builder/ToStringBuilderTest.java | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/commons-lang/blob/0344ca3f/src/test/java/org/apache/commons/lang3/builder/ToStringBuilderTest.java ---------------------------------------------------------------------- diff --git a/src/test/java/org/apache/commons/lang3/builder/ToStringBuilderTest.java b/src/test/java/org/apache/commons/lang3/builder/ToStringBuilderTest.java index f0c5af7..c49426d 100644 --- a/src/test/java/org/apache/commons/lang3/builder/ToStringBuilderTest.java +++ b/src/test/java/org/apache/commons/lang3/builder/ToStringBuilderTest.java @@ -36,6 +36,7 @@ import org.junit.Test; */ public class ToStringBuilderTest { + private final Integer arraylistInitialCapacity = Integer.valueOf(10); private final Integer base = Integer.valueOf(5); private final String baseStr = base.getClass().getName() + "@" + Integer.toHexString(System.identityHashCode(base)); @@ -316,7 +317,7 @@ public class ToStringBuilderTest { // representation different for IBM JDK 1.6.0, LANG-727 assumeFalse("IBM Corporation".equals(SystemUtils.JAVA_VENDOR) && "1.6".equals(SystemUtils.JAVA_SPECIFICATION_VERSION)); assumeFalse("Oracle Corporation".equals(SystemUtils.JAVA_VENDOR) && "1.6".compareTo(SystemUtils.JAVA_SPECIFICATION_VERSION) < 0); - final List<Object> list = new ArrayList<>(10); + final List<Object> list = new ArrayList<>(arraylistInitialCapacity); final String baseString = this.toBaseString(list); final String expectedWithTransients = baseString + "[elementData={<null>,<null>,<null>,<null>,<null>,<null>,<null>,<null>,<null>,<null>},size=0,modCount=0]"; final String toStringWithTransients = ToStringBuilder.reflectionToString(list, null, true);
