Repository: commons-lang Updated Branches: refs/heads/master ce1bd5785 -> 30c85ad05
Use StringBuilders instead of StringBuffers (A couple of instances were overlooked) This fixes #236 Project: http://git-wip-us.apache.org/repos/asf/commons-lang/repo Commit: http://git-wip-us.apache.org/repos/asf/commons-lang/commit/30c85ad0 Tree: http://git-wip-us.apache.org/repos/asf/commons-lang/tree/30c85ad0 Diff: http://git-wip-us.apache.org/repos/asf/commons-lang/diff/30c85ad0 Branch: refs/heads/master Commit: 30c85ad05363767deeefee577063c2c432b971d4 Parents: ce1bd57 Author: Sebb <s...@apache.org> Authored: Thu Feb 16 18:59:01 2017 +0000 Committer: Sebb <s...@apache.org> Committed: Thu Feb 16 18:59:01 2017 +0000 ---------------------------------------------------------------------- src/main/java/org/apache/commons/lang3/RandomStringUtils.java | 6 +++--- src/test/java/org/apache/commons/lang3/ArrayUtilsTest.java | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/commons-lang/blob/30c85ad0/src/main/java/org/apache/commons/lang3/RandomStringUtils.java ---------------------------------------------------------------------- diff --git a/src/main/java/org/apache/commons/lang3/RandomStringUtils.java b/src/main/java/org/apache/commons/lang3/RandomStringUtils.java index 549bea2..ec62d50 100644 --- a/src/main/java/org/apache/commons/lang3/RandomStringUtils.java +++ b/src/main/java/org/apache/commons/lang3/RandomStringUtils.java @@ -380,7 +380,7 @@ public class RandomStringUtils { } } - StringBuffer buffer = new StringBuffer(count); + StringBuilder builder = new StringBuilder(count); final int gap = end - start; while (count-- != 0) { @@ -409,7 +409,7 @@ public class RandomStringUtils { if (letters && Character.isLetter(codePoint) || numbers && Character.isDigit(codePoint) || !letters && !numbers) { - buffer.appendCodePoint(codePoint); + builder.appendCodePoint(codePoint); if (numberOfChars == 2) { count--; @@ -419,7 +419,7 @@ public class RandomStringUtils { count++; } } - return buffer.toString(); + return builder.toString(); } http://git-wip-us.apache.org/repos/asf/commons-lang/blob/30c85ad0/src/test/java/org/apache/commons/lang3/ArrayUtilsTest.java ---------------------------------------------------------------------- diff --git a/src/test/java/org/apache/commons/lang3/ArrayUtilsTest.java b/src/test/java/org/apache/commons/lang3/ArrayUtilsTest.java index 657a85e..63da4e4 100644 --- a/src/test/java/org/apache/commons/lang3/ArrayUtilsTest.java +++ b/src/test/java/org/apache/commons/lang3/ArrayUtilsTest.java @@ -280,8 +280,8 @@ public class ArrayUtilsTest { assertTrue(Arrays.equals(original1, cloned1)); assertTrue(original1 != cloned1); - final StringBuffer buf = new StringBuffer("pick"); - original1 = new Object[] {buf, "a", new String[] {"stick"}}; + final StringBuilder builder = new StringBuilder("pick"); + original1 = new Object[] {builder, "a", new String[] {"stick"}}; cloned1 = ArrayUtils.clone(original1); assertTrue(Arrays.equals(original1, cloned1)); assertTrue(original1 != cloned1);
