Author: britter
Date: Tue Feb 14 07:24:11 2017
New Revision: 1782919
URL: http://svn.apache.org/viewvc?rev=1782919&view=rev
Log:
VALIDATOR-418: UrlValidatorTest: testIsValid() does not run all tests. Thanks
to Robert McGuigan.
Modified:
commons/proper/validator/trunk/RELEASE-NOTES.txt
commons/proper/validator/trunk/src/changes/changes.xml
commons/proper/validator/trunk/src/test/java/org/apache/commons/validator/routines/UrlValidatorTest.java
Modified: commons/proper/validator/trunk/RELEASE-NOTES.txt
URL:
http://svn.apache.org/viewvc/commons/proper/validator/trunk/RELEASE-NOTES.txt?rev=1782919&r1=1782918&r2=1782919&view=diff
==============================================================================
--- commons/proper/validator/trunk/RELEASE-NOTES.txt (original)
+++ commons/proper/validator/trunk/RELEASE-NOTES.txt Tue Feb 14 07:24:11 2017
@@ -38,6 +38,7 @@ o VALIDATOR-405: IBANValidator - Costa
o VALIDATOR-401: IBANValidator fails for Seychelles and Ukraine
o VALIDATOR-391: UrlValidator.isValid throws exception for FILEURLs
Fixed code so it handles URLs with no authority field Thanks
to Mark E. Scott, Jr. & Jason Loomis.
+o VALIDATOR-418: UrlValidatorTest: testIsValid() does not run all tests.
Thanks to Robert McGuigan
Changes:
o IANA TLD lists: Updated to Version 2017020400, Last Updated
Sat Feb 4 07:07:01 2017 UTC
Modified: commons/proper/validator/trunk/src/changes/changes.xml
URL:
http://svn.apache.org/viewvc/commons/proper/validator/trunk/src/changes/changes.xml?rev=1782919&r1=1782918&r2=1782919&view=diff
==============================================================================
--- commons/proper/validator/trunk/src/changes/changes.xml (original)
+++ commons/proper/validator/trunk/src/changes/changes.xml Tue Feb 14 07:24:11
2017
@@ -98,6 +98,9 @@ The dependencies for Validator have not
For the current list of dependencies, please see
http://commons.apache.org/validator/dependencies.html
">
+ <action issue="VALIDATOR-418" type="fix" dev="britter" due-to="Robert
McGuigan">
+ UrlValidatorTest: testIsValid() does not run all tests
+ </action>
<action issue="VALIDATOR-415" type="add" dev="sebb">
Simplify building new CreditCard validators
</action>
Modified:
commons/proper/validator/trunk/src/test/java/org/apache/commons/validator/routines/UrlValidatorTest.java
URL:
http://svn.apache.org/viewvc/commons/proper/validator/trunk/src/test/java/org/apache/commons/validator/routines/UrlValidatorTest.java?rev=1782919&r1=1782918&r2=1782919&view=diff
==============================================================================
---
commons/proper/validator/trunk/src/test/java/org/apache/commons/validator/routines/UrlValidatorTest.java
(original)
+++
commons/proper/validator/trunk/src/test/java/org/apache/commons/validator/routines/UrlValidatorTest.java
Tue Feb 14 07:24:11 2017
@@ -337,6 +337,7 @@ protected void setUp() {
for (int testPartsIndexIndex = testPartsIndex.length - 1;
testPartsIndexIndex >= 0; --testPartsIndexIndex) {
int index = testPartsIndex[testPartsIndexIndex];
ResultPair[] part = (ResultPair[]) testParts[testPartsIndexIndex];
+ maxIndex &= (index == (part.length - 1));
if (carry) {
if (index < part.length - 1) {
index++;
@@ -347,7 +348,6 @@ protected void setUp() {
carry = true;
}
}
- maxIndex &= (index == (part.length - 1));
}
@@ -507,8 +507,7 @@ protected void setUp() {
new ResultPair("http:/", false),
new ResultPair("http:", false),
new ResultPair("http/", false),
- new ResultPair("://", false),
- new ResultPair("", true)};
+ new ResultPair("://", false)};
ResultPair[] testUrlAuthority = {new ResultPair("www.google.com", true),
new ResultPair("www.google.com.", true),
