Repository: commons-lang Updated Branches: refs/heads/master 795fe5d86 -> 5556118ad
Squashed deprecation warnings in test code. Project: http://git-wip-us.apache.org/repos/asf/commons-lang/repo Commit: http://git-wip-us.apache.org/repos/asf/commons-lang/commit/5556118a Tree: http://git-wip-us.apache.org/repos/asf/commons-lang/tree/5556118a Diff: http://git-wip-us.apache.org/repos/asf/commons-lang/diff/5556118a Branch: refs/heads/master Commit: 5556118ad13fbb80a56d7b8de6f960e9ff8255b8 Parents: 795fe5d Author: duncan <dun...@wortharead.com> Authored: Mon Dec 12 15:11:39 2016 +0000 Committer: duncan <dun...@wortharead.com> Committed: Mon Dec 12 15:11:39 2016 +0000 ---------------------------------------------------------------------- .../org/apache/commons/lang3/ArrayUtilsAddTest.java | 3 ++- .../java/org/apache/commons/lang3/ArrayUtilsTest.java | 12 ++++++++++++ 2 files changed, 14 insertions(+), 1 deletion(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/commons-lang/blob/5556118a/src/test/java/org/apache/commons/lang3/ArrayUtilsAddTest.java ---------------------------------------------------------------------- diff --git a/src/test/java/org/apache/commons/lang3/ArrayUtilsAddTest.java b/src/test/java/org/apache/commons/lang3/ArrayUtilsAddTest.java index 212f978..b3ce1ab 100644 --- a/src/test/java/org/apache/commons/lang3/ArrayUtilsAddTest.java +++ b/src/test/java/org/apache/commons/lang3/ArrayUtilsAddTest.java @@ -238,7 +238,7 @@ public class ArrayUtilsAddTest { //expected } try { - @SuppressWarnings("unused") + @SuppressWarnings({ "unused", "deprecation" }) final String[] sa = ArrayUtils.add(stringArray, 0, aString); fail("Should have caused IllegalArgumentException"); @@ -365,6 +365,7 @@ public class ArrayUtilsAddTest { } + @SuppressWarnings("deprecation") @Test public void testAddObjectAtIndex() { Object[] newArray; http://git-wip-us.apache.org/repos/asf/commons-lang/blob/5556118a/src/test/java/org/apache/commons/lang3/ArrayUtilsTest.java ---------------------------------------------------------------------- diff --git a/src/test/java/org/apache/commons/lang3/ArrayUtilsTest.java b/src/test/java/org/apache/commons/lang3/ArrayUtilsTest.java index 0990b17..3f70d43 100644 --- a/src/test/java/org/apache/commons/lang3/ArrayUtilsTest.java +++ b/src/test/java/org/apache/commons/lang3/ArrayUtilsTest.java @@ -42,6 +42,18 @@ import org.junit.Test; @SuppressWarnings("deprecation") // deliberate use of deprecated code public class ArrayUtilsTest { + + static <T> T[] arrayOfTwo(T a, T b) { + return ArrayUtils.toArray(a, b); + } + + @Test + public void testBadVarArgs() throws Exception { + @SuppressWarnings("unused") // Need to assign to trigger exception + String[] result = arrayOfTwo("foo", "bar"); + } + + //----------------------------------------------------------------------- @Test public void testConstructor() {