Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/ClassGen.java URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/ClassGen.java?rev=1746378&r1=1746377&r2=1746378&view=diff ============================================================================== --- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/ClassGen.java (original) +++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/ClassGen.java Wed Jun 1 04:25:27 2016 @@ -63,7 +63,7 @@ public class ClassGen extends AccessFlag private static BCELComparator _cmp = new BCELComparator() { @Override - public boolean equals( Object o1, Object o2 ) { + public boolean equals( final Object o1, final Object o2 ) { ClassGen THIS = (ClassGen) o1; ClassGen THAT = (ClassGen) o2; return THIS.getClassName().equals(THAT.getClassName()); @@ -71,7 +71,7 @@ public class ClassGen extends AccessFlag @Override - public int hashCode( Object o ) { + public int hashCode( final Object o ) { ClassGen THIS = (ClassGen) o; return THIS.getClassName().hashCode(); } @@ -87,8 +87,8 @@ public class ClassGen extends AccessFlag * @param interfaces implemented interfaces * @param cp constant pool to use */ - public ClassGen(String class_name, String super_class_name, String file_name, int access_flags, - String[] interfaces, ConstantPoolGen cp) { + public ClassGen(final String class_name, final String super_class_name, final String file_name, final int access_flags, + final String[] interfaces, final ConstantPoolGen cp) { super(access_flags); this.class_name = class_name; this.super_class_name = super_class_name; @@ -117,8 +117,8 @@ public class ClassGen extends AccessFlag * @param access_flags access qualifiers * @param interfaces implemented interfaces */ - public ClassGen(String class_name, String super_class_name, String file_name, int access_flags, - String[] interfaces) { + public ClassGen(final String class_name, final String super_class_name, final String file_name, final int access_flags, + final String[] interfaces) { this(class_name, super_class_name, file_name, access_flags, interfaces, new ConstantPoolGen()); } @@ -128,7 +128,7 @@ public class ClassGen extends AccessFlag * Initialize with existing class. * @param clazz JavaClass object (e.g. read from file) */ - public ClassGen(JavaClass clazz) { + public ClassGen(final JavaClass clazz) { super(clazz.getAccessFlags()); class_name_index = clazz.getClassNameIndex(); superclass_name_index = clazz.getSuperclassNameIndex(); @@ -166,7 +166,7 @@ public class ClassGen extends AccessFlag /** * Look for attributes representing annotations and unpack them. */ - private AnnotationEntryGen[] unpackAnnotations(Attribute[] attrs) + private AnnotationEntryGen[] unpackAnnotations(final Attribute[] attrs) { List<AnnotationEntryGen> annotationGenObjs = new ArrayList<>(); for (Attribute attr : attrs) { @@ -222,7 +222,7 @@ public class ClassGen extends AccessFlag * Add an interface to this class, i.e., this class has to implement it. * @param name interface to implement (fully qualified class name) */ - public void addInterface( String name ) { + public void addInterface( final String name ) { interface_vec.add(name); } @@ -231,7 +231,7 @@ public class ClassGen extends AccessFlag * Remove an interface from this class. * @param name interface to remove (fully qualified name) */ - public void removeInterface( String name ) { + public void removeInterface( final String name ) { interface_vec.remove(name); } @@ -247,7 +247,7 @@ public class ClassGen extends AccessFlag /** Set major version number of class file, default value is 45 (JDK 1.1) * @param major major version number */ - public void setMajor( int major ) { // TODO could be package-protected - only called by test code + public void setMajor( final int major ) { // TODO could be package-protected - only called by test code this.major = major; } @@ -255,7 +255,7 @@ public class ClassGen extends AccessFlag /** Set minor version number of class file, default value is 3 (JDK 1.1) * @param minor minor version number */ - public void setMinor( int minor ) { // TODO could be package-protected - only called by test code + public void setMinor( final int minor ) { // TODO could be package-protected - only called by test code this.minor = minor; } @@ -271,11 +271,11 @@ public class ClassGen extends AccessFlag * Add an attribute to this class. * @param a attribute to add */ - public void addAttribute( Attribute a ) { + public void addAttribute( final Attribute a ) { attribute_vec.add(a); } - public void addAnnotationEntry(AnnotationEntryGen a) { + public void addAnnotationEntry(final AnnotationEntryGen a) { annotation_vec.add(a); } @@ -284,7 +284,7 @@ public class ClassGen extends AccessFlag * Add a method to this class. * @param m method to add */ - public void addMethod( Method m ) { + public void addMethod( final Method m ) { method_vec.add(m); } @@ -295,7 +295,7 @@ public class ClassGen extends AccessFlag * Add an empty constructor to this class that does nothing but calling super(). * @param access_flags rights for constructor */ - public void addEmptyConstructor( int access_flags ) { + public void addEmptyConstructor( final int access_flags ) { InstructionList il = new InstructionList(); il.append(InstructionConst.THIS); // Push `this' il.append(new INVOKESPECIAL(cp.addMethodref(super_class_name, "<init>", "()V"))); @@ -311,19 +311,19 @@ public class ClassGen extends AccessFlag * Add a field to this class. * @param f field to add */ - public void addField( Field f ) { + public void addField( final Field f ) { field_vec.add(f); } - public boolean containsField( Field f ) { + public boolean containsField( final Field f ) { return field_vec.contains(f); } /** @return field object with given name, or null */ - public Field containsField( String name ) { + public Field containsField( final String name ) { for (Field f : field_vec) { if (f.getName().equals(name)) { return f; @@ -335,7 +335,7 @@ public class ClassGen extends AccessFlag /** @return method object with given name and signature, or null */ - public Method containsMethod( String name, String signature ) { + public Method containsMethod( final String name, final String signature ) { for (Method m : method_vec) { if (m.getName().equals(name) && m.getSignature().equals(signature)) { return m; @@ -349,7 +349,7 @@ public class ClassGen extends AccessFlag * Remove an attribute from this class. * @param a attribute to remove */ - public void removeAttribute( Attribute a ) { + public void removeAttribute( final Attribute a ) { attribute_vec.remove(a); } @@ -358,7 +358,7 @@ public class ClassGen extends AccessFlag * Remove a method from this class. * @param m method to remove */ - public void removeMethod( Method m ) { + public void removeMethod( final Method m ) { method_vec.remove(m); } @@ -366,7 +366,7 @@ public class ClassGen extends AccessFlag /** Replace given method with new one. If the old one does not exist * add the new_ method to the class anyway. */ - public void replaceMethod( Method old, Method new_ ) { + public void replaceMethod( final Method old, final Method new_ ) { if (new_ == null) { throw new ClassGenException("Replacement method must not be null"); } @@ -382,7 +382,7 @@ public class ClassGen extends AccessFlag /** Replace given field with new one. If the old one does not exist * add the new_ field to the class anyway. */ - public void replaceField( Field old, Field new_ ) { + public void replaceField( final Field old, final Field new_ ) { if (new_ == null) { throw new ClassGenException("Replacement method must not be null"); } @@ -399,7 +399,7 @@ public class ClassGen extends AccessFlag * Remove a field to this class. * @param f field to remove */ - public void removeField( Field f ) { + public void removeField( final Field f ) { field_vec.remove(f); } @@ -419,13 +419,13 @@ public class ClassGen extends AccessFlag } - public void setClassName( String name ) { + public void setClassName( final String name ) { class_name = name.replace('/', '.'); class_name_index = cp.addClass(name); } - public void setSuperclassName( String name ) { + public void setSuperclassName( final String name ) { super_class_name = name.replace('/', '.'); superclass_name_index = cp.addClass(name); } @@ -436,7 +436,7 @@ public class ClassGen extends AccessFlag } - public void setMethods( Method[] methods ) { + public void setMethods( final Method[] methods ) { method_vec.clear(); for (Method method : methods) { addMethod(method); @@ -444,12 +444,12 @@ public class ClassGen extends AccessFlag } - public void setMethodAt( Method method, int pos ) { + public void setMethodAt( final Method method, final int pos ) { method_vec.set(pos, method); } - public Method getMethodAt( int pos ) { + public Method getMethodAt( final int pos ) { return method_vec.get(pos); } @@ -492,19 +492,19 @@ public class ClassGen extends AccessFlag } - public void setConstantPool( ConstantPoolGen constant_pool ) { + public void setConstantPool( final ConstantPoolGen constant_pool ) { cp = constant_pool; } - public void setClassNameIndex( int class_name_index ) { + public void setClassNameIndex( final int class_name_index ) { this.class_name_index = class_name_index; class_name = cp.getConstantPool().getConstantString(class_name_index, Const.CONSTANT_Class).replace('/', '.'); } - public void setSuperclassNameIndex( int superclass_name_index ) { + public void setSuperclassNameIndex( final int superclass_name_index ) { this.superclass_name_index = superclass_name_index; super_class_name = cp.getConstantPool().getConstantString(superclass_name_index, Const.CONSTANT_Class).replace('/', '.'); @@ -525,7 +525,7 @@ public class ClassGen extends AccessFlag /** Add observer for this object. */ - public void addObserver( ClassObserver o ) { + public void addObserver( final ClassObserver o ) { if (observers == null) { observers = new ArrayList<>(); } @@ -535,7 +535,7 @@ public class ClassGen extends AccessFlag /** Remove observer for this object. */ - public void removeObserver( ClassObserver o ) { + public void removeObserver( final ClassObserver o ) { if (observers != null) { observers.remove(o); } @@ -576,7 +576,7 @@ public class ClassGen extends AccessFlag /** * @param comparator Comparison strategy object */ - public static void setComparator( BCELComparator comparator ) { + public static void setComparator( final BCELComparator comparator ) { _cmp = comparator; } @@ -589,7 +589,7 @@ public class ClassGen extends AccessFlag * @see java.lang.Object#equals(java.lang.Object) */ @Override - public boolean equals( Object obj ) { + public boolean equals( final Object obj ) { return _cmp.equals(this, obj); }
Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/ClassGenException.java URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/ClassGenException.java?rev=1746378&r1=1746377&r2=1746378&view=diff ============================================================================== --- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/ClassGenException.java (original) +++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/ClassGenException.java Wed Jun 1 04:25:27 2016 @@ -32,11 +32,11 @@ public class ClassGenException extends R } - public ClassGenException(String s) { + public ClassGenException(final String s) { super(s); } - public ClassGenException(String s, Throwable initCause) { + public ClassGenException(final String s, final Throwable initCause) { super(s, initCause); } } Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/CodeExceptionGen.java URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/CodeExceptionGen.java?rev=1746378&r1=1746377&r2=1746378&view=diff ============================================================================== --- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/CodeExceptionGen.java (original) +++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/CodeExceptionGen.java Wed Jun 1 04:25:27 2016 @@ -50,8 +50,8 @@ public final class CodeExceptionGen impl * @param handler_pc Where handling is done * @param catch_type which exception is handled, null for ANY */ - public CodeExceptionGen(InstructionHandle start_pc, InstructionHandle end_pc, - InstructionHandle handler_pc, ObjectType catch_type) { + public CodeExceptionGen(final InstructionHandle start_pc, final InstructionHandle end_pc, + final InstructionHandle handler_pc, final ObjectType catch_type) { setStartPC(start_pc); setEndPC(end_pc); setHandlerPC(handler_pc); @@ -68,7 +68,7 @@ public final class CodeExceptionGen impl * * @param cp constant pool */ - public CodeException getCodeException( ConstantPoolGen cp ) { + public CodeException getCodeException( final ConstantPoolGen cp ) { return new CodeException(start_pc.getPosition(), end_pc.getPosition() + end_pc.getInstruction().getLength(), handler_pc.getPosition(), (catch_type == null) ? 0 : cp.addClass(catch_type)); @@ -78,7 +78,7 @@ public final class CodeExceptionGen impl /* Set start of handler * @param start_pc Start of handled region (inclusive) */ - public void setStartPC( InstructionHandle start_pc ) { // TODO could be package-protected? + public void setStartPC( final InstructionHandle start_pc ) { // TODO could be package-protected? BranchInstruction.notifyTarget(this.start_pc, start_pc, this); this.start_pc = start_pc; } @@ -87,7 +87,7 @@ public final class CodeExceptionGen impl /* Set end of handler * @param end_pc End of handled region (inclusive) */ - public void setEndPC( InstructionHandle end_pc ) { // TODO could be package-protected? + public void setEndPC( final InstructionHandle end_pc ) { // TODO could be package-protected? BranchInstruction.notifyTarget(this.end_pc, end_pc, this); this.end_pc = end_pc; } @@ -96,7 +96,7 @@ public final class CodeExceptionGen impl /* Set handler code * @param handler_pc Start of handler */ - public void setHandlerPC( InstructionHandle handler_pc ) { // TODO could be package-protected? + public void setHandlerPC( final InstructionHandle handler_pc ) { // TODO could be package-protected? BranchInstruction.notifyTarget(this.handler_pc, handler_pc, this); this.handler_pc = handler_pc; } @@ -107,7 +107,7 @@ public final class CodeExceptionGen impl * @param new_ih new target */ @Override - public void updateTarget( InstructionHandle old_ih, InstructionHandle new_ih ) { + public void updateTarget( final InstructionHandle old_ih, final InstructionHandle new_ih ) { boolean targeted = false; if (start_pc == old_ih) { targeted = true; @@ -132,13 +132,13 @@ public final class CodeExceptionGen impl * @return true, if ih is target of this handler */ @Override - public boolean containsTarget( InstructionHandle ih ) { + public boolean containsTarget( final InstructionHandle ih ) { return (start_pc == ih) || (end_pc == ih) || (handler_pc == ih); } /** Sets the type of the Exception to catch. Set 'null' for ANY. */ - public void setCatchType( ObjectType catch_type ) { + public void setCatchType( final ObjectType catch_type ) { this.catch_type = catch_type; } Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/ConstantPoolGen.java URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/ConstantPoolGen.java?rev=1746378&r1=1746377&r2=1746378&view=diff ============================================================================== --- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/ConstantPoolGen.java (original) +++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/ConstantPoolGen.java Wed Jun 1 04:25:27 2016 @@ -82,7 +82,7 @@ public class ConstantPoolGen { final int index; - Index(int i) { + Index(final int i) { index = i; } } @@ -93,7 +93,7 @@ public class ConstantPoolGen { * * @param cs array of given constants, new ones will be appended */ - public ConstantPoolGen(Constant[] cs) { + public ConstantPoolGen(final Constant[] cs) { StringBuilder sb = new StringBuilder(DEFAULT_BUFFER_SIZE); size = Math.max(DEFAULT_BUFFER_SIZE, cs.length + 64); @@ -204,7 +204,7 @@ public class ConstantPoolGen { /** * Initialize with given constant pool. */ - public ConstantPoolGen(ConstantPool cp) { + public ConstantPoolGen(final ConstantPool cp) { this(cp.getConstantPool()); } @@ -238,7 +238,7 @@ public class ConstantPoolGen { * @param str String to search for * @return index on success, -1 otherwise */ - public int lookupString( String str ) { + public int lookupString( final String str ) { Index index = string_table.get(str); return (index != null) ? index.index : -1; } @@ -250,7 +250,7 @@ public class ConstantPoolGen { * @param str String to add * @return index of entry */ - public int addString( String str ) { + public int addString( final String str ) { int ret; if ((ret = lookupString(str)) != -1) { return ret; // Already in CP @@ -275,13 +275,13 @@ public class ConstantPoolGen { * @param str String to search for * @return index on success, -1 otherwise */ - public int lookupClass( String str ) { + public int lookupClass( final String str ) { Index index = class_table.get(str.replace('.', '/')); return (index != null) ? index.index : -1; } - private int addClass_( String clazz ) { + private int addClass_( final String clazz ) { int ret; if ((ret = lookupClass(clazz)) != -1) { return ret; // Already in CP @@ -303,7 +303,7 @@ public class ConstantPoolGen { * @param str Class to add * @return index of entry */ - public int addClass( String str ) { + public int addClass( final String str ) { return addClass_(str.replace('.', '/')); } @@ -314,7 +314,7 @@ public class ConstantPoolGen { * @param type Class to add * @return index of entry */ - public int addClass( ObjectType type ) { + public int addClass( final ObjectType type ) { return addClass(type.getClassName()); } @@ -326,7 +326,7 @@ public class ConstantPoolGen { * @param type type of array class * @return index of entry */ - public int addArrayClass( ArrayType type ) { + public int addArrayClass( final ArrayType type ) { return addClass_(type.getSignature()); } @@ -337,7 +337,7 @@ public class ConstantPoolGen { * @param n integer number to look for * @return index on success, -1 otherwise */ - public int lookupInteger( int n ) { + public int lookupInteger( final int n ) { for (int i = 1; i < index; i++) { if (constants[i] instanceof ConstantInteger) { ConstantInteger c = (ConstantInteger) constants[i]; @@ -356,7 +356,7 @@ public class ConstantPoolGen { * @param n integer number to add * @return index of entry */ - public int addInteger( int n ) { + public int addInteger( final int n ) { int ret; if ((ret = lookupInteger(n)) != -1) { return ret; // Already in CP @@ -374,7 +374,7 @@ public class ConstantPoolGen { * @param n Float number to look for * @return index on success, -1 otherwise */ - public int lookupFloat( float n ) { + public int lookupFloat( final float n ) { int bits = Float.floatToIntBits(n); for (int i = 1; i < index; i++) { if (constants[i] instanceof ConstantFloat) { @@ -394,7 +394,7 @@ public class ConstantPoolGen { * @param n Float number to add * @return index of entry */ - public int addFloat( float n ) { + public int addFloat( final float n ) { int ret; if ((ret = lookupFloat(n)) != -1) { return ret; // Already in CP @@ -414,7 +414,7 @@ public class ConstantPoolGen { * @param n Utf8 string to look for * @return index on success, -1 otherwise */ - public int lookupUtf8( String n ) { + public int lookupUtf8( final String n ) { Index index = utf8_table.get(n); return (index != null) ? index.index : -1; } @@ -426,7 +426,7 @@ public class ConstantPoolGen { * @param n Utf8 string to add * @return index of entry */ - public int addUtf8( String n ) { + public int addUtf8( final String n ) { int ret; if ((ret = lookupUtf8(n)) != -1) { return ret; // Already in CP @@ -447,7 +447,7 @@ public class ConstantPoolGen { * @param n Long number to look for * @return index on success, -1 otherwise */ - public int lookupLong( long n ) { + public int lookupLong( final long n ) { for (int i = 1; i < index; i++) { if (constants[i] instanceof ConstantLong) { ConstantLong c = (ConstantLong) constants[i]; @@ -466,7 +466,7 @@ public class ConstantPoolGen { * @param n Long number to add * @return index of entry */ - public int addLong( long n ) { + public int addLong( final long n ) { int ret; if ((ret = lookupLong(n)) != -1) { return ret; // Already in CP @@ -485,7 +485,7 @@ public class ConstantPoolGen { * @param n Double number to look for * @return index on success, -1 otherwise */ - public int lookupDouble( double n ) { + public int lookupDouble( final double n ) { long bits = Double.doubleToLongBits(n); for (int i = 1; i < index; i++) { if (constants[i] instanceof ConstantDouble) { @@ -505,7 +505,7 @@ public class ConstantPoolGen { * @param n Double number to add * @return index of entry */ - public int addDouble( double n ) { + public int addDouble( final double n ) { int ret; if ((ret = lookupDouble(n)) != -1) { return ret; // Already in CP @@ -527,7 +527,7 @@ public class ConstantPoolGen { * @param signature of variable/method * @return index on success, -1 otherwise */ - public int lookupNameAndType( String name, String signature ) { + public int lookupNameAndType( final String name, final String signature ) { Index _index = n_a_t_table.get(name + NAT_DELIM + signature); return (_index != null) ? _index.index : -1; } @@ -541,7 +541,7 @@ public class ConstantPoolGen { * @param signature signature string to add * @return index of entry */ - public int addNameAndType( String name, String signature ) { + public int addNameAndType( final String name, final String signature ) { int ret; int name_index; int signature_index; @@ -571,14 +571,14 @@ public class ConstantPoolGen { * @param signature return and argument types * @return index on success, -1 otherwise */ - public int lookupMethodref( String class_name, String method_name, String signature ) { + public int lookupMethodref( final String class_name, final String method_name, final String signature ) { Index index = cp_table.get(class_name + METHODREF_DELIM + method_name + METHODREF_DELIM + signature); return (index != null) ? index.index : -1; } - public int lookupMethodref( MethodGen method ) { + public int lookupMethodref( final MethodGen method ) { return lookupMethodref(method.getClassName(), method.getName(), method.getSignature()); } @@ -592,7 +592,7 @@ public class ConstantPoolGen { * @param signature method signature string to add * @return index of entry */ - public int addMethodref( String class_name, String method_name, String signature ) { + public int addMethodref( final String class_name, final String method_name, final String signature ) { int ret; int class_index; int name_and_type_index; @@ -612,7 +612,7 @@ public class ConstantPoolGen { } - public int addMethodref( MethodGen method ) { + public int addMethodref( final MethodGen method ) { return addMethodref(method.getClassName(), method.getName(), method.getSignature()); } @@ -625,14 +625,14 @@ public class ConstantPoolGen { * @param signature return and argument types * @return index on success, -1 otherwise */ - public int lookupInterfaceMethodref( String class_name, String method_name, String signature ) { + public int lookupInterfaceMethodref( final String class_name, final String method_name, final String signature ) { Index index = cp_table.get(class_name + IMETHODREF_DELIM + method_name + IMETHODREF_DELIM + signature); return (index != null) ? index.index : -1; } - public int lookupInterfaceMethodref( MethodGen method ) { + public int lookupInterfaceMethodref( final MethodGen method ) { return lookupInterfaceMethodref(method.getClassName(), method.getName(), method .getSignature()); } @@ -647,7 +647,7 @@ public class ConstantPoolGen { * @param signature signature string to add * @return index of entry */ - public int addInterfaceMethodref( String class_name, String method_name, String signature ) { + public int addInterfaceMethodref( final String class_name, final String method_name, final String signature ) { int ret; int class_index; int name_and_type_index; @@ -667,7 +667,7 @@ public class ConstantPoolGen { } - public int addInterfaceMethodref( MethodGen method ) { + public int addInterfaceMethodref( final MethodGen method ) { return addInterfaceMethodref(method.getClassName(), method.getName(), method.getSignature()); } @@ -680,7 +680,7 @@ public class ConstantPoolGen { * @param signature return and argument types * @return index on success, -1 otherwise */ - public int lookupFieldref( String class_name, String field_name, String signature ) { + public int lookupFieldref( final String class_name, final String field_name, final String signature ) { Index index = cp_table.get(class_name + FIELDREF_DELIM + field_name + FIELDREF_DELIM + signature); return (index != null) ? index.index : -1; @@ -696,7 +696,7 @@ public class ConstantPoolGen { * @param signature signature string to add * @return index of entry */ - public int addFieldref( String class_name, String field_name, String signature ) { + public int addFieldref( final String class_name, final String field_name, final String signature ) { int ret; int class_index; int name_and_type_index; @@ -720,7 +720,7 @@ public class ConstantPoolGen { * @param i index in constant pool * @return constant pool entry at index i */ - public Constant getConstant( int i ) { + public Constant getConstant( final int i ) { return constants[i]; } @@ -731,7 +731,7 @@ public class ConstantPoolGen { * @param i index in constant pool * @param c new constant pool entry at index i */ - public void setConstant( int i, Constant c ) { + public void setConstant( final int i, final Constant c ) { constants[i] = c; } @@ -777,7 +777,7 @@ public class ConstantPoolGen { /** Import constant from another ConstantPool and return new index. */ - public int addConstant( Constant c, ConstantPoolGen cp ) { + public int addConstant( final Constant c, final ConstantPoolGen cp ) { Constant[] constants = cp.getConstantPool().getConstantPool(); switch (c.getTag()) { case Const.CONSTANT_String: { Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/ConversionInstruction.java URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/ConversionInstruction.java?rev=1746378&r1=1746377&r2=1746378&view=diff ============================================================================== --- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/ConversionInstruction.java (original) +++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/ConversionInstruction.java Wed Jun 1 04:25:27 2016 @@ -38,7 +38,7 @@ public abstract class ConversionInstruct /** * @param opcode opcode of instruction */ - protected ConversionInstruction(short opcode) { + protected ConversionInstruction(final short opcode) { super(opcode, (short) 1); } @@ -46,7 +46,7 @@ public abstract class ConversionInstruct /** @return type associated with the instruction */ @Override - public Type getType( ConstantPoolGen cp ) { + public Type getType( final ConstantPoolGen cp ) { final short _opcode = super.getOpcode(); switch (_opcode) { case Const.D2I: Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/D2F.java URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/D2F.java?rev=1746378&r1=1746377&r2=1746378&view=diff ============================================================================== --- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/D2F.java (original) +++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/D2F.java Wed Jun 1 04:25:27 2016 @@ -41,7 +41,7 @@ public class D2F extends ConversionInstr * @param v Visitor object */ @Override - public void accept( Visitor v ) { + public void accept( final Visitor v ) { v.visitTypedInstruction(this); v.visitStackProducer(this); v.visitStackConsumer(this); Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/D2I.java URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/D2I.java?rev=1746378&r1=1746377&r2=1746378&view=diff ============================================================================== --- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/D2I.java (original) +++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/D2I.java Wed Jun 1 04:25:27 2016 @@ -41,7 +41,7 @@ public class D2I extends ConversionInstr * @param v Visitor object */ @Override - public void accept( Visitor v ) { + public void accept( final Visitor v ) { v.visitTypedInstruction(this); v.visitStackProducer(this); v.visitStackConsumer(this); Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/D2L.java URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/D2L.java?rev=1746378&r1=1746377&r2=1746378&view=diff ============================================================================== --- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/D2L.java (original) +++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/D2L.java Wed Jun 1 04:25:27 2016 @@ -41,7 +41,7 @@ public class D2L extends ConversionInstr * @param v Visitor object */ @Override - public void accept( Visitor v ) { + public void accept( final Visitor v ) { v.visitTypedInstruction(this); v.visitStackProducer(this); v.visitStackConsumer(this); Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/DADD.java URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/DADD.java?rev=1746378&r1=1746377&r2=1746378&view=diff ============================================================================== --- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/DADD.java (original) +++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/DADD.java Wed Jun 1 04:25:27 2016 @@ -42,7 +42,7 @@ public class DADD extends ArithmeticInst * @param v Visitor object */ @Override - public void accept( Visitor v ) { + public void accept( final Visitor v ) { v.visitTypedInstruction(this); v.visitStackProducer(this); v.visitStackConsumer(this); Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/DALOAD.java URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/DALOAD.java?rev=1746378&r1=1746377&r2=1746378&view=diff ============================================================================== --- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/DALOAD.java (original) +++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/DALOAD.java Wed Jun 1 04:25:27 2016 @@ -41,7 +41,7 @@ public class DALOAD extends ArrayInstruc * @param v Visitor object */ @Override - public void accept( Visitor v ) { + public void accept( final Visitor v ) { v.visitStackProducer(this); v.visitExceptionThrower(this); v.visitTypedInstruction(this); Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/DASTORE.java URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/DASTORE.java?rev=1746378&r1=1746377&r2=1746378&view=diff ============================================================================== --- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/DASTORE.java (original) +++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/DASTORE.java Wed Jun 1 04:25:27 2016 @@ -41,7 +41,7 @@ public class DASTORE extends ArrayInstru * @param v Visitor object */ @Override - public void accept( Visitor v ) { + public void accept( final Visitor v ) { v.visitStackConsumer(this); v.visitExceptionThrower(this); v.visitTypedInstruction(this); Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/DCMPG.java URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/DCMPG.java?rev=1746378&r1=1746377&r2=1746378&view=diff ============================================================================== --- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/DCMPG.java (original) +++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/DCMPG.java Wed Jun 1 04:25:27 2016 @@ -32,7 +32,7 @@ public class DCMPG extends Instruction i /** @return Type.DOUBLE */ @Override - public Type getType( ConstantPoolGen cp ) { + public Type getType( final ConstantPoolGen cp ) { return Type.DOUBLE; } @@ -45,7 +45,7 @@ public class DCMPG extends Instruction i * @param v Visitor object */ @Override - public void accept( Visitor v ) { + public void accept( final Visitor v ) { v.visitTypedInstruction(this); v.visitStackProducer(this); v.visitStackConsumer(this); Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/DCMPL.java URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/DCMPL.java?rev=1746378&r1=1746377&r2=1746378&view=diff ============================================================================== --- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/DCMPL.java (original) +++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/DCMPL.java Wed Jun 1 04:25:27 2016 @@ -32,7 +32,7 @@ public class DCMPL extends Instruction i /** @return Type.DOUBLE */ @Override - public Type getType( ConstantPoolGen cp ) { + public Type getType( final ConstantPoolGen cp ) { return Type.DOUBLE; } @@ -45,7 +45,7 @@ public class DCMPL extends Instruction i * @param v Visitor object */ @Override - public void accept( Visitor v ) { + public void accept( final Visitor v ) { v.visitTypedInstruction(this); v.visitStackProducer(this); v.visitStackConsumer(this); Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/DCONST.java URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/DCONST.java?rev=1746378&r1=1746377&r2=1746378&view=diff ============================================================================== --- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/DCONST.java (original) +++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/DCONST.java Wed Jun 1 04:25:27 2016 @@ -37,7 +37,7 @@ public class DCONST extends Instruction } - public DCONST(double f) { + public DCONST(final double f) { super(org.apache.commons.bcel6.Const.DCONST_0, (short) 1); if (f == 0.0) { super.setOpcode(org.apache.commons.bcel6.Const.DCONST_0); @@ -59,7 +59,7 @@ public class DCONST extends Instruction /** @return Type.DOUBLE */ @Override - public Type getType( ConstantPoolGen cp ) { + public Type getType( final ConstantPoolGen cp ) { return Type.DOUBLE; } @@ -73,7 +73,7 @@ public class DCONST extends Instruction * @param v Visitor object */ @Override - public void accept( Visitor v ) { + public void accept( final Visitor v ) { v.visitPushInstruction(this); v.visitStackProducer(this); v.visitTypedInstruction(this); Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/DDIV.java URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/DDIV.java?rev=1746378&r1=1746377&r2=1746378&view=diff ============================================================================== --- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/DDIV.java (original) +++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/DDIV.java Wed Jun 1 04:25:27 2016 @@ -42,7 +42,7 @@ public class DDIV extends ArithmeticInst * @param v Visitor object */ @Override - public void accept( Visitor v ) { + public void accept( final Visitor v ) { v.visitTypedInstruction(this); v.visitStackProducer(this); v.visitStackConsumer(this); Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/DLOAD.java URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/DLOAD.java?rev=1746378&r1=1746377&r2=1746378&view=diff ============================================================================== --- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/DLOAD.java (original) +++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/DLOAD.java Wed Jun 1 04:25:27 2016 @@ -37,7 +37,7 @@ public class DLOAD extends LoadInstructi /** Load double from local variable * @param n index of local variable */ - public DLOAD(int n) { + public DLOAD(final int n) { super(org.apache.commons.bcel6.Const.DLOAD, org.apache.commons.bcel6.Const.DLOAD_0, n); } @@ -51,7 +51,7 @@ public class DLOAD extends LoadInstructi * @param v Visitor object */ @Override - public void accept( Visitor v ) { + public void accept( final Visitor v ) { super.accept(v); v.visitDLOAD(this); } Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/DMUL.java URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/DMUL.java?rev=1746378&r1=1746377&r2=1746378&view=diff ============================================================================== --- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/DMUL.java (original) +++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/DMUL.java Wed Jun 1 04:25:27 2016 @@ -42,7 +42,7 @@ public class DMUL extends ArithmeticInst * @param v Visitor object */ @Override - public void accept( Visitor v ) { + public void accept( final Visitor v ) { v.visitTypedInstruction(this); v.visitStackProducer(this); v.visitStackConsumer(this); Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/DNEG.java URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/DNEG.java?rev=1746378&r1=1746377&r2=1746378&view=diff ============================================================================== --- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/DNEG.java (original) +++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/DNEG.java Wed Jun 1 04:25:27 2016 @@ -39,7 +39,7 @@ public class DNEG extends ArithmeticInst * @param v Visitor object */ @Override - public void accept( Visitor v ) { + public void accept( final Visitor v ) { v.visitTypedInstruction(this); v.visitStackProducer(this); v.visitStackConsumer(this); Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/DREM.java URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/DREM.java?rev=1746378&r1=1746377&r2=1746378&view=diff ============================================================================== --- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/DREM.java (original) +++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/DREM.java Wed Jun 1 04:25:27 2016 @@ -42,7 +42,7 @@ public class DREM extends ArithmeticInst * @param v Visitor object */ @Override - public void accept( Visitor v ) { + public void accept( final Visitor v ) { v.visitTypedInstruction(this); v.visitStackProducer(this); v.visitStackConsumer(this); Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/DRETURN.java URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/DRETURN.java?rev=1746378&r1=1746377&r2=1746378&view=diff ============================================================================== --- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/DRETURN.java (original) +++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/DRETURN.java Wed Jun 1 04:25:27 2016 @@ -41,7 +41,7 @@ public class DRETURN extends ReturnInstr * @param v Visitor object */ @Override - public void accept( Visitor v ) { + public void accept( final Visitor v ) { v.visitExceptionThrower(this); v.visitTypedInstruction(this); v.visitStackConsumer(this); Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/DSTORE.java URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/DSTORE.java?rev=1746378&r1=1746377&r2=1746378&view=diff ============================================================================== --- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/DSTORE.java (original) +++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/DSTORE.java Wed Jun 1 04:25:27 2016 @@ -37,7 +37,7 @@ public class DSTORE extends StoreInstruc /** Store double into local variable * @param n index of local variable */ - public DSTORE(int n) { + public DSTORE(final int n) { super(org.apache.commons.bcel6.Const.DSTORE, org.apache.commons.bcel6.Const.DSTORE_0, n); } @@ -51,7 +51,7 @@ public class DSTORE extends StoreInstruc * @param v Visitor object */ @Override - public void accept( Visitor v ) { + public void accept( final Visitor v ) { super.accept(v); v.visitDSTORE(this); } Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/DSUB.java URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/DSUB.java?rev=1746378&r1=1746377&r2=1746378&view=diff ============================================================================== --- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/DSUB.java (original) +++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/DSUB.java Wed Jun 1 04:25:27 2016 @@ -42,7 +42,7 @@ public class DSUB extends ArithmeticInst * @param v Visitor object */ @Override - public void accept( Visitor v ) { + public void accept( final Visitor v ) { v.visitTypedInstruction(this); v.visitStackProducer(this); v.visitStackConsumer(this); Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/DUP.java URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/DUP.java?rev=1746378&r1=1746377&r2=1746378&view=diff ============================================================================== --- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/DUP.java (original) +++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/DUP.java Wed Jun 1 04:25:27 2016 @@ -39,7 +39,7 @@ public class DUP extends StackInstructio * @param v Visitor object */ @Override - public void accept( Visitor v ) { + public void accept( final Visitor v ) { v.visitStackProducer(this); v.visitPushInstruction(this); v.visitStackInstruction(this); Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/DUP2.java URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/DUP2.java?rev=1746378&r1=1746377&r2=1746378&view=diff ============================================================================== --- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/DUP2.java (original) +++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/DUP2.java Wed Jun 1 04:25:27 2016 @@ -39,7 +39,7 @@ public class DUP2 extends StackInstructi * @param v Visitor object */ @Override - public void accept( Visitor v ) { + public void accept( final Visitor v ) { v.visitStackProducer(this); v.visitPushInstruction(this); v.visitStackInstruction(this); Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/DUP2_X1.java URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/DUP2_X1.java?rev=1746378&r1=1746377&r2=1746378&view=diff ============================================================================== --- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/DUP2_X1.java (original) +++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/DUP2_X1.java Wed Jun 1 04:25:27 2016 @@ -39,7 +39,7 @@ public class DUP2_X1 extends StackInstru * @param v Visitor object */ @Override - public void accept( Visitor v ) { + public void accept( final Visitor v ) { v.visitStackInstruction(this); v.visitDUP2_X1(this); } Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/DUP2_X2.java URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/DUP2_X2.java?rev=1746378&r1=1746377&r2=1746378&view=diff ============================================================================== --- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/DUP2_X2.java (original) +++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/DUP2_X2.java Wed Jun 1 04:25:27 2016 @@ -39,7 +39,7 @@ public class DUP2_X2 extends StackInstru * @param v Visitor object */ @Override - public void accept( Visitor v ) { + public void accept( final Visitor v ) { v.visitStackInstruction(this); v.visitDUP2_X2(this); } Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/DUP_X1.java URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/DUP_X1.java?rev=1746378&r1=1746377&r2=1746378&view=diff ============================================================================== --- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/DUP_X1.java (original) +++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/DUP_X1.java Wed Jun 1 04:25:27 2016 @@ -39,7 +39,7 @@ public class DUP_X1 extends StackInstruc * @param v Visitor object */ @Override - public void accept( Visitor v ) { + public void accept( final Visitor v ) { v.visitStackInstruction(this); v.visitDUP_X1(this); } Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/DUP_X2.java URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/DUP_X2.java?rev=1746378&r1=1746377&r2=1746378&view=diff ============================================================================== --- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/DUP_X2.java (original) +++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/DUP_X2.java Wed Jun 1 04:25:27 2016 @@ -39,7 +39,7 @@ public class DUP_X2 extends StackInstruc * @param v Visitor object */ @Override - public void accept( Visitor v ) { + public void accept( final Visitor v ) { v.visitStackInstruction(this); v.visitDUP_X2(this); } Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/ElementValueGen.java URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/ElementValueGen.java?rev=1746378&r1=1746377&r2=1746378&view=diff ============================================================================== --- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/ElementValueGen.java (original) +++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/ElementValueGen.java Wed Jun 1 04:25:27 2016 @@ -46,7 +46,7 @@ public abstract class ElementValueGen @Deprecated protected ConstantPoolGen cpGen; - protected ElementValueGen(int type, ConstantPoolGen cpGen) + protected ElementValueGen(final int type, final ConstantPoolGen cpGen) { this.type = type; this.cpGen = cpGen; @@ -92,8 +92,8 @@ public abstract class ElementValueGen public static final int PRIMITIVE_BOOLEAN = 'Z'; - public static ElementValueGen readElementValue(DataInput dis, - ConstantPoolGen cpGen) throws IOException + public static ElementValueGen readElementValue(final DataInput dis, + final ConstantPoolGen cpGen) throws IOException { int type = dis.readUnsignedByte(); switch (type) @@ -159,8 +159,8 @@ public abstract class ElementValueGen * Creates an (modifiable) ElementValueGen copy of an (immutable) * ElementValue - constant pool is assumed correct. */ - public static ElementValueGen copy(ElementValue value, - ConstantPoolGen cpool, boolean copyPoolEntries) + public static ElementValueGen copy(final ElementValue value, + final ConstantPoolGen cpool, final boolean copyPoolEntries) { switch (value.getElementValueType()) { Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/ElementValuePairGen.java URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/ElementValuePairGen.java?rev=1746378&r1=1746377&r2=1746378&view=diff ============================================================================== --- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/ElementValuePairGen.java (original) +++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/ElementValuePairGen.java Wed Jun 1 04:25:27 2016 @@ -35,8 +35,8 @@ public class ElementValuePairGen private final ConstantPoolGen cpool; - public ElementValuePairGen(ElementValuePair nvp, ConstantPoolGen cpool, - boolean copyPoolEntries) + public ElementValuePairGen(final ElementValuePair nvp, final ConstantPoolGen cpool, + final boolean copyPoolEntries) { this.cpool = cpool; // J5ASSERT: @@ -68,23 +68,23 @@ public class ElementValuePairGen .getConstantPool()); } - protected ElementValuePairGen(int idx, ElementValueGen value, - ConstantPoolGen cpool) + protected ElementValuePairGen(final int idx, final ElementValueGen value, + final ConstantPoolGen cpool) { this.nameIdx = idx; this.value = value; this.cpool = cpool; } - public ElementValuePairGen(String name, ElementValueGen value, - ConstantPoolGen cpool) + public ElementValuePairGen(final String name, final ElementValueGen value, + final ConstantPoolGen cpool) { this.nameIdx = cpool.addUtf8(name); this.value = value; this.cpool = cpool; } - protected void dump(DataOutputStream dos) throws IOException + protected void dump(final DataOutputStream dos) throws IOException { dos.writeShort(nameIdx); // u2 name of the element value.dump(dos); Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/EmptyVisitor.java URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/EmptyVisitor.java?rev=1746378&r1=1746377&r2=1746378&view=diff ============================================================================== --- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/EmptyVisitor.java (original) +++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/EmptyVisitor.java Wed Jun 1 04:25:27 2016 @@ -25,908 +25,908 @@ package org.apache.commons.bcel6.generic public abstract class EmptyVisitor implements Visitor { @Override - public void visitStackInstruction( StackInstruction obj ) { + public void visitStackInstruction( final StackInstruction obj ) { } @Override - public void visitLocalVariableInstruction( LocalVariableInstruction obj ) { + public void visitLocalVariableInstruction( final LocalVariableInstruction obj ) { } @Override - public void visitBranchInstruction( BranchInstruction obj ) { + public void visitBranchInstruction( final BranchInstruction obj ) { } @Override - public void visitLoadClass( LoadClass obj ) { + public void visitLoadClass( final LoadClass obj ) { } @Override - public void visitFieldInstruction( FieldInstruction obj ) { + public void visitFieldInstruction( final FieldInstruction obj ) { } @Override - public void visitIfInstruction( IfInstruction obj ) { + public void visitIfInstruction( final IfInstruction obj ) { } @Override - public void visitConversionInstruction( ConversionInstruction obj ) { + public void visitConversionInstruction( final ConversionInstruction obj ) { } @Override - public void visitPopInstruction( PopInstruction obj ) { + public void visitPopInstruction( final PopInstruction obj ) { } @Override - public void visitJsrInstruction( JsrInstruction obj ) { + public void visitJsrInstruction( final JsrInstruction obj ) { } @Override - public void visitGotoInstruction( GotoInstruction obj ) { + public void visitGotoInstruction( final GotoInstruction obj ) { } @Override - public void visitStoreInstruction( StoreInstruction obj ) { + public void visitStoreInstruction( final StoreInstruction obj ) { } @Override - public void visitTypedInstruction( TypedInstruction obj ) { + public void visitTypedInstruction( final TypedInstruction obj ) { } @Override - public void visitSelect( Select obj ) { + public void visitSelect( final Select obj ) { } @Override - public void visitUnconditionalBranch( UnconditionalBranch obj ) { + public void visitUnconditionalBranch( final UnconditionalBranch obj ) { } @Override - public void visitPushInstruction( PushInstruction obj ) { + public void visitPushInstruction( final PushInstruction obj ) { } @Override - public void visitArithmeticInstruction( ArithmeticInstruction obj ) { + public void visitArithmeticInstruction( final ArithmeticInstruction obj ) { } @Override - public void visitCPInstruction( CPInstruction obj ) { + public void visitCPInstruction( final CPInstruction obj ) { } @Override - public void visitInvokeInstruction( InvokeInstruction obj ) { + public void visitInvokeInstruction( final InvokeInstruction obj ) { } @Override - public void visitArrayInstruction( ArrayInstruction obj ) { + public void visitArrayInstruction( final ArrayInstruction obj ) { } @Override - public void visitAllocationInstruction( AllocationInstruction obj ) { + public void visitAllocationInstruction( final AllocationInstruction obj ) { } @Override - public void visitReturnInstruction( ReturnInstruction obj ) { + public void visitReturnInstruction( final ReturnInstruction obj ) { } @Override - public void visitFieldOrMethod( FieldOrMethod obj ) { + public void visitFieldOrMethod( final FieldOrMethod obj ) { } @Override - public void visitConstantPushInstruction( ConstantPushInstruction obj ) { + public void visitConstantPushInstruction( final ConstantPushInstruction obj ) { } @Override - public void visitExceptionThrower( ExceptionThrower obj ) { + public void visitExceptionThrower( final ExceptionThrower obj ) { } @Override - public void visitLoadInstruction( LoadInstruction obj ) { + public void visitLoadInstruction( final LoadInstruction obj ) { } @Override - public void visitVariableLengthInstruction( VariableLengthInstruction obj ) { + public void visitVariableLengthInstruction( final VariableLengthInstruction obj ) { } @Override - public void visitStackProducer( StackProducer obj ) { + public void visitStackProducer( final StackProducer obj ) { } @Override - public void visitStackConsumer( StackConsumer obj ) { + public void visitStackConsumer( final StackConsumer obj ) { } @Override - public void visitACONST_NULL( ACONST_NULL obj ) { + public void visitACONST_NULL( final ACONST_NULL obj ) { } @Override - public void visitGETSTATIC( GETSTATIC obj ) { + public void visitGETSTATIC( final GETSTATIC obj ) { } @Override - public void visitIF_ICMPLT( IF_ICMPLT obj ) { + public void visitIF_ICMPLT( final IF_ICMPLT obj ) { } @Override - public void visitMONITOREXIT( MONITOREXIT obj ) { + public void visitMONITOREXIT( final MONITOREXIT obj ) { } @Override - public void visitIFLT( IFLT obj ) { + public void visitIFLT( final IFLT obj ) { } @Override - public void visitLSTORE( LSTORE obj ) { + public void visitLSTORE( final LSTORE obj ) { } @Override - public void visitPOP2( POP2 obj ) { + public void visitPOP2( final POP2 obj ) { } @Override - public void visitBASTORE( BASTORE obj ) { + public void visitBASTORE( final BASTORE obj ) { } @Override - public void visitISTORE( ISTORE obj ) { + public void visitISTORE( final ISTORE obj ) { } @Override - public void visitCHECKCAST( CHECKCAST obj ) { + public void visitCHECKCAST( final CHECKCAST obj ) { } @Override - public void visitFCMPG( FCMPG obj ) { + public void visitFCMPG( final FCMPG obj ) { } @Override - public void visitI2F( I2F obj ) { + public void visitI2F( final I2F obj ) { } @Override - public void visitATHROW( ATHROW obj ) { + public void visitATHROW( final ATHROW obj ) { } @Override - public void visitDCMPL( DCMPL obj ) { + public void visitDCMPL( final DCMPL obj ) { } @Override - public void visitARRAYLENGTH( ARRAYLENGTH obj ) { + public void visitARRAYLENGTH( final ARRAYLENGTH obj ) { } @Override - public void visitDUP( DUP obj ) { + public void visitDUP( final DUP obj ) { } @Override - public void visitINVOKESTATIC( INVOKESTATIC obj ) { + public void visitINVOKESTATIC( final INVOKESTATIC obj ) { } @Override - public void visitLCONST( LCONST obj ) { + public void visitLCONST( final LCONST obj ) { } @Override - public void visitDREM( DREM obj ) { + public void visitDREM( final DREM obj ) { } @Override - public void visitIFGE( IFGE obj ) { + public void visitIFGE( final IFGE obj ) { } @Override - public void visitCALOAD( CALOAD obj ) { + public void visitCALOAD( final CALOAD obj ) { } @Override - public void visitLASTORE( LASTORE obj ) { + public void visitLASTORE( final LASTORE obj ) { } @Override - public void visitI2D( I2D obj ) { + public void visitI2D( final I2D obj ) { } @Override - public void visitDADD( DADD obj ) { + public void visitDADD( final DADD obj ) { } @Override - public void visitINVOKESPECIAL( INVOKESPECIAL obj ) { + public void visitINVOKESPECIAL( final INVOKESPECIAL obj ) { } @Override - public void visitIAND( IAND obj ) { + public void visitIAND( final IAND obj ) { } @Override - public void visitPUTFIELD( PUTFIELD obj ) { + public void visitPUTFIELD( final PUTFIELD obj ) { } @Override - public void visitILOAD( ILOAD obj ) { + public void visitILOAD( final ILOAD obj ) { } @Override - public void visitDLOAD( DLOAD obj ) { + public void visitDLOAD( final DLOAD obj ) { } @Override - public void visitDCONST( DCONST obj ) { + public void visitDCONST( final DCONST obj ) { } @Override - public void visitNEW( NEW obj ) { + public void visitNEW( final NEW obj ) { } @Override - public void visitIFNULL( IFNULL obj ) { + public void visitIFNULL( final IFNULL obj ) { } @Override - public void visitLSUB( LSUB obj ) { + public void visitLSUB( final LSUB obj ) { } @Override - public void visitL2I( L2I obj ) { + public void visitL2I( final L2I obj ) { } @Override - public void visitISHR( ISHR obj ) { + public void visitISHR( final ISHR obj ) { } @Override - public void visitTABLESWITCH( TABLESWITCH obj ) { + public void visitTABLESWITCH( final TABLESWITCH obj ) { } @Override - public void visitIINC( IINC obj ) { + public void visitIINC( final IINC obj ) { } @Override - public void visitDRETURN( DRETURN obj ) { + public void visitDRETURN( final DRETURN obj ) { } @Override - public void visitFSTORE( FSTORE obj ) { + public void visitFSTORE( final FSTORE obj ) { } @Override - public void visitDASTORE( DASTORE obj ) { + public void visitDASTORE( final DASTORE obj ) { } @Override - public void visitIALOAD( IALOAD obj ) { + public void visitIALOAD( final IALOAD obj ) { } @Override - public void visitDDIV( DDIV obj ) { + public void visitDDIV( final DDIV obj ) { } @Override - public void visitIF_ICMPGE( IF_ICMPGE obj ) { + public void visitIF_ICMPGE( final IF_ICMPGE obj ) { } @Override - public void visitLAND( LAND obj ) { + public void visitLAND( final LAND obj ) { } @Override - public void visitIDIV( IDIV obj ) { + public void visitIDIV( final IDIV obj ) { } @Override - public void visitLOR( LOR obj ) { + public void visitLOR( final LOR obj ) { } @Override - public void visitCASTORE( CASTORE obj ) { + public void visitCASTORE( final CASTORE obj ) { } @Override - public void visitFREM( FREM obj ) { + public void visitFREM( final FREM obj ) { } @Override - public void visitLDC( LDC obj ) { + public void visitLDC( final LDC obj ) { } @Override - public void visitBIPUSH( BIPUSH obj ) { + public void visitBIPUSH( final BIPUSH obj ) { } @Override - public void visitDSTORE( DSTORE obj ) { + public void visitDSTORE( final DSTORE obj ) { } @Override - public void visitF2L( F2L obj ) { + public void visitF2L( final F2L obj ) { } @Override - public void visitFMUL( FMUL obj ) { + public void visitFMUL( final FMUL obj ) { } @Override - public void visitLLOAD( LLOAD obj ) { + public void visitLLOAD( final LLOAD obj ) { } @Override - public void visitJSR( JSR obj ) { + public void visitJSR( final JSR obj ) { } @Override - public void visitFSUB( FSUB obj ) { + public void visitFSUB( final FSUB obj ) { } @Override - public void visitSASTORE( SASTORE obj ) { + public void visitSASTORE( final SASTORE obj ) { } @Override - public void visitALOAD( ALOAD obj ) { + public void visitALOAD( final ALOAD obj ) { } @Override - public void visitDUP2_X2( DUP2_X2 obj ) { + public void visitDUP2_X2( final DUP2_X2 obj ) { } @Override - public void visitRETURN( RETURN obj ) { + public void visitRETURN( final RETURN obj ) { } @Override - public void visitDALOAD( DALOAD obj ) { + public void visitDALOAD( final DALOAD obj ) { } @Override - public void visitSIPUSH( SIPUSH obj ) { + public void visitSIPUSH( final SIPUSH obj ) { } @Override - public void visitDSUB( DSUB obj ) { + public void visitDSUB( final DSUB obj ) { } @Override - public void visitL2F( L2F obj ) { + public void visitL2F( final L2F obj ) { } @Override - public void visitIF_ICMPGT( IF_ICMPGT obj ) { + public void visitIF_ICMPGT( final IF_ICMPGT obj ) { } @Override - public void visitF2D( F2D obj ) { + public void visitF2D( final F2D obj ) { } @Override - public void visitI2L( I2L obj ) { + public void visitI2L( final I2L obj ) { } @Override - public void visitIF_ACMPNE( IF_ACMPNE obj ) { + public void visitIF_ACMPNE( final IF_ACMPNE obj ) { } @Override - public void visitPOP( POP obj ) { + public void visitPOP( final POP obj ) { } @Override - public void visitI2S( I2S obj ) { + public void visitI2S( final I2S obj ) { } @Override - public void visitIFEQ( IFEQ obj ) { + public void visitIFEQ( final IFEQ obj ) { } @Override - public void visitSWAP( SWAP obj ) { + public void visitSWAP( final SWAP obj ) { } @Override - public void visitIOR( IOR obj ) { + public void visitIOR( final IOR obj ) { } @Override - public void visitIREM( IREM obj ) { + public void visitIREM( final IREM obj ) { } @Override - public void visitIASTORE( IASTORE obj ) { + public void visitIASTORE( final IASTORE obj ) { } @Override - public void visitNEWARRAY( NEWARRAY obj ) { + public void visitNEWARRAY( final NEWARRAY obj ) { } @Override - public void visitINVOKEINTERFACE( INVOKEINTERFACE obj ) { + public void visitINVOKEINTERFACE( final INVOKEINTERFACE obj ) { } @Override - public void visitINEG( INEG obj ) { + public void visitINEG( final INEG obj ) { } @Override - public void visitLCMP( LCMP obj ) { + public void visitLCMP( final LCMP obj ) { } @Override - public void visitJSR_W( JSR_W obj ) { + public void visitJSR_W( final JSR_W obj ) { } @Override - public void visitMULTIANEWARRAY( MULTIANEWARRAY obj ) { + public void visitMULTIANEWARRAY( final MULTIANEWARRAY obj ) { } @Override - public void visitDUP_X2( DUP_X2 obj ) { + public void visitDUP_X2( final DUP_X2 obj ) { } @Override - public void visitSALOAD( SALOAD obj ) { + public void visitSALOAD( final SALOAD obj ) { } @Override - public void visitIFNONNULL( IFNONNULL obj ) { + public void visitIFNONNULL( final IFNONNULL obj ) { } @Override - public void visitDMUL( DMUL obj ) { + public void visitDMUL( final DMUL obj ) { } @Override - public void visitIFNE( IFNE obj ) { + public void visitIFNE( final IFNE obj ) { } @Override - public void visitIF_ICMPLE( IF_ICMPLE obj ) { + public void visitIF_ICMPLE( final IF_ICMPLE obj ) { } @Override - public void visitLDC2_W( LDC2_W obj ) { + public void visitLDC2_W( final LDC2_W obj ) { } @Override - public void visitGETFIELD( GETFIELD obj ) { + public void visitGETFIELD( final GETFIELD obj ) { } @Override - public void visitLADD( LADD obj ) { + public void visitLADD( final LADD obj ) { } @Override - public void visitNOP( NOP obj ) { + public void visitNOP( final NOP obj ) { } @Override - public void visitFALOAD( FALOAD obj ) { + public void visitFALOAD( final FALOAD obj ) { } @Override - public void visitINSTANCEOF( INSTANCEOF obj ) { + public void visitINSTANCEOF( final INSTANCEOF obj ) { } @Override - public void visitIFLE( IFLE obj ) { + public void visitIFLE( final IFLE obj ) { } @Override - public void visitLXOR( LXOR obj ) { + public void visitLXOR( final LXOR obj ) { } @Override - public void visitLRETURN( LRETURN obj ) { + public void visitLRETURN( final LRETURN obj ) { } @Override - public void visitFCONST( FCONST obj ) { + public void visitFCONST( final FCONST obj ) { } @Override - public void visitIUSHR( IUSHR obj ) { + public void visitIUSHR( final IUSHR obj ) { } @Override - public void visitBALOAD( BALOAD obj ) { + public void visitBALOAD( final BALOAD obj ) { } @Override - public void visitDUP2( DUP2 obj ) { + public void visitDUP2( final DUP2 obj ) { } @Override - public void visitIF_ACMPEQ( IF_ACMPEQ obj ) { + public void visitIF_ACMPEQ( final IF_ACMPEQ obj ) { } @Override - public void visitIMPDEP1( IMPDEP1 obj ) { + public void visitIMPDEP1( final IMPDEP1 obj ) { } @Override - public void visitMONITORENTER( MONITORENTER obj ) { + public void visitMONITORENTER( final MONITORENTER obj ) { } @Override - public void visitLSHL( LSHL obj ) { + public void visitLSHL( final LSHL obj ) { } @Override - public void visitDCMPG( DCMPG obj ) { + public void visitDCMPG( final DCMPG obj ) { } @Override - public void visitD2L( D2L obj ) { + public void visitD2L( final D2L obj ) { } @Override - public void visitIMPDEP2( IMPDEP2 obj ) { + public void visitIMPDEP2( final IMPDEP2 obj ) { } @Override - public void visitL2D( L2D obj ) { + public void visitL2D( final L2D obj ) { } @Override - public void visitRET( RET obj ) { + public void visitRET( final RET obj ) { } @Override - public void visitIFGT( IFGT obj ) { + public void visitIFGT( final IFGT obj ) { } @Override - public void visitIXOR( IXOR obj ) { + public void visitIXOR( final IXOR obj ) { } @Override - public void visitINVOKEVIRTUAL( INVOKEVIRTUAL obj ) { + public void visitINVOKEVIRTUAL( final INVOKEVIRTUAL obj ) { } @Override - public void visitFASTORE( FASTORE obj ) { + public void visitFASTORE( final FASTORE obj ) { } @Override - public void visitIRETURN( IRETURN obj ) { + public void visitIRETURN( final IRETURN obj ) { } @Override - public void visitIF_ICMPNE( IF_ICMPNE obj ) { + public void visitIF_ICMPNE( final IF_ICMPNE obj ) { } @Override - public void visitFLOAD( FLOAD obj ) { + public void visitFLOAD( final FLOAD obj ) { } @Override - public void visitLDIV( LDIV obj ) { + public void visitLDIV( final LDIV obj ) { } @Override - public void visitPUTSTATIC( PUTSTATIC obj ) { + public void visitPUTSTATIC( final PUTSTATIC obj ) { } @Override - public void visitAALOAD( AALOAD obj ) { + public void visitAALOAD( final AALOAD obj ) { } @Override - public void visitD2I( D2I obj ) { + public void visitD2I( final D2I obj ) { } @Override - public void visitIF_ICMPEQ( IF_ICMPEQ obj ) { + public void visitIF_ICMPEQ( final IF_ICMPEQ obj ) { } @Override - public void visitAASTORE( AASTORE obj ) { + public void visitAASTORE( final AASTORE obj ) { } @Override - public void visitARETURN( ARETURN obj ) { + public void visitARETURN( final ARETURN obj ) { } @Override - public void visitDUP2_X1( DUP2_X1 obj ) { + public void visitDUP2_X1( final DUP2_X1 obj ) { } @Override - public void visitFNEG( FNEG obj ) { + public void visitFNEG( final FNEG obj ) { } @Override - public void visitGOTO_W( GOTO_W obj ) { + public void visitGOTO_W( final GOTO_W obj ) { } @Override - public void visitD2F( D2F obj ) { + public void visitD2F( final D2F obj ) { } @Override - public void visitGOTO( GOTO obj ) { + public void visitGOTO( final GOTO obj ) { } @Override - public void visitISUB( ISUB obj ) { + public void visitISUB( final ISUB obj ) { } @Override - public void visitF2I( F2I obj ) { + public void visitF2I( final F2I obj ) { } @Override - public void visitDNEG( DNEG obj ) { + public void visitDNEG( final DNEG obj ) { } @Override - public void visitICONST( ICONST obj ) { + public void visitICONST( final ICONST obj ) { } @Override - public void visitFDIV( FDIV obj ) { + public void visitFDIV( final FDIV obj ) { } @Override - public void visitI2B( I2B obj ) { + public void visitI2B( final I2B obj ) { } @Override - public void visitLNEG( LNEG obj ) { + public void visitLNEG( final LNEG obj ) { } @Override - public void visitLREM( LREM obj ) { + public void visitLREM( final LREM obj ) { } @Override - public void visitIMUL( IMUL obj ) { + public void visitIMUL( final IMUL obj ) { } @Override - public void visitIADD( IADD obj ) { + public void visitIADD( final IADD obj ) { } @Override - public void visitLSHR( LSHR obj ) { + public void visitLSHR( final LSHR obj ) { } @Override - public void visitLOOKUPSWITCH( LOOKUPSWITCH obj ) { + public void visitLOOKUPSWITCH( final LOOKUPSWITCH obj ) { } @Override - public void visitDUP_X1( DUP_X1 obj ) { + public void visitDUP_X1( final DUP_X1 obj ) { } @Override - public void visitFCMPL( FCMPL obj ) { + public void visitFCMPL( final FCMPL obj ) { } @Override - public void visitI2C( I2C obj ) { + public void visitI2C( final I2C obj ) { } @Override - public void visitLMUL( LMUL obj ) { + public void visitLMUL( final LMUL obj ) { } @Override - public void visitLUSHR( LUSHR obj ) { + public void visitLUSHR( final LUSHR obj ) { } @Override - public void visitISHL( ISHL obj ) { + public void visitISHL( final ISHL obj ) { } @Override - public void visitLALOAD( LALOAD obj ) { + public void visitLALOAD( final LALOAD obj ) { } @Override - public void visitASTORE( ASTORE obj ) { + public void visitASTORE( final ASTORE obj ) { } @Override - public void visitANEWARRAY( ANEWARRAY obj ) { + public void visitANEWARRAY( final ANEWARRAY obj ) { } @Override - public void visitFRETURN( FRETURN obj ) { + public void visitFRETURN( final FRETURN obj ) { } @Override - public void visitFADD( FADD obj ) { + public void visitFADD( final FADD obj ) { } @Override - public void visitBREAKPOINT( BREAKPOINT obj ) { + public void visitBREAKPOINT( final BREAKPOINT obj ) { } /** * @since 6.0 */ @Override - public void visitINVOKEDYNAMIC(INVOKEDYNAMIC obj) { + public void visitINVOKEDYNAMIC(final INVOKEDYNAMIC obj) { } } Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/EnumElementValueGen.java URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/EnumElementValueGen.java?rev=1746378&r1=1746377&r2=1746378&view=diff ============================================================================== --- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/EnumElementValueGen.java (original) +++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/EnumElementValueGen.java Wed Jun 1 04:25:27 2016 @@ -39,8 +39,8 @@ public class EnumElementValueGen extends * value - as indicated by typeIdx and valueIdx. This ctor is used for * deserialization */ - protected EnumElementValueGen(int typeIdx, int valueIdx, - ConstantPoolGen cpool) + protected EnumElementValueGen(final int typeIdx, final int valueIdx, + final ConstantPoolGen cpool) { super(ElementValueGen.ENUM_CONSTANT, cpool); if (super.getElementValueType() != ENUM_CONSTANT) { @@ -63,15 +63,15 @@ public class EnumElementValueGen extends getConstantPool().getConstantPool()); } - public EnumElementValueGen(ObjectType t, String value, ConstantPoolGen cpool) + public EnumElementValueGen(final ObjectType t, final String value, final ConstantPoolGen cpool) { super(ElementValueGen.ENUM_CONSTANT, cpool); typeIdx = cpool.addUtf8(t.getSignature());// was addClass(t); valueIdx = cpool.addUtf8(value);// was addString(value); } - public EnumElementValueGen(EnumElementValue value, ConstantPoolGen cpool, - boolean copyPoolEntries) + public EnumElementValueGen(final EnumElementValue value, final ConstantPoolGen cpool, + final boolean copyPoolEntries) { super(ENUM_CONSTANT, cpool); if (copyPoolEntries) @@ -89,7 +89,7 @@ public class EnumElementValueGen extends } @Override - public void dump(DataOutputStream dos) throws IOException + public void dump(final DataOutputStream dos) throws IOException { dos.writeByte(super.getElementValueType()); // u1 type of value (ENUM_CONSTANT == 'e') dos.writeShort(typeIdx); // u2 Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/F2D.java URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/F2D.java?rev=1746378&r1=1746377&r2=1746378&view=diff ============================================================================== --- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/F2D.java (original) +++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/F2D.java Wed Jun 1 04:25:27 2016 @@ -41,7 +41,7 @@ public class F2D extends ConversionInstr * @param v Visitor object */ @Override - public void accept( Visitor v ) { + public void accept( final Visitor v ) { v.visitTypedInstruction(this); v.visitStackProducer(this); v.visitStackConsumer(this); Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/F2I.java URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/F2I.java?rev=1746378&r1=1746377&r2=1746378&view=diff ============================================================================== --- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/F2I.java (original) +++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/F2I.java Wed Jun 1 04:25:27 2016 @@ -41,7 +41,7 @@ public class F2I extends ConversionInstr * @param v Visitor object */ @Override - public void accept( Visitor v ) { + public void accept( final Visitor v ) { v.visitTypedInstruction(this); v.visitStackProducer(this); v.visitStackConsumer(this); Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/F2L.java URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/F2L.java?rev=1746378&r1=1746377&r2=1746378&view=diff ============================================================================== --- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/F2L.java (original) +++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/F2L.java Wed Jun 1 04:25:27 2016 @@ -41,7 +41,7 @@ public class F2L extends ConversionInstr * @param v Visitor object */ @Override - public void accept( Visitor v ) { + public void accept( final Visitor v ) { v.visitTypedInstruction(this); v.visitStackProducer(this); v.visitStackConsumer(this); Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/FADD.java URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/FADD.java?rev=1746378&r1=1746377&r2=1746378&view=diff ============================================================================== --- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/FADD.java (original) +++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/FADD.java Wed Jun 1 04:25:27 2016 @@ -41,7 +41,7 @@ public class FADD extends ArithmeticInst * @param v Visitor object */ @Override - public void accept( Visitor v ) { + public void accept( final Visitor v ) { v.visitTypedInstruction(this); v.visitStackProducer(this); v.visitStackConsumer(this); Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/FALOAD.java URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/FALOAD.java?rev=1746378&r1=1746377&r2=1746378&view=diff ============================================================================== --- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/FALOAD.java (original) +++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/FALOAD.java Wed Jun 1 04:25:27 2016 @@ -41,7 +41,7 @@ public class FALOAD extends ArrayInstruc * @param v Visitor object */ @Override - public void accept( Visitor v ) { + public void accept( final Visitor v ) { v.visitStackProducer(this); v.visitExceptionThrower(this); v.visitTypedInstruction(this); Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/FASTORE.java URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/FASTORE.java?rev=1746378&r1=1746377&r2=1746378&view=diff ============================================================================== --- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/FASTORE.java (original) +++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/FASTORE.java Wed Jun 1 04:25:27 2016 @@ -41,7 +41,7 @@ public class FASTORE extends ArrayInstru * @param v Visitor object */ @Override - public void accept( Visitor v ) { + public void accept( final Visitor v ) { v.visitStackConsumer(this); v.visitExceptionThrower(this); v.visitTypedInstruction(this); Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/FCMPG.java URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/FCMPG.java?rev=1746378&r1=1746377&r2=1746378&view=diff ============================================================================== --- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/FCMPG.java (original) +++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/FCMPG.java Wed Jun 1 04:25:27 2016 @@ -33,7 +33,7 @@ public class FCMPG extends Instruction i /** @return Type.FLOAT */ @Override - public Type getType( ConstantPoolGen cp ) { + public Type getType( final ConstantPoolGen cp ) { return Type.FLOAT; } @@ -47,7 +47,7 @@ public class FCMPG extends Instruction i * @param v Visitor object */ @Override - public void accept( Visitor v ) { + public void accept( final Visitor v ) { v.visitTypedInstruction(this); v.visitStackProducer(this); v.visitStackConsumer(this);
