Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/Instruction.java URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/Instruction.java?rev=1746378&r1=1746377&r2=1746378&view=diff ============================================================================== --- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/Instruction.java (original) +++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/Instruction.java Wed Jun 1 04:25:27 2016 @@ -54,7 +54,7 @@ public abstract class Instruction implem } - public Instruction(short opcode, short length) { + public Instruction(final short opcode, final short length) { this.length = length; this.opcode = opcode; } @@ -64,7 +64,7 @@ public abstract class Instruction implem * Dump instruction as byte code to stream out. * @param out Output stream */ - public void dump( DataOutputStream out ) throws IOException { + public void dump( final DataOutputStream out ) throws IOException { out.writeByte(opcode); // Common for all instructions } @@ -85,7 +85,7 @@ public abstract class Instruction implem * @param verbose long/short format switch * @return mnemonic for instruction */ - public String toString( boolean verbose ) { + public String toString( final boolean verbose ) { if (verbose) { return getName() + "[" + opcode + "](" + length + ")"; } @@ -105,7 +105,7 @@ public abstract class Instruction implem /** * @return mnemonic for instruction with sumbolic references resolved */ - public String toString( ConstantPool cp ) { + public String toString( final ConstantPool cp ) { return toString(false); } @@ -141,7 +141,7 @@ public abstract class Instruction implem * @param wide "wide" instruction flag * @throws IOException may be thrown if the implementation needs to read data from the file */ - protected void initFromFile( ByteSequence bytes, boolean wide ) throws IOException { + protected void initFromFile( final ByteSequence bytes, final boolean wide ) throws IOException { } @@ -156,7 +156,7 @@ public abstract class Instruction implem * @see InstructionConst#getInstruction(int) */ // @since 6.0 no longer final - public static Instruction readInstruction( ByteSequence bytes ) throws IOException { + public static Instruction readInstruction( final ByteSequence bytes ) throws IOException { boolean wide = false; short opcode = (short) bytes.readUnsignedByte(); Instruction obj = null; @@ -482,7 +482,7 @@ public abstract class Instruction implem * @return Number of words consumed from stack by this instruction, * or Constants.UNPREDICTABLE, if this can not be computed statically */ - public int consumeStack( ConstantPoolGen cpg ) { + public int consumeStack( final ConstantPoolGen cpg ) { return Const.getConsumeStack(opcode); } @@ -494,7 +494,7 @@ public abstract class Instruction implem * @return Number of words produced onto stack by this instruction, * or Constants.UNPREDICTABLE, if this can not be computed statically */ - public int produceStack( ConstantPoolGen cpg ) { + public int produceStack( final ConstantPoolGen cpg ) { return Const.getProduceStack(opcode); } @@ -518,7 +518,7 @@ public abstract class Instruction implem /** * Needed in readInstruction and subclasses in this package */ - final void setOpcode( short opcode ) { + final void setOpcode( final short opcode ) { this.opcode = opcode; } @@ -527,7 +527,7 @@ public abstract class Instruction implem * Needed in readInstruction and subclasses in this package * @since 6.0 */ - final void setLength( int length ) { + final void setLength( final int length ) { this.length = (short) length; // TODO check range? } @@ -565,7 +565,7 @@ public abstract class Instruction implem * @deprecated use the built in comparator, or wrap this class in another object that implements these methods */ @Deprecated - public static void setComparator( InstructionComparator c ) { + public static void setComparator( final InstructionComparator c ) { cmp = c; } @@ -574,7 +574,7 @@ public abstract class Instruction implem * @return true if that is an Instruction and has the same opcode */ @Override - public boolean equals( Object that ) { + public boolean equals( final Object that ) { return (that instanceof Instruction) ? cmp.equals(this, (Instruction) that) : false; } @@ -593,7 +593,7 @@ public abstract class Instruction implem * @return true if the value is in range * @since 6.0 */ - public static boolean isValidByte(int value) { + public static boolean isValidByte(final int value) { return value >= Byte.MIN_VALUE && value <= Byte.MAX_VALUE; } @@ -603,7 +603,7 @@ public abstract class Instruction implem * @return true if the value is in range * @since 6.0 */ - public static boolean isValidShort(int value) { + public static boolean isValidShort(final int value) { return value >= Short.MIN_VALUE && value <= Short.MAX_VALUE; } }
Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/InstructionComparator.java URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/InstructionComparator.java?rev=1746378&r1=1746377&r2=1746378&view=diff ============================================================================== --- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/InstructionComparator.java (original) +++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/InstructionComparator.java Wed Jun 1 04:25:27 2016 @@ -34,7 +34,7 @@ public interface InstructionComparator { public static final InstructionComparator DEFAULT = new InstructionComparator() { @Override - public boolean equals( Instruction i1, Instruction i2 ) { + public boolean equals( final Instruction i1, final Instruction i2 ) { if (i1.getOpcode() == i2.getOpcode()) { if (i1 instanceof BranchInstruction) { // BIs are never equal to make targeters work correctly (BCEL-195) Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/InstructionConst.java URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/InstructionConst.java?rev=1746378&r1=1746377&r2=1746378&view=diff ============================================================================== --- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/InstructionConst.java (original) +++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/InstructionConst.java Wed Jun 1 04:25:27 2016 @@ -291,7 +291,7 @@ public final class InstructionConst { * @param index the index, e.g. {@link Const#RETURN} * @return the entry from the private INSTRUCTIONS table */ - public static Instruction getInstruction(int index) { + public static Instruction getInstruction(final int index) { return INSTRUCTIONS[index]; } } Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/InstructionFactory.java URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/InstructionFactory.java?rev=1746378&r1=1746377&r2=1746378&view=diff ============================================================================== --- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/InstructionFactory.java (original) +++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/InstructionFactory.java Wed Jun 1 04:25:27 2016 @@ -52,7 +52,7 @@ public class InstructionFactory { protected ConstantPoolGen cp; - public InstructionFactory(ClassGen cg, ConstantPoolGen cp) { + public InstructionFactory(final ClassGen cg, final ConstantPoolGen cp) { this.cg = cg; this.cp = cp; } @@ -60,14 +60,14 @@ public class InstructionFactory { /** Initialize with ClassGen object */ - public InstructionFactory(ClassGen cg) { + public InstructionFactory(final ClassGen cg) { this(cg, cg.getConstantPool()); } /** Initialize just with ConstantPoolGen object */ - public InstructionFactory(ConstantPoolGen cp) { + public InstructionFactory(final ConstantPoolGen cp) { this(null, cp); } @@ -82,8 +82,8 @@ public class InstructionFactory { * or INVOKESPECIAL * @see Const */ - public InvokeInstruction createInvoke( String class_name, String name, Type ret_type, - Type[] arg_types, short kind ) { + public InvokeInstruction createInvoke( final String class_name, final String name, final Type ret_type, + final Type[] arg_types, final short kind ) { int index; int nargs = 0; String signature = Type.getMethodSignature(ret_type, arg_types); @@ -142,7 +142,7 @@ public class InstructionFactory { * * @param s the string to print */ - public InstructionList createPrintln( String s ) { + public InstructionList createPrintln( final String s ) { InstructionList il = new InstructionList(); int out = cp.addFieldref("java.lang.System", "out", "Ljava/io/PrintStream;"); int println = cp.addMethodref("java.io.PrintStream", "println", "(Ljava/lang/String;)V"); @@ -156,7 +156,7 @@ public class InstructionFactory { /** Uses PUSH to push a constant value onto the stack. * @param value must be of type Number, Boolean, Character or String */ - public Instruction createConstant( Object value ) { + public Instruction createConstant( final Object value ) { PUSH push; if (value instanceof Number) { push = new PUSH(cp, (Number) value); @@ -180,7 +180,7 @@ public class InstructionFactory { final String name; - MethodObject(String c, String n, Type r, Type[] a) { + MethodObject(final String c, final String n, final Type r, final Type[] a) { class_name = c; name = n; result_type = r; @@ -189,7 +189,7 @@ public class InstructionFactory { } - private InvokeInstruction createInvoke( MethodObject m, short kind ) { + private InvokeInstruction createInvoke( final MethodObject m, final short kind ) { return createInvoke(m.class_name, m.name, m.result_type, m.arg_types, kind); } @@ -231,13 +231,13 @@ public class InstructionFactory { }; - private static boolean isString( Type type ) { + private static boolean isString( final Type type ) { return (type instanceof ObjectType) && ((ObjectType) type).getClassName().equals("java.lang.String"); } - public Instruction createAppend( Type type ) { + public Instruction createAppend( final Type type ) { byte t = type.getType(); if (isString(type)) { return createInvoke(append_mos[0], Const.INVOKEVIRTUAL); @@ -269,7 +269,7 @@ public class InstructionFactory { * @param kind how to access, i.e., GETFIELD, PUTFIELD, GETSTATIC, PUTSTATIC * @see Const */ - public FieldInstruction createFieldAccess( String class_name, String name, Type type, short kind ) { + public FieldInstruction createFieldAccess( final String class_name, final String name, final Type type, final short kind ) { int index; String signature = type.getSignature(); index = cp.addFieldref(class_name, name, signature); @@ -297,7 +297,7 @@ public class InstructionFactory { /** Create typed return */ - public static ReturnInstruction createReturn( Type type ) { + public static ReturnInstruction createReturn( final Type type ) { switch (type.getType()) { case Const.T_ARRAY: case Const.T_OBJECT: @@ -322,7 +322,7 @@ public class InstructionFactory { } - private static ArithmeticInstruction createBinaryIntOp( char first, String op ) { + private static ArithmeticInstruction createBinaryIntOp( final char first, final String op ) { switch (first) { case '-': return InstructionConst.ISUB; @@ -350,7 +350,7 @@ public class InstructionFactory { } - private static ArithmeticInstruction createBinaryLongOp( char first, String op ) { + private static ArithmeticInstruction createBinaryLongOp( final char first, final String op ) { switch (first) { case '-': return InstructionConst.LSUB; @@ -378,7 +378,7 @@ public class InstructionFactory { } - private static ArithmeticInstruction createBinaryFloatOp( char op ) { + private static ArithmeticInstruction createBinaryFloatOp( final char op ) { switch (op) { case '-': return InstructionConst.FSUB; @@ -396,7 +396,7 @@ public class InstructionFactory { } - private static ArithmeticInstruction createBinaryDoubleOp( char op ) { + private static ArithmeticInstruction createBinaryDoubleOp( final char op ) { switch (op) { case '-': return InstructionConst.DSUB; @@ -419,7 +419,7 @@ public class InstructionFactory { * * @param op operation, such as "+", "*", "<<", etc. */ - public static ArithmeticInstruction createBinaryOperation( String op, Type type ) { + public static ArithmeticInstruction createBinaryOperation( final String op, final Type type ) { char first = op.charAt(0); switch (type.getType()) { case Const.T_BYTE: @@ -442,7 +442,7 @@ public class InstructionFactory { /** * @param size size of operand, either 1 (int, e.g.) or 2 (double) */ - public static StackInstruction createPop( int size ) { + public static StackInstruction createPop( final int size ) { return (size == 2) ? InstructionConst.POP2 : InstructionConst.POP; } @@ -450,7 +450,7 @@ public class InstructionFactory { /** * @param size size of operand, either 1 (int, e.g.) or 2 (double) */ - public static StackInstruction createDup( int size ) { + public static StackInstruction createDup( final int size ) { return (size == 2) ? InstructionConst.DUP2 : InstructionConst.DUP; } @@ -458,7 +458,7 @@ public class InstructionFactory { /** * @param size size of operand, either 1 (int, e.g.) or 2 (double) */ - public static StackInstruction createDup_2( int size ) { + public static StackInstruction createDup_2( final int size ) { return (size == 2) ? InstructionConst.DUP2_X2 : InstructionConst.DUP_X2; } @@ -466,7 +466,7 @@ public class InstructionFactory { /** * @param size size of operand, either 1 (int, e.g.) or 2 (double) */ - public static StackInstruction createDup_1( int size ) { + public static StackInstruction createDup_1( final int size ) { return (size == 2) ? InstructionConst.DUP2_X1 : InstructionConst.DUP_X1; } @@ -474,7 +474,7 @@ public class InstructionFactory { /** * @param index index of local variable */ - public static LocalVariableInstruction createStore( Type type, int index ) { + public static LocalVariableInstruction createStore( final Type type, final int index ) { switch (type.getType()) { case Const.T_BOOLEAN: case Const.T_CHAR: @@ -500,7 +500,7 @@ public class InstructionFactory { /** * @param index index of local variable */ - public static LocalVariableInstruction createLoad( Type type, int index ) { + public static LocalVariableInstruction createLoad( final Type type, final int index ) { switch (type.getType()) { case Const.T_BOOLEAN: case Const.T_CHAR: @@ -526,7 +526,7 @@ public class InstructionFactory { /** * @param type type of elements of array, i.e., array.getElementType() */ - public static ArrayInstruction createArrayLoad( Type type ) { + public static ArrayInstruction createArrayLoad( final Type type ) { switch (type.getType()) { case Const.T_BOOLEAN: case Const.T_BYTE: @@ -555,7 +555,7 @@ public class InstructionFactory { /** * @param type type of elements of array, i.e., array.getElementType() */ - public static ArrayInstruction createArrayStore( Type type ) { + public static ArrayInstruction createArrayStore( final Type type ) { switch (type.getType()) { case Const.T_BOOLEAN: case Const.T_BYTE: @@ -584,7 +584,7 @@ public class InstructionFactory { /** Create conversion operation for two stack operands, this may be an I2C, instruction, e.g., * if the operands are basic types and CHECKCAST if they are reference types. */ - public Instruction createCast( Type src_type, Type dest_type ) { + public Instruction createCast( final Type src_type, final Type dest_type ) { if ((src_type instanceof BasicType) && (dest_type instanceof BasicType)) { byte dest = dest_type.getType(); byte src = src_type.getType(); @@ -612,27 +612,27 @@ public class InstructionFactory { } - public GETFIELD createGetField( String class_name, String name, Type t ) { + public GETFIELD createGetField( final String class_name, final String name, final Type t ) { return new GETFIELD(cp.addFieldref(class_name, name, t.getSignature())); } - public GETSTATIC createGetStatic( String class_name, String name, Type t ) { + public GETSTATIC createGetStatic( final String class_name, final String name, final Type t ) { return new GETSTATIC(cp.addFieldref(class_name, name, t.getSignature())); } - public PUTFIELD createPutField( String class_name, String name, Type t ) { + public PUTFIELD createPutField( final String class_name, final String name, final Type t ) { return new PUTFIELD(cp.addFieldref(class_name, name, t.getSignature())); } - public PUTSTATIC createPutStatic( String class_name, String name, Type t ) { + public PUTSTATIC createPutStatic( final String class_name, final String name, final Type t ) { return new PUTSTATIC(cp.addFieldref(class_name, name, t.getSignature())); } - public CHECKCAST createCheckCast( ReferenceType t ) { + public CHECKCAST createCheckCast( final ReferenceType t ) { if (t instanceof ArrayType) { return new CHECKCAST(cp.addArrayClass((ArrayType) t)); } @@ -640,7 +640,7 @@ public class InstructionFactory { } - public INSTANCEOF createInstanceOf( ReferenceType t ) { + public INSTANCEOF createInstanceOf( final ReferenceType t ) { if (t instanceof ArrayType) { return new INSTANCEOF(cp.addArrayClass((ArrayType) t)); } @@ -648,12 +648,12 @@ public class InstructionFactory { } - public NEW createNew( ObjectType t ) { + public NEW createNew( final ObjectType t ) { return new NEW(cp.addClass(t)); } - public NEW createNew( String s ) { + public NEW createNew( final String s ) { return createNew(ObjectType.getInstance(s)); } @@ -661,7 +661,7 @@ public class InstructionFactory { /** Create new array of given size and type. * @return an instruction that creates the corresponding array at runtime, i.e. is an AllocationInstruction */ - public Instruction createNewArray( Type t, short dim ) { + public Instruction createNewArray( final Type t, final short dim ) { if (dim == 1) { if (t instanceof ObjectType) { return new ANEWARRAY(cp.addClass((ObjectType) t)); @@ -683,7 +683,7 @@ public class InstructionFactory { /** Create "null" value for reference types, 0 for basic types like int */ - public static Instruction createNull( Type type ) { + public static Instruction createNull( final Type type ) { switch (type.getType()) { case Const.T_ARRAY: case Const.T_OBJECT: @@ -711,7 +711,7 @@ public class InstructionFactory { /** Create branch instruction by given opcode, except LOOKUPSWITCH and TABLESWITCH. * For those you should use the SWITCH compound instruction. */ - public static BranchInstruction createBranchInstruction( short opcode, InstructionHandle target ) { + public static BranchInstruction createBranchInstruction( final short opcode, final InstructionHandle target ) { switch (opcode) { case Const.IFEQ: return new IFEQ(target); @@ -759,7 +759,7 @@ public class InstructionFactory { } - public void setClassGen( ClassGen c ) { + public void setClassGen( final ClassGen c ) { cg = c; } @@ -769,7 +769,7 @@ public class InstructionFactory { } - public void setConstantPool( ConstantPoolGen c ) { + public void setConstantPool( final ConstantPoolGen c ) { cp = c; } Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/InstructionHandle.java URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/InstructionHandle.java?rev=1746378&r1=1746377&r2=1746378&view=diff ============================================================================== --- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/InstructionHandle.java (original) +++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/InstructionHandle.java Wed Jun 1 04:25:27 2016 @@ -77,7 +77,7 @@ public class InstructionHandle { * Replace current instruction contained in this handle. * Old instruction is disposed using Instruction.dispose(). */ - public void setInstruction( Instruction i ) { // Overridden in BranchHandle TODO could be package-protected? + public void setInstruction( final Instruction i ) { // Overridden in BranchHandle TODO could be package-protected? if (i == null) { throw new ClassGenException("Assigning null to handle"); } @@ -96,14 +96,14 @@ public class InstructionHandle { * anything. Meant to be used by a debugger, implementing * breakpoints. Current instruction is returned. */ - public Instruction swapInstruction( Instruction i ) { + public Instruction swapInstruction( final Instruction i ) { Instruction oldInstruction = instruction; instruction = i; return oldInstruction; } - /*private*/protected InstructionHandle(Instruction i) { + /*private*/protected InstructionHandle(final Instruction i) { setInstruction(i); } @@ -112,7 +112,7 @@ public class InstructionHandle { /** Factory method. */ - static InstructionHandle getInstructionHandle( Instruction i ) { + static InstructionHandle getInstructionHandle( final Instruction i ) { if (ih_list == null) { return new InstructionHandle(i); } @@ -133,7 +133,7 @@ public class InstructionHandle { * @param max_offset the maximum offset that may be caused by these instructions * @return additional offset caused by possible change of this instruction's length */ - protected int updatePosition( int offset, int max_offset ) { + protected int updatePosition( final int offset, final int max_offset ) { i_position += offset; return 0; } @@ -151,7 +151,7 @@ public class InstructionHandle { /** Set the position, i.e., the byte code offset of the contained * instruction. */ - void setPosition( int pos ) { + void setPosition( final int pos ) { i_position = pos; } @@ -190,7 +190,7 @@ public class InstructionHandle { /** * Denote this handle isn't referenced anymore by t. */ - public void removeTargeter( InstructionTargeter t ) { + public void removeTargeter( final InstructionTargeter t ) { if (targeters != null) { targeters.remove(t); } @@ -200,7 +200,7 @@ public class InstructionHandle { /** * Denote this handle is being referenced by t. */ - public void addTargeter( InstructionTargeter t ) { + public void addTargeter( final InstructionTargeter t ) { if (targeters == null) { targeters = new HashSet<>(); } @@ -229,7 +229,7 @@ public class InstructionHandle { /** @return a (verbose) string representation of the contained instruction. */ - public String toString( boolean verbose ) { + public String toString( final boolean verbose ) { return Utility.format(i_position, 4, false, ' ') + ": " + instruction.toString(verbose); } @@ -247,7 +247,7 @@ public class InstructionHandle { * @param key the key object to store/retrieve the attribute * @param attr the attribute to associate with this handle */ - public void addAttribute( Object key, Object attr ) { + public void addAttribute( final Object key, final Object attr ) { if (attributes == null) { attributes = new HashMap<>(3); } @@ -259,7 +259,7 @@ public class InstructionHandle { * * @param key the key object to retrieve the attribute */ - public void removeAttribute( Object key ) { + public void removeAttribute( final Object key ) { if (attributes != null) { attributes.remove(key); } @@ -270,7 +270,7 @@ public class InstructionHandle { * * @param key the key object to store/retrieve the attribute */ - public Object getAttribute( Object key ) { + public Object getAttribute( final Object key ) { if (attributes != null) { return attributes.get(key); } @@ -292,7 +292,7 @@ public class InstructionHandle { * * @param v Visitor object */ - public void accept( Visitor v ) { + public void accept( final Visitor v ) { instruction.accept(v); } @@ -301,7 +301,7 @@ public class InstructionHandle { * @param next the next to set * @ since 6.0 */ - final InstructionHandle setNext(InstructionHandle next) { + final InstructionHandle setNext(final InstructionHandle next) { this.next = next; return next; } @@ -311,7 +311,7 @@ public class InstructionHandle { * @param prev the prev to set * @ since 6.0 */ - final InstructionHandle setPrev(InstructionHandle prev) { + final InstructionHandle setPrev(final InstructionHandle prev) { this.prev = prev; return prev; } Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/InstructionList.java URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/InstructionList.java?rev=1746378&r1=1746377&r2=1746378&view=diff ============================================================================== --- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/InstructionList.java (original) +++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/InstructionList.java Wed Jun 1 04:25:27 2016 @@ -62,7 +62,7 @@ public class InstructionList implements * @param i * initial instruction */ - public InstructionList(Instruction i) { + public InstructionList(final Instruction i) { append(i); } @@ -72,7 +72,7 @@ public class InstructionList implements * @param i * initial instruction */ - public InstructionList(BranchInstruction i) { + public InstructionList(final BranchInstruction i) { append(i); } @@ -82,7 +82,7 @@ public class InstructionList implements * @param c * compound instruction (list) */ - public InstructionList(CompoundInstruction c) { + public InstructionList(final CompoundInstruction c) { append(c.getInstructionList()); } @@ -106,7 +106,7 @@ public class InstructionList implements * target position to search for * @return target position's instruction handle if available */ - public static InstructionHandle findHandle(InstructionHandle[] ihs, int[] pos, int count, int target) { + public static InstructionHandle findHandle(final InstructionHandle[] ihs, final int[] pos, final int count, final int target) { int l = 0; int r = count - 1; /* @@ -134,7 +134,7 @@ public class InstructionList implements * byte code position to search for * @return target position's instruction handle if available */ - public InstructionHandle findHandle(int pos) { + public InstructionHandle findHandle(final int pos) { int[] positions = byte_positions; InstructionHandle ih = start; for (int i = 0; i < length; i++) { @@ -152,7 +152,7 @@ public class InstructionList implements * @param code * byte array containing the instructions */ - public InstructionList(byte[] code) { + public InstructionList(final byte[] code) { ByteSequence bytes = new ByteSequence(code); InstructionHandle[] ihs = new InstructionHandle[code.length]; int[] pos = new int[code.length]; // Can't be more than that @@ -225,7 +225,7 @@ public class InstructionList implements * Instruction list to append to this one * @return instruction handle pointing to the <B>first</B> appended instruction */ - public InstructionHandle append(InstructionHandle ih, InstructionList il) { + public InstructionHandle append(final InstructionHandle ih, final InstructionList il) { if (il == null) { throw new ClassGenException("Appending null InstructionList"); } @@ -256,7 +256,7 @@ public class InstructionList implements * Instruction list to append to this one * @return instruction handle pointing to the <B>first</B> appended instruction */ - public InstructionHandle append(Instruction i, InstructionList il) { + public InstructionHandle append(final Instruction i, final InstructionList il) { InstructionHandle ih; if ((ih = findInstruction2(i)) == null) { throw new ClassGenException("Instruction " + i + " is not contained in this list."); @@ -271,7 +271,7 @@ public class InstructionList implements * list to append to end of this list * @return instruction handle of the <B>first</B> appended instruction */ - public InstructionHandle append(InstructionList il) { + public InstructionHandle append(final InstructionList il) { if (il == null) { throw new ClassGenException("Appending null InstructionList"); } @@ -294,7 +294,7 @@ public class InstructionList implements * @param ih * instruction to append */ - private void append(InstructionHandle ih) { + private void append(final InstructionHandle ih) { if (isEmpty()) { start = end = ih; ih.setNext(ih.setPrev(null)); @@ -314,7 +314,7 @@ public class InstructionList implements * instruction to append * @return instruction handle of the appended instruction */ - public InstructionHandle append(Instruction i) { + public InstructionHandle append(final Instruction i) { InstructionHandle ih = InstructionHandle.getInstructionHandle(i); append(ih); return ih; @@ -327,7 +327,7 @@ public class InstructionList implements * branch instruction to append * @return branch instruction handle of the appended instruction */ - public BranchHandle append(BranchInstruction i) { + public BranchHandle append(final BranchInstruction i) { BranchHandle ih = BranchHandle.getBranchHandle(i); append(ih); return ih; @@ -342,7 +342,7 @@ public class InstructionList implements * Instruction to append after i in list * @return instruction handle of the first appended instruction */ - public InstructionHandle append(Instruction i, Instruction j) { + public InstructionHandle append(final Instruction i, final Instruction j) { return append(i, new InstructionList(j)); } @@ -355,7 +355,7 @@ public class InstructionList implements * The composite instruction (containing an InstructionList) * @return instruction handle of the first appended instruction */ - public InstructionHandle append(Instruction i, CompoundInstruction c) { + public InstructionHandle append(final Instruction i, final CompoundInstruction c) { return append(i, c.getInstructionList()); } @@ -366,7 +366,7 @@ public class InstructionList implements * The composite instruction (containing an InstructionList) * @return instruction handle of the first appended instruction */ - public InstructionHandle append(CompoundInstruction c) { + public InstructionHandle append(final CompoundInstruction c) { return append(c.getInstructionList()); } @@ -379,7 +379,7 @@ public class InstructionList implements * The composite instruction (containing an InstructionList) * @return instruction handle of the first appended instruction */ - public InstructionHandle append(InstructionHandle ih, CompoundInstruction c) { + public InstructionHandle append(final InstructionHandle ih, final CompoundInstruction c) { return append(ih, c.getInstructionList()); } @@ -392,7 +392,7 @@ public class InstructionList implements * Instruction to append * @return instruction handle pointing to the <B>first</B> appended instruction */ - public InstructionHandle append(InstructionHandle ih, Instruction i) { + public InstructionHandle append(final InstructionHandle ih, final Instruction i) { return append(ih, new InstructionList(i)); } @@ -405,7 +405,7 @@ public class InstructionList implements * Instruction to append * @return instruction handle pointing to the <B>first</B> appended instruction */ - public BranchHandle append(InstructionHandle ih, BranchInstruction i) { + public BranchHandle append(final InstructionHandle ih, final BranchInstruction i) { BranchHandle bh = BranchHandle.getBranchHandle(i); InstructionList il = new InstructionList(); il.append(bh); @@ -422,7 +422,7 @@ public class InstructionList implements * Instruction list to insert * @return instruction handle of the first inserted instruction */ - public InstructionHandle insert(InstructionHandle ih, InstructionList il) { + public InstructionHandle insert(final InstructionHandle ih, final InstructionList il) { if (il == null) { throw new ClassGenException("Inserting null InstructionList"); } @@ -451,7 +451,7 @@ public class InstructionList implements * list to insert before start of this list * @return instruction handle of the first inserted instruction */ - public InstructionHandle insert(InstructionList il) { + public InstructionHandle insert(final InstructionList il) { if (isEmpty()) { append(il); // Code is identical for this case return start; @@ -465,7 +465,7 @@ public class InstructionList implements * @param ih * instruction to insert */ - private void insert(InstructionHandle ih) { + private void insert(final InstructionHandle ih) { if (isEmpty()) { start = end = ih; ih.setNext(ih.setPrev(null)); @@ -487,7 +487,7 @@ public class InstructionList implements * Instruction list to insert * @return instruction handle pointing to the first inserted instruction, i.e., il.getStart() */ - public InstructionHandle insert(Instruction i, InstructionList il) { + public InstructionHandle insert(final Instruction i, final InstructionList il) { InstructionHandle ih; if ((ih = findInstruction1(i)) == null) { throw new ClassGenException("Instruction " + i + " is not contained in this list."); @@ -502,7 +502,7 @@ public class InstructionList implements * instruction to insert * @return instruction handle of the inserted instruction */ - public InstructionHandle insert(Instruction i) { + public InstructionHandle insert(final Instruction i) { InstructionHandle ih = InstructionHandle.getInstructionHandle(i); insert(ih); return ih; @@ -515,7 +515,7 @@ public class InstructionList implements * branch instruction to insert * @return branch instruction handle of the appended instruction */ - public BranchHandle insert(BranchInstruction i) { + public BranchHandle insert(final BranchInstruction i) { BranchHandle ih = BranchHandle.getBranchHandle(i); insert(ih); return ih; @@ -530,7 +530,7 @@ public class InstructionList implements * Instruction to insert before i in list * @return instruction handle of the first inserted instruction */ - public InstructionHandle insert(Instruction i, Instruction j) { + public InstructionHandle insert(final Instruction i, final Instruction j) { return insert(i, new InstructionList(j)); } @@ -543,7 +543,7 @@ public class InstructionList implements * The composite instruction (containing an InstructionList) * @return instruction handle of the first inserted instruction */ - public InstructionHandle insert(Instruction i, CompoundInstruction c) { + public InstructionHandle insert(final Instruction i, final CompoundInstruction c) { return insert(i, c.getInstructionList()); } @@ -554,7 +554,7 @@ public class InstructionList implements * The composite instruction (containing an InstructionList) * @return instruction handle of the first inserted instruction */ - public InstructionHandle insert(CompoundInstruction c) { + public InstructionHandle insert(final CompoundInstruction c) { return insert(c.getInstructionList()); } @@ -567,7 +567,7 @@ public class InstructionList implements * Instruction to insert * @return instruction handle of the first inserted instruction */ - public InstructionHandle insert(InstructionHandle ih, Instruction i) { + public InstructionHandle insert(final InstructionHandle ih, final Instruction i) { return insert(ih, new InstructionList(i)); } @@ -580,7 +580,7 @@ public class InstructionList implements * The composite instruction (containing an InstructionList) * @return instruction handle of the first inserted instruction */ - public InstructionHandle insert(InstructionHandle ih, CompoundInstruction c) { + public InstructionHandle insert(final InstructionHandle ih, final CompoundInstruction c) { return insert(ih, c.getInstructionList()); } @@ -593,7 +593,7 @@ public class InstructionList implements * Instruction to insert * @return instruction handle of the first inserted instruction */ - public BranchHandle insert(InstructionHandle ih, BranchInstruction i) { + public BranchHandle insert(final InstructionHandle ih, final BranchInstruction i) { BranchHandle bh = BranchHandle.getBranchHandle(i); InstructionList il = new InstructionList(); il.append(bh); @@ -613,7 +613,7 @@ public class InstructionList implements * @param target * of moved block */ - public void move(InstructionHandle start, InstructionHandle end, InstructionHandle target) { + public void move(final InstructionHandle start, final InstructionHandle end, final InstructionHandle target) { // Step 1: Check constraints if ((start == null) || (end == null)) { throw new ClassGenException("Invalid null handle: From " + start + " to " + end); @@ -670,7 +670,7 @@ public class InstructionList implements * @param target * new location of moved instruction */ - public void move(InstructionHandle ih, InstructionHandle target) { + public void move(final InstructionHandle ih, final InstructionHandle target) { move(ih, ih, target); } @@ -683,7 +683,7 @@ public class InstructionList implements * @param next * where to end deleting (successor, exclusive) */ - private void remove(InstructionHandle prev, InstructionHandle next) throws TargetLostException { + private void remove(final InstructionHandle prev, InstructionHandle next) throws TargetLostException { InstructionHandle first; InstructionHandle last; // First and last deleted instruction if ((prev == null) && (next == null)) { @@ -738,7 +738,7 @@ public class InstructionList implements * @param ih * instruction (handle) to remove */ - public void delete(InstructionHandle ih) throws TargetLostException { + public void delete(final InstructionHandle ih) throws TargetLostException { remove(ih.getPrev(), ih.getNext()); } @@ -748,7 +748,7 @@ public class InstructionList implements * @param i * instruction to remove */ - public void delete(Instruction i) throws TargetLostException { + public void delete(final Instruction i) throws TargetLostException { InstructionHandle ih; if ((ih = findInstruction1(i)) == null) { throw new ClassGenException("Instruction " + i + " is not contained in this list."); @@ -765,7 +765,7 @@ public class InstructionList implements * @param to * where to end deleting (inclusive) */ - public void delete(InstructionHandle from, InstructionHandle to) throws TargetLostException { + public void delete(final InstructionHandle from, final InstructionHandle to) throws TargetLostException { remove(from.getPrev(), to.getNext()); } @@ -778,7 +778,7 @@ public class InstructionList implements * @param to * where to end deleting (inclusive) */ - public void delete(Instruction from, Instruction to) throws TargetLostException { + public void delete(final Instruction from, final Instruction to) throws TargetLostException { InstructionHandle from_ih; InstructionHandle to_ih; if ((from_ih = findInstruction1(from)) == null) { @@ -797,7 +797,7 @@ public class InstructionList implements * instruction to search for * @return instruction found on success, null otherwise */ - private InstructionHandle findInstruction1(Instruction i) { + private InstructionHandle findInstruction1(final Instruction i) { for (InstructionHandle ih = start; ih != null; ih = ih.getNext()) { if (ih.getInstruction() == i) { return ih; @@ -813,7 +813,7 @@ public class InstructionList implements * instruction to search for * @return instruction found on success, null otherwise */ - private InstructionHandle findInstruction2(Instruction i) { + private InstructionHandle findInstruction2(final Instruction i) { for (InstructionHandle ih = end; ih != null; ih = ih.getPrev()) { if (ih.getInstruction() == i) { return ih; @@ -822,7 +822,7 @@ public class InstructionList implements return null; } - public boolean contains(InstructionHandle i) { + public boolean contains(final InstructionHandle i) { if (i == null) { return false; } @@ -834,7 +834,7 @@ public class InstructionList implements return false; } - public boolean contains(Instruction i) { + public boolean contains(final Instruction i) { return findInstruction1(i) != null; } @@ -848,7 +848,7 @@ public class InstructionList implements * @param check * Perform sanity checks, e.g. if all targeted instructions really belong to this list */ - public void setPositions(boolean check) { // called by code in other packages + public void setPositions(final boolean check) { // called by code in other packages int max_additional_bytes = 0; int additional_bytes = 0; int index = 0; @@ -974,7 +974,7 @@ public class InstructionList implements * toggle output format * @return String containing all instructions in this list. */ - public String toString(boolean verbose) { + public String toString(final boolean verbose) { StringBuilder buf = new StringBuilder(); for (InstructionHandle ih = start; ih != null; ih = ih.getNext()) { buf.append(ih.toString(verbose)).append("\n"); @@ -1085,7 +1085,7 @@ public class InstructionList implements /** * Replace all references to the old constant pool with references to the new constant pool */ - public void replaceConstantPool(ConstantPoolGen old_cp, ConstantPoolGen new_cp) { + public void replaceConstantPool(final ConstantPoolGen old_cp, final ConstantPoolGen new_cp) { for (InstructionHandle ih = start; ih != null; ih = ih.getNext()) { Instruction i = ih.getInstruction(); if (i instanceof CPInstruction) { @@ -1152,7 +1152,7 @@ public class InstructionList implements * @param new_target * the new target instruction handle */ - public void redirectBranches(InstructionHandle old_target, InstructionHandle new_target) { + public void redirectBranches(final InstructionHandle old_target, final InstructionHandle new_target) { for (InstructionHandle ih = start; ih != null; ih = ih.getNext()) { Instruction i = ih.getInstruction(); if (i instanceof BranchInstruction) { @@ -1184,7 +1184,7 @@ public class InstructionList implements * the new target instruction handle * @see MethodGen */ - public void redirectLocalVariables(LocalVariableGen[] lg, InstructionHandle old_target, InstructionHandle new_target) { + public void redirectLocalVariables(final LocalVariableGen[] lg, final InstructionHandle old_target, final InstructionHandle new_target) { for (LocalVariableGen element : lg) { InstructionHandle start = element.getStart(); InstructionHandle end = element.getEnd(); @@ -1208,7 +1208,7 @@ public class InstructionList implements * the new target instruction handle * @see MethodGen */ - public void redirectExceptionHandlers(CodeExceptionGen[] exceptions, InstructionHandle old_target, InstructionHandle new_target) { + public void redirectExceptionHandlers(final CodeExceptionGen[] exceptions, final InstructionHandle old_target, final InstructionHandle new_target) { for (CodeExceptionGen exception : exceptions) { if (exception.getStartPC() == old_target) { exception.setStartPC(new_target); @@ -1227,7 +1227,7 @@ public class InstructionList implements /** * Add observer for this object. */ - public void addObserver(InstructionListObserver o) { + public void addObserver(final InstructionListObserver o) { if (observers == null) { observers = new ArrayList<>(); } @@ -1237,7 +1237,7 @@ public class InstructionList implements /** * Remove observer for this object. */ - public void removeObserver(InstructionListObserver o) { + public void removeObserver(final InstructionListObserver o) { if (observers != null) { observers.remove(o); } Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/InvokeInstruction.java URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/InvokeInstruction.java?rev=1746378&r1=1746377&r2=1746378&view=diff ============================================================================== --- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/InvokeInstruction.java (original) +++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/InvokeInstruction.java Wed Jun 1 04:25:27 2016 @@ -43,7 +43,7 @@ public abstract class InvokeInstruction /** * @param index to constant pool */ - protected InvokeInstruction(short opcode, int index) { + protected InvokeInstruction(final short opcode, final int index) { super(opcode, index); } @@ -52,7 +52,7 @@ public abstract class InvokeInstruction * @return mnemonic for instruction with symbolic references resolved */ @Override - public String toString( ConstantPool cp ) { + public String toString( final ConstantPool cp ) { Constant c = cp.getConstant(super.getIndex()); StringTokenizer tok = new StringTokenizer(cp.constantToString(c)); return Const.getOpcodeName(super.getOpcode()) + " " + tok.nextToken().replace('.', '/') @@ -66,7 +66,7 @@ public abstract class InvokeInstruction * @return Number of words consumed from stack by this instruction */ @Override - public int consumeStack( ConstantPoolGen cpg ) { + public int consumeStack( final ConstantPoolGen cpg ) { int sum; if ((super.getOpcode() == Const.INVOKESTATIC) || (super.getOpcode() == Const.INVOKEDYNAMIC)) { sum = 0; @@ -86,7 +86,7 @@ public abstract class InvokeInstruction * @return Number of words produced onto stack by this instruction */ @Override - public int produceStack( ConstantPoolGen cpg ) { + public int produceStack( final ConstantPoolGen cpg ) { String signature = getSignature(cpg); return Type.getReturnTypeSize(signature); } @@ -95,28 +95,28 @@ public abstract class InvokeInstruction /** @return return type of referenced method. */ @Override - public Type getType( ConstantPoolGen cpg ) { + public Type getType( final ConstantPoolGen cpg ) { return getReturnType(cpg); } /** @return name of referenced method. */ - public String getMethodName( ConstantPoolGen cpg ) { + public String getMethodName( final ConstantPoolGen cpg ) { return getName(cpg); } /** @return return type of referenced method. */ - public Type getReturnType( ConstantPoolGen cpg ) { + public Type getReturnType( final ConstantPoolGen cpg ) { return Type.getReturnType(getSignature(cpg)); } /** @return argument types of referenced method. */ - public Type[] getArgumentTypes( ConstantPoolGen cpg ) { + public Type[] getArgumentTypes( final ConstantPoolGen cpg ) { return Type.getArgumentTypes(getSignature(cpg)); } @@ -127,7 +127,7 @@ public abstract class InvokeInstruction * @throws IllegalArgumentException if the referenced class is an array (this should not happen) */ @Override - public String getClassName( ConstantPoolGen cpg ) { + public String getClassName( final ConstantPoolGen cpg ) { ConstantPool cp = cpg.getConstantPool(); ConstantCP cmr = (ConstantCP) cp.getConstant(super.getIndex()); String className = cp.getConstantString(cmr.getClassIndex(), Const.CONSTANT_Class); Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/JSR.java URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/JSR.java?rev=1746378&r1=1746377&r2=1746378&view=diff ============================================================================== --- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/JSR.java (original) +++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/JSR.java Wed Jun 1 04:25:27 2016 @@ -35,7 +35,7 @@ public class JSR extends JsrInstruction } - public JSR(InstructionHandle target) { + public JSR(final InstructionHandle target) { super(org.apache.commons.bcel6.Const.JSR, target); } @@ -45,7 +45,7 @@ public class JSR extends JsrInstruction * @param out Output stream */ @Override - public void dump( DataOutputStream out ) throws IOException { + public void dump( final DataOutputStream out ) throws IOException { super.setIndex(getTargetOffset()); if (super.getOpcode() == org.apache.commons.bcel6.Const.JSR) { super.dump(out); @@ -58,7 +58,7 @@ public class JSR extends JsrInstruction @Override - protected int updatePosition( int offset, int max_offset ) { + protected int updatePosition( final int offset, final int max_offset ) { int i = getTargetOffset(); // Depending on old position value setPosition(getPosition() + offset); // Position may be shifted by preceding expansions if (Math.abs(i) >= (Short.MAX_VALUE - max_offset)) { // to large for short (estimate) @@ -80,7 +80,7 @@ public class JSR extends JsrInstruction * @param v Visitor object */ @Override - public void accept( Visitor v ) { + public void accept( final Visitor v ) { v.visitStackProducer(this); v.visitVariableLengthInstruction(this); v.visitBranchInstruction(this); Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/JSR_W.java URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/JSR_W.java?rev=1746378&r1=1746377&r2=1746378&view=diff ============================================================================== --- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/JSR_W.java (original) +++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/JSR_W.java Wed Jun 1 04:25:27 2016 @@ -37,7 +37,7 @@ public class JSR_W extends JsrInstructio } - public JSR_W(InstructionHandle target) { + public JSR_W(final InstructionHandle target) { super(org.apache.commons.bcel6.Const.JSR_W, target); super.setLength(5); } @@ -48,7 +48,7 @@ public class JSR_W extends JsrInstructio * @param out Output stream */ @Override - public void dump( DataOutputStream out ) throws IOException { + public void dump( final DataOutputStream out ) throws IOException { super.setIndex(getTargetOffset()); out.writeByte(super.getOpcode()); out.writeInt(super.getIndex()); @@ -59,7 +59,7 @@ public class JSR_W extends JsrInstructio * Read needed data (e.g. index) from file. */ @Override - protected void initFromFile( ByteSequence bytes, boolean wide ) throws IOException { + protected void initFromFile( final ByteSequence bytes, final boolean wide ) throws IOException { super.setIndex(bytes.readInt()); super.setLength(5); } @@ -74,7 +74,7 @@ public class JSR_W extends JsrInstructio * @param v Visitor object */ @Override - public void accept( Visitor v ) { + public void accept( final Visitor v ) { v.visitStackProducer(this); v.visitBranchInstruction(this); v.visitJsrInstruction(this); Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/JsrInstruction.java URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/JsrInstruction.java?rev=1746378&r1=1746377&r2=1746378&view=diff ============================================================================== --- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/JsrInstruction.java (original) +++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/JsrInstruction.java Wed Jun 1 04:25:27 2016 @@ -25,7 +25,7 @@ package org.apache.commons.bcel6.generic public abstract class JsrInstruction extends BranchInstruction implements UnconditionalBranch, TypedInstruction, StackProducer { - JsrInstruction(short opcode, InstructionHandle target) { + JsrInstruction(final short opcode, final InstructionHandle target) { super(opcode, target); } @@ -41,7 +41,7 @@ public abstract class JsrInstruction ext /** @return return address type */ @Override - public Type getType( ConstantPoolGen cp ) { + public Type getType( final ConstantPoolGen cp ) { return new ReturnaddressType(physicalSuccessor()); } Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/L2D.java URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/L2D.java?rev=1746378&r1=1746377&r2=1746378&view=diff ============================================================================== --- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/L2D.java (original) +++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/L2D.java Wed Jun 1 04:25:27 2016 @@ -39,7 +39,7 @@ public class L2D extends ConversionInstr * @param v Visitor object */ @Override - public void accept( Visitor v ) { + public void accept( final Visitor v ) { v.visitTypedInstruction(this); v.visitStackProducer(this); v.visitStackConsumer(this); Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/L2F.java URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/L2F.java?rev=1746378&r1=1746377&r2=1746378&view=diff ============================================================================== --- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/L2F.java (original) +++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/L2F.java Wed Jun 1 04:25:27 2016 @@ -39,7 +39,7 @@ public class L2F extends ConversionInstr * @param v Visitor object */ @Override - public void accept( Visitor v ) { + public void accept( final Visitor v ) { v.visitTypedInstruction(this); v.visitStackProducer(this); v.visitStackConsumer(this); Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/L2I.java URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/L2I.java?rev=1746378&r1=1746377&r2=1746378&view=diff ============================================================================== --- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/L2I.java (original) +++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/L2I.java Wed Jun 1 04:25:27 2016 @@ -39,7 +39,7 @@ public class L2I extends ConversionInstr * @param v Visitor object */ @Override - public void accept( Visitor v ) { + public void accept( final Visitor v ) { v.visitTypedInstruction(this); v.visitStackProducer(this); v.visitStackConsumer(this); Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/LADD.java URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/LADD.java?rev=1746378&r1=1746377&r2=1746378&view=diff ============================================================================== --- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/LADD.java (original) +++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/LADD.java Wed Jun 1 04:25:27 2016 @@ -40,7 +40,7 @@ public class LADD extends ArithmeticInst * @param v Visitor object */ @Override - public void accept( Visitor v ) { + public void accept( final Visitor v ) { v.visitTypedInstruction(this); v.visitStackProducer(this); v.visitStackConsumer(this); Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/LALOAD.java URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/LALOAD.java?rev=1746378&r1=1746377&r2=1746378&view=diff ============================================================================== --- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/LALOAD.java (original) +++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/LALOAD.java Wed Jun 1 04:25:27 2016 @@ -41,7 +41,7 @@ public class LALOAD extends ArrayInstruc * @param v Visitor object */ @Override - public void accept( Visitor v ) { + public void accept( final Visitor v ) { v.visitStackProducer(this); v.visitExceptionThrower(this); v.visitTypedInstruction(this); Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/LAND.java URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/LAND.java?rev=1746378&r1=1746377&r2=1746378&view=diff ============================================================================== --- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/LAND.java (original) +++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/LAND.java Wed Jun 1 04:25:27 2016 @@ -40,7 +40,7 @@ public class LAND extends ArithmeticInst * @param v Visitor object */ @Override - public void accept( Visitor v ) { + public void accept( final Visitor v ) { v.visitTypedInstruction(this); v.visitStackProducer(this); v.visitStackConsumer(this); Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/LASTORE.java URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/LASTORE.java?rev=1746378&r1=1746377&r2=1746378&view=diff ============================================================================== --- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/LASTORE.java (original) +++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/LASTORE.java Wed Jun 1 04:25:27 2016 @@ -41,7 +41,7 @@ public class LASTORE extends ArrayInstru * @param v Visitor object */ @Override - public void accept( Visitor v ) { + public void accept( final Visitor v ) { v.visitStackConsumer(this); v.visitExceptionThrower(this); v.visitTypedInstruction(this); Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/LCMP.java URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/LCMP.java?rev=1746378&r1=1746377&r2=1746378&view=diff ============================================================================== --- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/LCMP.java (original) +++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/LCMP.java Wed Jun 1 04:25:27 2016 @@ -34,7 +34,7 @@ public class LCMP extends Instruction im /** @return Type.LONG */ @Override - public Type getType( ConstantPoolGen cp ) { + public Type getType( final ConstantPoolGen cp ) { return Type.LONG; } @@ -48,7 +48,7 @@ public class LCMP extends Instruction im * @param v Visitor object */ @Override - public void accept( Visitor v ) { + public void accept( final Visitor v ) { v.visitTypedInstruction(this); v.visitStackProducer(this); v.visitStackConsumer(this); Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/LCONST.java URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/LCONST.java?rev=1746378&r1=1746377&r2=1746378&view=diff ============================================================================== --- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/LCONST.java (original) +++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/LCONST.java Wed Jun 1 04:25:27 2016 @@ -37,7 +37,7 @@ public class LCONST extends Instruction } - public LCONST(long l) { + public LCONST(final long l) { super(org.apache.commons.bcel6.Const.LCONST_0, (short) 1); if (l == 0) { super.setOpcode(org.apache.commons.bcel6.Const.LCONST_0); @@ -59,7 +59,7 @@ public class LCONST extends Instruction /** @return Type.LONG */ @Override - public Type getType( ConstantPoolGen cp ) { + public Type getType( final ConstantPoolGen cp ) { return Type.LONG; } @@ -73,7 +73,7 @@ public class LCONST extends Instruction * @param v Visitor object */ @Override - public void accept( Visitor v ) { + public void accept( final Visitor v ) { v.visitPushInstruction(this); v.visitStackProducer(this); v.visitTypedInstruction(this); Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/LDC.java URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/LDC.java?rev=1746378&r1=1746377&r2=1746378&view=diff ============================================================================== --- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/LDC.java (original) +++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/LDC.java Wed Jun 1 04:25:27 2016 @@ -40,7 +40,7 @@ public class LDC extends CPInstruction i } - public LDC(int index) { + public LDC(final int index) { super(org.apache.commons.bcel6.Const.LDC_W, index); setSize(); } @@ -63,7 +63,7 @@ public class LDC extends CPInstruction i * @param out Output stream */ @Override - public void dump( DataOutputStream out ) throws IOException { + public void dump( final DataOutputStream out ) throws IOException { out.writeByte(super.getOpcode()); if (super.getLength() == 2) { // TODO useless check? out.writeByte(super.getIndex()); @@ -77,7 +77,7 @@ public class LDC extends CPInstruction i * Set the index to constant pool and adjust size. */ @Override - public final void setIndex( int index ) { + public final void setIndex( final int index ) { super.setIndex(index); setSize(); } @@ -87,13 +87,13 @@ public class LDC extends CPInstruction i * Read needed data (e.g. index) from file. */ @Override - protected void initFromFile( ByteSequence bytes, boolean wide ) throws IOException { + protected void initFromFile( final ByteSequence bytes, final boolean wide ) throws IOException { super.setLength(2); super.setIndex(bytes.readUnsignedByte()); } - public Object getValue( ConstantPoolGen cpg ) { + public Object getValue( final ConstantPoolGen cpg ) { org.apache.commons.bcel6.classfile.Constant c = cpg.getConstantPool().getConstant(super.getIndex()); switch (c.getTag()) { case org.apache.commons.bcel6.Const.CONSTANT_String: @@ -115,7 +115,7 @@ public class LDC extends CPInstruction i @Override - public Type getType( ConstantPoolGen cpg ) { + public Type getType( final ConstantPoolGen cpg ) { switch (cpg.getConstantPool().getConstant(super.getIndex()).getTag()) { case org.apache.commons.bcel6.Const.CONSTANT_String: return Type.STRING; @@ -146,7 +146,7 @@ public class LDC extends CPInstruction i * @param v Visitor object */ @Override - public void accept( Visitor v ) { + public void accept( final Visitor v ) { v.visitStackProducer(this); v.visitPushInstruction(this); v.visitExceptionThrower(this); Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/LDC2_W.java URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/LDC2_W.java?rev=1746378&r1=1746377&r2=1746378&view=diff ============================================================================== --- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/LDC2_W.java (original) +++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/LDC2_W.java Wed Jun 1 04:25:27 2016 @@ -34,13 +34,13 @@ public class LDC2_W extends CPInstructio } - public LDC2_W(int index) { + public LDC2_W(final int index) { super(org.apache.commons.bcel6.Const.LDC2_W, index); } @Override - public Type getType( ConstantPoolGen cpg ) { + public Type getType( final ConstantPoolGen cpg ) { switch (cpg.getConstantPool().getConstant(super.getIndex()).getTag()) { case org.apache.commons.bcel6.Const.CONSTANT_Long: return Type.LONG; @@ -52,7 +52,7 @@ public class LDC2_W extends CPInstructio } - public Number getValue( ConstantPoolGen cpg ) { + public Number getValue( final ConstantPoolGen cpg ) { org.apache.commons.bcel6.classfile.Constant c = cpg.getConstantPool().getConstant(super.getIndex()); switch (c.getTag()) { case org.apache.commons.bcel6.Const.CONSTANT_Long: @@ -74,7 +74,7 @@ public class LDC2_W extends CPInstructio * @param v Visitor object */ @Override - public void accept( Visitor v ) { + public void accept( final Visitor v ) { v.visitStackProducer(this); v.visitPushInstruction(this); v.visitTypedInstruction(this); Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/LDC_W.java URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/LDC_W.java?rev=1746378&r1=1746377&r2=1746378&view=diff ============================================================================== --- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/LDC_W.java (original) +++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/LDC_W.java Wed Jun 1 04:25:27 2016 @@ -38,7 +38,7 @@ public class LDC_W extends LDC { } - public LDC_W(int index) { + public LDC_W(final int index) { super(index); } @@ -47,7 +47,7 @@ public class LDC_W extends LDC { * Read needed data (i.e., index) from file. */ @Override - protected void initFromFile( ByteSequence bytes, boolean wide ) throws IOException { + protected void initFromFile( final ByteSequence bytes, final boolean wide ) throws IOException { setIndex(bytes.readUnsignedShort()); // Override just in case it has been changed super.setOpcode(org.apache.commons.bcel6.Const.LDC_W); Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/LDIV.java URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/LDIV.java?rev=1746378&r1=1746377&r2=1746378&view=diff ============================================================================== --- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/LDIV.java (original) +++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/LDIV.java Wed Jun 1 04:25:27 2016 @@ -50,7 +50,7 @@ public class LDIV extends ArithmeticInst * @param v Visitor object */ @Override - public void accept( Visitor v ) { + public void accept( final Visitor v ) { v.visitExceptionThrower(this); v.visitTypedInstruction(this); v.visitStackProducer(this); Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/LLOAD.java URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/LLOAD.java?rev=1746378&r1=1746377&r2=1746378&view=diff ============================================================================== --- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/LLOAD.java (original) +++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/LLOAD.java Wed Jun 1 04:25:27 2016 @@ -34,7 +34,7 @@ public class LLOAD extends LoadInstructi } - public LLOAD(int n) { + public LLOAD(final int n) { super(org.apache.commons.bcel6.Const.LLOAD, org.apache.commons.bcel6.Const.LLOAD_0, n); } @@ -48,7 +48,7 @@ public class LLOAD extends LoadInstructi * @param v Visitor object */ @Override - public void accept( Visitor v ) { + public void accept( final Visitor v ) { super.accept(v); v.visitLLOAD(this); } Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/LMUL.java URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/LMUL.java?rev=1746378&r1=1746377&r2=1746378&view=diff ============================================================================== --- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/LMUL.java (original) +++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/LMUL.java Wed Jun 1 04:25:27 2016 @@ -40,7 +40,7 @@ public class LMUL extends ArithmeticInst * @param v Visitor object */ @Override - public void accept( Visitor v ) { + public void accept( final Visitor v ) { v.visitTypedInstruction(this); v.visitStackProducer(this); v.visitStackConsumer(this); Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/LNEG.java URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/LNEG.java?rev=1746378&r1=1746377&r2=1746378&view=diff ============================================================================== --- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/LNEG.java (original) +++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/LNEG.java Wed Jun 1 04:25:27 2016 @@ -39,7 +39,7 @@ public class LNEG extends ArithmeticInst * @param v Visitor object */ @Override - public void accept( Visitor v ) { + public void accept( final Visitor v ) { v.visitTypedInstruction(this); v.visitStackProducer(this); v.visitStackConsumer(this); Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/LOOKUPSWITCH.java URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/LOOKUPSWITCH.java?rev=1746378&r1=1746377&r2=1746378&view=diff ============================================================================== --- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/LOOKUPSWITCH.java (original) +++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/LOOKUPSWITCH.java Wed Jun 1 04:25:27 2016 @@ -38,7 +38,7 @@ public class LOOKUPSWITCH extends Select } - public LOOKUPSWITCH(int[] match, InstructionHandle[] targets, InstructionHandle defaultTarget) { + public LOOKUPSWITCH(final int[] match, final InstructionHandle[] targets, final InstructionHandle defaultTarget) { super(org.apache.commons.bcel6.Const.LOOKUPSWITCH, match, targets, defaultTarget); /* alignment remainder assumed 0 here, until dump time. */ final short _length = (short) (9 + getMatch_length() * 8); @@ -52,7 +52,7 @@ public class LOOKUPSWITCH extends Select * @param out Output stream */ @Override - public void dump( DataOutputStream out ) throws IOException { + public void dump( final DataOutputStream out ) throws IOException { super.dump(out); final int _match_length = getMatch_length(); out.writeInt(_match_length); // npairs @@ -67,7 +67,7 @@ public class LOOKUPSWITCH extends Select * Read needed data (e.g. index) from file. */ @Override - protected void initFromFile( ByteSequence bytes, boolean wide ) throws IOException { + protected void initFromFile( final ByteSequence bytes, final boolean wide ) throws IOException { super.initFromFile(bytes, wide); // reads padding final int _match_length = bytes.readInt(); setMatch_length(_match_length); @@ -94,7 +94,7 @@ public class LOOKUPSWITCH extends Select * @param v Visitor object */ @Override - public void accept( Visitor v ) { + public void accept( final Visitor v ) { v.visitVariableLengthInstruction(this); v.visitStackConsumer(this); v.visitBranchInstruction(this); Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/LOR.java URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/LOR.java?rev=1746378&r1=1746377&r2=1746378&view=diff ============================================================================== --- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/LOR.java (original) +++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/LOR.java Wed Jun 1 04:25:27 2016 @@ -39,7 +39,7 @@ public class LOR extends ArithmeticInstr * @param v Visitor object */ @Override - public void accept( Visitor v ) { + public void accept( final Visitor v ) { v.visitTypedInstruction(this); v.visitStackProducer(this); v.visitStackConsumer(this); Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/LREM.java URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/LREM.java?rev=1746378&r1=1746377&r2=1746378&view=diff ============================================================================== --- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/LREM.java (original) +++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/LREM.java Wed Jun 1 04:25:27 2016 @@ -49,7 +49,7 @@ public class LREM extends ArithmeticInst * @param v Visitor object */ @Override - public void accept( Visitor v ) { + public void accept( final Visitor v ) { v.visitExceptionThrower(this); v.visitTypedInstruction(this); v.visitStackProducer(this); Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/LRETURN.java URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/LRETURN.java?rev=1746378&r1=1746377&r2=1746378&view=diff ============================================================================== --- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/LRETURN.java (original) +++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/LRETURN.java Wed Jun 1 04:25:27 2016 @@ -39,7 +39,7 @@ public class LRETURN extends ReturnInstr * @param v Visitor object */ @Override - public void accept( Visitor v ) { + public void accept( final Visitor v ) { v.visitExceptionThrower(this); v.visitTypedInstruction(this); v.visitStackConsumer(this); Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/LSHL.java URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/LSHL.java?rev=1746378&r1=1746377&r2=1746378&view=diff ============================================================================== --- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/LSHL.java (original) +++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/LSHL.java Wed Jun 1 04:25:27 2016 @@ -39,7 +39,7 @@ public class LSHL extends ArithmeticInst * @param v Visitor object */ @Override - public void accept( Visitor v ) { + public void accept( final Visitor v ) { v.visitTypedInstruction(this); v.visitStackProducer(this); v.visitStackConsumer(this); Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/LSHR.java URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/LSHR.java?rev=1746378&r1=1746377&r2=1746378&view=diff ============================================================================== --- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/LSHR.java (original) +++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/LSHR.java Wed Jun 1 04:25:27 2016 @@ -39,7 +39,7 @@ public class LSHR extends ArithmeticInst * @param v Visitor object */ @Override - public void accept( Visitor v ) { + public void accept( final Visitor v ) { v.visitTypedInstruction(this); v.visitStackProducer(this); v.visitStackConsumer(this); Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/LSTORE.java URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/LSTORE.java?rev=1746378&r1=1746377&r2=1746378&view=diff ============================================================================== --- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/LSTORE.java (original) +++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/LSTORE.java Wed Jun 1 04:25:27 2016 @@ -34,7 +34,7 @@ public class LSTORE extends StoreInstruc } - public LSTORE(int n) { + public LSTORE(final int n) { super(org.apache.commons.bcel6.Const.LSTORE, org.apache.commons.bcel6.Const.LSTORE_0, n); } @@ -48,7 +48,7 @@ public class LSTORE extends StoreInstruc * @param v Visitor object */ @Override - public void accept( Visitor v ) { + public void accept( final Visitor v ) { super.accept(v); v.visitLSTORE(this); } Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/LSUB.java URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/LSUB.java?rev=1746378&r1=1746377&r2=1746378&view=diff ============================================================================== --- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/LSUB.java (original) +++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/LSUB.java Wed Jun 1 04:25:27 2016 @@ -40,7 +40,7 @@ public class LSUB extends ArithmeticInst * @param v Visitor object */ @Override - public void accept( Visitor v ) { + public void accept( final Visitor v ) { v.visitTypedInstruction(this); v.visitStackProducer(this); v.visitStackConsumer(this); Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/LUSHR.java URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/LUSHR.java?rev=1746378&r1=1746377&r2=1746378&view=diff ============================================================================== --- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/LUSHR.java (original) +++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/LUSHR.java Wed Jun 1 04:25:27 2016 @@ -39,7 +39,7 @@ public class LUSHR extends ArithmeticIns * @param v Visitor object */ @Override - public void accept( Visitor v ) { + public void accept( final Visitor v ) { v.visitTypedInstruction(this); v.visitStackProducer(this); v.visitStackConsumer(this); Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/LXOR.java URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/LXOR.java?rev=1746378&r1=1746377&r2=1746378&view=diff ============================================================================== --- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/LXOR.java (original) +++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/LXOR.java Wed Jun 1 04:25:27 2016 @@ -39,7 +39,7 @@ public class LXOR extends ArithmeticInst * @param v Visitor object */ @Override - public void accept( Visitor v ) { + public void accept( final Visitor v ) { v.visitTypedInstruction(this); v.visitStackProducer(this); v.visitStackConsumer(this); Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/LineNumberGen.java URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/LineNumberGen.java?rev=1746378&r1=1746377&r2=1746378&view=diff ============================================================================== --- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/LineNumberGen.java (original) +++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/LineNumberGen.java Wed Jun 1 04:25:27 2016 @@ -38,7 +38,7 @@ public class LineNumberGen implements In * * @param ih instruction handle to reference */ - public LineNumberGen(InstructionHandle ih, int src_line) { + public LineNumberGen(final InstructionHandle ih, final int src_line) { setInstruction(ih); setSourceLine(src_line); } @@ -48,7 +48,7 @@ public class LineNumberGen implements In * @return true, if ih is target of this line number */ @Override - public boolean containsTarget( InstructionHandle ih ) { + public boolean containsTarget( final InstructionHandle ih ) { return this.ih == ih; } @@ -58,7 +58,7 @@ public class LineNumberGen implements In * @param new_ih new target */ @Override - public void updateTarget( InstructionHandle old_ih, InstructionHandle new_ih ) { + public void updateTarget( final InstructionHandle old_ih, final InstructionHandle new_ih ) { if (old_ih != ih) { throw new ClassGenException("Not targeting " + old_ih + ", but " + ih + "}"); } @@ -77,7 +77,7 @@ public class LineNumberGen implements In } - public void setInstruction( InstructionHandle ih ) { // TODO could be package-protected? + public void setInstruction( final InstructionHandle ih ) { // TODO could be package-protected? if (ih == null) { throw new NullPointerException("InstructionHandle may not be null"); } @@ -101,7 +101,7 @@ public class LineNumberGen implements In } - public void setSourceLine( int src_line ) { // TODO could be package-protected? + public void setSourceLine( final int src_line ) { // TODO could be package-protected? this.src_line = src_line; } Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/LoadInstruction.java URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/LoadInstruction.java?rev=1746378&r1=1746377&r2=1746378&view=diff ============================================================================== --- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/LoadInstruction.java (original) +++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/LoadInstruction.java Wed Jun 1 04:25:27 2016 @@ -30,7 +30,7 @@ public abstract class LoadInstruction ex * Instruction.readInstruction(). Not to be used otherwise. * tag and length are defined in readInstruction and initFromFile, respectively. */ - LoadInstruction(short canon_tag, short c_tag) { + LoadInstruction(final short canon_tag, final short c_tag) { super(canon_tag, c_tag); } @@ -40,7 +40,7 @@ public abstract class LoadInstruction ex * @param c_tag Instruction number for compact version, ALOAD_0, e.g. * @param n local variable index (unsigned short) */ - protected LoadInstruction(short opcode, short c_tag, int n) { + protected LoadInstruction(final short opcode, final short c_tag, final int n) { super(opcode, c_tag, n); } @@ -54,7 +54,7 @@ public abstract class LoadInstruction ex * @param v Visitor object */ @Override - public void accept( Visitor v ) { + public void accept( final Visitor v ) { v.visitStackProducer(this); v.visitPushInstruction(this); v.visitTypedInstruction(this);
