Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/CodeException.java URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/CodeException.java?rev=1746378&r1=1746377&r2=1746378&view=diff ============================================================================== --- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/CodeException.java (original) +++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/CodeException.java Wed Jun 1 04:25:27 2016 @@ -47,7 +47,7 @@ public final class CodeException impleme /** * Initialize from another object. */ - public CodeException(CodeException c) { + public CodeException(final CodeException c) { this(c.getStartPC(), c.getEndPC(), c.getHandlerPC(), c.getCatchType()); } @@ -57,7 +57,7 @@ public final class CodeException impleme * @param file Input stream * @throws IOException */ - CodeException(DataInput file) throws IOException { + CodeException(final DataInput file) throws IOException { this(file.readUnsignedShort(), file.readUnsignedShort(), file.readUnsignedShort(), file .readUnsignedShort()); } @@ -73,7 +73,7 @@ public final class CodeException impleme * exception, otherwise it points to the exception class which is * to be caught. */ - public CodeException(int start_pc, int end_pc, int handler_pc, int catch_type) { + public CodeException(final int start_pc, final int end_pc, final int handler_pc, final int catch_type) { this.start_pc = start_pc; this.end_pc = end_pc; this.handler_pc = handler_pc; @@ -89,7 +89,7 @@ public final class CodeException impleme * @param v Visitor object */ @Override - public void accept( Visitor v ) { + public void accept( final Visitor v ) { v.visitCodeException(this); } @@ -100,7 +100,7 @@ public final class CodeException impleme * @param file Output file stream * @throws IOException */ - public final void dump( DataOutputStream file ) throws IOException { + public final void dump( final DataOutputStream file ) throws IOException { file.writeShort(start_pc); file.writeShort(end_pc); file.writeShort(handler_pc); @@ -144,7 +144,7 @@ public final class CodeException impleme /** * @param catch_type the type of exception that is caught */ - public final void setCatchType( int catch_type ) { + public final void setCatchType( final int catch_type ) { this.catch_type = catch_type; } @@ -152,7 +152,7 @@ public final class CodeException impleme /** * @param end_pc end of handled block */ - public final void setEndPC( int end_pc ) { + public final void setEndPC( final int end_pc ) { this.end_pc = end_pc; } @@ -160,7 +160,7 @@ public final class CodeException impleme /** * @param handler_pc where the actual code is */ - public final void setHandlerPC( int handler_pc ) { // TODO unused + public final void setHandlerPC( final int handler_pc ) { // TODO unused this.handler_pc = handler_pc; } @@ -168,7 +168,7 @@ public final class CodeException impleme /** * @param start_pc start of handled block */ - public final void setStartPC( int start_pc ) { // TODO unused + public final void setStartPC( final int start_pc ) { // TODO unused this.start_pc = start_pc; } @@ -186,7 +186,7 @@ public final class CodeException impleme /** * @return String representation. */ - public final String toString( ConstantPool cp, boolean verbose ) { + public final String toString( final ConstantPool cp, final boolean verbose ) { String str; if (catch_type == 0) { str = "<Any exception>(0)"; @@ -198,7 +198,7 @@ public final class CodeException impleme } - public final String toString( ConstantPool cp ) { + public final String toString( final ConstantPool cp ) { return toString(cp, true); }
Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/Constant.java URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/Constant.java?rev=1746378&r1=1746377&r2=1746378&view=diff ============================================================================== --- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/Constant.java (original) +++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/Constant.java Wed Jun 1 04:25:27 2016 @@ -36,7 +36,7 @@ public abstract class Constant implement private static BCELComparator _cmp = new BCELComparator() { @Override - public boolean equals( Object o1, Object o2 ) { + public boolean equals( final Object o1, final Object o2 ) { Constant THIS = (Constant) o1; Constant THAT = (Constant) o2; return THIS.toString().equals(THAT.toString()); @@ -44,7 +44,7 @@ public abstract class Constant implement @Override - public int hashCode( Object o ) { + public int hashCode( final Object o ) { Constant THIS = (Constant) o; return THIS.toString().hashCode(); } @@ -64,7 +64,7 @@ public abstract class Constant implement protected byte tag; // TODO should be private & final - Constant(byte tag) { + Constant(final byte tag) { this.tag = tag; } @@ -131,7 +131,7 @@ public abstract class Constant implement * @return Constant object * @since 6.0 made public */ - public static Constant readConstant( DataInput input ) throws IOException, + public static Constant readConstant( final DataInput input ) throws IOException, ClassFormatException { byte b = input.readByte(); // Read tag byte switch (b) { @@ -180,7 +180,7 @@ public abstract class Constant implement /** * @param comparator Comparison strategy object */ - public static void setComparator( BCELComparator comparator ) { + public static void setComparator( final BCELComparator comparator ) { _cmp = comparator; } @@ -193,7 +193,7 @@ public abstract class Constant implement * @see java.lang.Object#equals(java.lang.Object) */ @Override - public boolean equals( Object obj ) { + public boolean equals( final Object obj ) { return _cmp.equals(this, obj); } Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ConstantCP.java URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ConstantCP.java?rev=1746378&r1=1746377&r2=1746378&view=diff ============================================================================== --- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ConstantCP.java (original) +++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ConstantCP.java Wed Jun 1 04:25:27 2016 @@ -56,7 +56,7 @@ public abstract class ConstantCP extends /** * Initialize from another object. */ - public ConstantCP(ConstantCP c) { + public ConstantCP(final ConstantCP c) { this(c.getTag(), c.getClassIndex(), c.getNameAndTypeIndex()); } @@ -68,7 +68,7 @@ public abstract class ConstantCP extends * @param file Input stream * @throws IOException */ - ConstantCP(byte tag, DataInput file) throws IOException { + ConstantCP(final byte tag, final DataInput file) throws IOException { this(tag, file.readUnsignedShort(), file.readUnsignedShort()); } @@ -77,7 +77,7 @@ public abstract class ConstantCP extends * @param class_index Reference to the class containing the field * @param name_and_type_index and the field signature */ - protected ConstantCP(byte tag, int class_index, int name_and_type_index) { + protected ConstantCP(final byte tag, final int class_index, final int name_and_type_index) { super(tag); this.class_index = class_index; this.name_and_type_index = name_and_type_index; @@ -91,7 +91,7 @@ public abstract class ConstantCP extends * @throws IOException */ @Override - public final void dump( DataOutputStream file ) throws IOException { + public final void dump( final DataOutputStream file ) throws IOException { file.writeByte(super.getTag()); file.writeShort(class_index); file.writeShort(name_and_type_index); @@ -109,7 +109,7 @@ public abstract class ConstantCP extends /** * @param class_index points to Constant_class */ - public final void setClassIndex( int class_index ) { + public final void setClassIndex( final int class_index ) { this.class_index = class_index; } @@ -125,7 +125,7 @@ public abstract class ConstantCP extends /** * @param name_and_type_index points to Constant_NameAndType */ - public final void setNameAndTypeIndex( int name_and_type_index ) { + public final void setNameAndTypeIndex( final int name_and_type_index ) { this.name_and_type_index = name_and_type_index; } @@ -133,7 +133,7 @@ public abstract class ConstantCP extends /** * @return Class this field belongs to. */ - public String getClass( ConstantPool cp ) { + public String getClass( final ConstantPool cp ) { return cp.constantToString(class_index, Const.CONSTANT_Class); } Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ConstantClass.java URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ConstantClass.java?rev=1746378&r1=1746377&r2=1746378&view=diff ============================================================================== --- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ConstantClass.java (original) +++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ConstantClass.java Wed Jun 1 04:25:27 2016 @@ -38,7 +38,7 @@ public final class ConstantClass extends /** * Initialize from another object. */ - public ConstantClass(ConstantClass c) { + public ConstantClass(final ConstantClass c) { this(c.getNameIndex()); } @@ -49,7 +49,7 @@ public final class ConstantClass extends * @param file Input stream * @throws IOException */ - ConstantClass(DataInput file) throws IOException { + ConstantClass(final DataInput file) throws IOException { this(file.readUnsignedShort()); } @@ -58,7 +58,7 @@ public final class ConstantClass extends * @param name_index Name index in constant pool. Should refer to a * ConstantUtf8. */ - public ConstantClass(int name_index) { + public ConstantClass(final int name_index) { super(Const.CONSTANT_Class); this.name_index = name_index; } @@ -72,7 +72,7 @@ public final class ConstantClass extends * @param v Visitor object */ @Override - public void accept( Visitor v ) { + public void accept( final Visitor v ) { v.visitConstantClass(this); } @@ -84,7 +84,7 @@ public final class ConstantClass extends * @throws IOException */ @Override - public final void dump( DataOutputStream file ) throws IOException { + public final void dump( final DataOutputStream file ) throws IOException { file.writeByte(super.getTag()); file.writeShort(name_index); } @@ -101,7 +101,7 @@ public final class ConstantClass extends /** * @param name_index the name index in the constant pool of this Constant Class */ - public final void setNameIndex( int name_index ) { + public final void setNameIndex( final int name_index ) { this.name_index = name_index; } @@ -109,7 +109,7 @@ public final class ConstantClass extends /** @return String object */ @Override - public Object getConstantValue( ConstantPool cp ) { + public Object getConstantValue( final ConstantPool cp ) { Constant c = cp.getConstant(name_index, Const.CONSTANT_Utf8); return ((ConstantUtf8) c).getBytes(); } @@ -117,7 +117,7 @@ public final class ConstantClass extends /** @return dereferenced string */ - public String getBytes( ConstantPool cp ) { + public String getBytes( final ConstantPool cp ) { return (String) getConstantValue(cp); } Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ConstantDouble.java URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ConstantDouble.java?rev=1746378&r1=1746377&r2=1746378&view=diff ============================================================================== --- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ConstantDouble.java (original) +++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ConstantDouble.java Wed Jun 1 04:25:27 2016 @@ -38,7 +38,7 @@ public final class ConstantDouble extend /** * @param bytes Data */ - public ConstantDouble(double bytes) { + public ConstantDouble(final double bytes) { super(Const.CONSTANT_Double); this.bytes = bytes; } @@ -47,7 +47,7 @@ public final class ConstantDouble extend /** * Initialize from another object. */ - public ConstantDouble(ConstantDouble c) { + public ConstantDouble(final ConstantDouble c) { this(c.getBytes()); } @@ -58,7 +58,7 @@ public final class ConstantDouble extend * @param file Input stream * @throws IOException */ - ConstantDouble(DataInput file) throws IOException { + ConstantDouble(final DataInput file) throws IOException { this(file.readDouble()); } @@ -71,7 +71,7 @@ public final class ConstantDouble extend * @param v Visitor object */ @Override - public void accept( Visitor v ) { + public void accept( final Visitor v ) { v.visitConstantDouble(this); } @@ -83,7 +83,7 @@ public final class ConstantDouble extend * @throws IOException */ @Override - public final void dump( DataOutputStream file ) throws IOException { + public final void dump( final DataOutputStream file ) throws IOException { file.writeByte(super.getTag()); file.writeDouble(bytes); } @@ -100,7 +100,7 @@ public final class ConstantDouble extend /** * @param bytes the raw bytes that represent the double value */ - public final void setBytes( double bytes ) { + public final void setBytes( final double bytes ) { this.bytes = bytes; } @@ -117,7 +117,7 @@ public final class ConstantDouble extend /** @return Double object */ @Override - public Object getConstantValue( ConstantPool cp ) { + public Object getConstantValue( final ConstantPool cp ) { return new Double(bytes); } } Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ConstantFieldref.java URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ConstantFieldref.java?rev=1746378&r1=1746377&r2=1746378&view=diff ============================================================================== --- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ConstantFieldref.java (original) +++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ConstantFieldref.java Wed Jun 1 04:25:27 2016 @@ -32,7 +32,7 @@ public final class ConstantFieldref exte /** * Initialize from another object. */ - public ConstantFieldref(ConstantFieldref c) { + public ConstantFieldref(final ConstantFieldref c) { super(Const.CONSTANT_Fieldref, c.getClassIndex(), c.getNameAndTypeIndex()); } @@ -43,7 +43,7 @@ public final class ConstantFieldref exte * @param input input stream * @throws IOException */ - ConstantFieldref(DataInput input) throws IOException { + ConstantFieldref(final DataInput input) throws IOException { super(Const.CONSTANT_Fieldref, input); } @@ -52,7 +52,7 @@ public final class ConstantFieldref exte * @param class_index Reference to the class containing the Field * @param name_and_type_index and the Field signature */ - public ConstantFieldref(int class_index, int name_and_type_index) { + public ConstantFieldref(final int class_index, final int name_and_type_index) { super(Const.CONSTANT_Fieldref, class_index, name_and_type_index); } @@ -65,7 +65,7 @@ public final class ConstantFieldref exte * @param v Visitor object */ @Override - public void accept( Visitor v ) { + public void accept( final Visitor v ) { v.visitConstantFieldref(this); } } Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ConstantFloat.java URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ConstantFloat.java?rev=1746378&r1=1746377&r2=1746378&view=diff ============================================================================== --- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ConstantFloat.java (original) +++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ConstantFloat.java Wed Jun 1 04:25:27 2016 @@ -38,7 +38,7 @@ public final class ConstantFloat extends /** * @param bytes Data */ - public ConstantFloat(float bytes) { + public ConstantFloat(final float bytes) { super(Const.CONSTANT_Float); this.bytes = bytes; } @@ -48,7 +48,7 @@ public final class ConstantFloat extends * Initialize from another object. Note that both objects use the same * references (shallow copy). Use clone() for a physical copy. */ - public ConstantFloat(ConstantFloat c) { + public ConstantFloat(final ConstantFloat c) { this(c.getBytes()); } @@ -59,7 +59,7 @@ public final class ConstantFloat extends * @param file Input stream * @throws IOException */ - ConstantFloat(DataInput file) throws IOException { + ConstantFloat(final DataInput file) throws IOException { this(file.readFloat()); } @@ -72,7 +72,7 @@ public final class ConstantFloat extends * @param v Visitor object */ @Override - public void accept( Visitor v ) { + public void accept( final Visitor v ) { v.visitConstantFloat(this); } @@ -84,7 +84,7 @@ public final class ConstantFloat extends * @throws IOException */ @Override - public final void dump( DataOutputStream file ) throws IOException { + public final void dump( final DataOutputStream file ) throws IOException { file.writeByte(super.getTag()); file.writeFloat(bytes); } @@ -101,7 +101,7 @@ public final class ConstantFloat extends /** * @param bytes the raw bytes that represent this float */ - public final void setBytes( float bytes ) { + public final void setBytes( final float bytes ) { this.bytes = bytes; } @@ -118,7 +118,7 @@ public final class ConstantFloat extends /** @return Float object */ @Override - public Object getConstantValue( ConstantPool cp ) { + public Object getConstantValue( final ConstantPool cp ) { return new Float(bytes); } } Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ConstantInteger.java URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ConstantInteger.java?rev=1746378&r1=1746377&r2=1746378&view=diff ============================================================================== --- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ConstantInteger.java (original) +++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ConstantInteger.java Wed Jun 1 04:25:27 2016 @@ -38,7 +38,7 @@ public final class ConstantInteger exten /** * @param bytes Data */ - public ConstantInteger(int bytes) { + public ConstantInteger(final int bytes) { super(Const.CONSTANT_Integer); this.bytes = bytes; } @@ -47,7 +47,7 @@ public final class ConstantInteger exten /** * Initialize from another object. */ - public ConstantInteger(ConstantInteger c) { + public ConstantInteger(final ConstantInteger c) { this(c.getBytes()); } @@ -58,7 +58,7 @@ public final class ConstantInteger exten * @param file Input stream * @throws IOException */ - ConstantInteger(DataInput file) throws IOException { + ConstantInteger(final DataInput file) throws IOException { this(file.readInt()); } @@ -71,7 +71,7 @@ public final class ConstantInteger exten * @param v Visitor object */ @Override - public void accept( Visitor v ) { + public void accept( final Visitor v ) { v.visitConstantInteger(this); } @@ -83,7 +83,7 @@ public final class ConstantInteger exten * @throws IOException */ @Override - public final void dump( DataOutputStream file ) throws IOException { + public final void dump( final DataOutputStream file ) throws IOException { file.writeByte(super.getTag()); file.writeInt(bytes); } @@ -100,7 +100,7 @@ public final class ConstantInteger exten /** * @param bytes the raw bytes that represent this integer */ - public final void setBytes( int bytes ) { + public final void setBytes( final int bytes ) { this.bytes = bytes; } @@ -117,7 +117,7 @@ public final class ConstantInteger exten /** @return Integer object */ @Override - public Object getConstantValue( ConstantPool cp ) { + public Object getConstantValue( final ConstantPool cp ) { return Integer.valueOf(bytes); } } Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ConstantInterfaceMethodref.java URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ConstantInterfaceMethodref.java?rev=1746378&r1=1746377&r2=1746378&view=diff ============================================================================== --- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ConstantInterfaceMethodref.java (original) +++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ConstantInterfaceMethodref.java Wed Jun 1 04:25:27 2016 @@ -32,7 +32,7 @@ public final class ConstantInterfaceMeth /** * Initialize from another object. */ - public ConstantInterfaceMethodref(ConstantInterfaceMethodref c) { + public ConstantInterfaceMethodref(final ConstantInterfaceMethodref c) { super(Const.CONSTANT_InterfaceMethodref, c.getClassIndex(), c.getNameAndTypeIndex()); } @@ -43,7 +43,7 @@ public final class ConstantInterfaceMeth * @param input input stream * @throws IOException */ - ConstantInterfaceMethodref(DataInput input) throws IOException { + ConstantInterfaceMethodref(final DataInput input) throws IOException { super(Const.CONSTANT_InterfaceMethodref, input); } @@ -52,7 +52,7 @@ public final class ConstantInterfaceMeth * @param class_index Reference to the class containing the method * @param name_and_type_index and the method signature */ - public ConstantInterfaceMethodref(int class_index, int name_and_type_index) { + public ConstantInterfaceMethodref(final int class_index, final int name_and_type_index) { super(Const.CONSTANT_InterfaceMethodref, class_index, name_and_type_index); } @@ -65,7 +65,7 @@ public final class ConstantInterfaceMeth * @param v Visitor object */ @Override - public void accept( Visitor v ) { + public void accept( final Visitor v ) { v.visitConstantInterfaceMethodref(this); } } Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ConstantInvokeDynamic.java URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ConstantInvokeDynamic.java?rev=1746378&r1=1746377&r2=1746378&view=diff ============================================================================== --- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ConstantInvokeDynamic.java (original) +++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ConstantInvokeDynamic.java Wed Jun 1 04:25:27 2016 @@ -36,7 +36,7 @@ public final class ConstantInvokeDynamic /** * Initialize from another object. */ - public ConstantInvokeDynamic(ConstantInvokeDynamic c) { + public ConstantInvokeDynamic(final ConstantInvokeDynamic c) { this(c.getBootstrapMethodAttrIndex(), c.getNameAndTypeIndex()); } @@ -47,12 +47,12 @@ public final class ConstantInvokeDynamic * @param file Input stream * @throws IOException */ - ConstantInvokeDynamic(DataInput file) throws IOException { + ConstantInvokeDynamic(final DataInput file) throws IOException { this(file.readShort(), file.readShort()); } - public ConstantInvokeDynamic(int bootstrap_method_attr_index, int name_and_type_index) { + public ConstantInvokeDynamic(final int bootstrap_method_attr_index, final int name_and_type_index) { super(Const.CONSTANT_InvokeDynamic, bootstrap_method_attr_index, name_and_type_index); } @@ -65,7 +65,7 @@ public final class ConstantInvokeDynamic * @param v Visitor object */ @Override - public void accept( Visitor v ) { + public void accept( final Visitor v ) { v.visitConstantInvokeDynamic(this); } Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ConstantLong.java URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ConstantLong.java?rev=1746378&r1=1746377&r2=1746378&view=diff ============================================================================== --- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ConstantLong.java (original) +++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ConstantLong.java Wed Jun 1 04:25:27 2016 @@ -38,7 +38,7 @@ public final class ConstantLong extends /** * @param bytes Data */ - public ConstantLong(long bytes) { + public ConstantLong(final long bytes) { super(Const.CONSTANT_Long); this.bytes = bytes; } @@ -47,7 +47,7 @@ public final class ConstantLong extends /** * Initialize from another object. */ - public ConstantLong(ConstantLong c) { + public ConstantLong(final ConstantLong c) { this(c.getBytes()); } @@ -58,7 +58,7 @@ public final class ConstantLong extends * @param file Input stream * @throws IOException */ - ConstantLong(DataInput file) throws IOException { + ConstantLong(final DataInput file) throws IOException { this(file.readLong()); } @@ -71,7 +71,7 @@ public final class ConstantLong extends * @param v Visitor object */ @Override - public void accept( Visitor v ) { + public void accept( final Visitor v ) { v.visitConstantLong(this); } @@ -83,7 +83,7 @@ public final class ConstantLong extends * @throws IOException */ @Override - public final void dump( DataOutputStream file ) throws IOException { + public final void dump( final DataOutputStream file ) throws IOException { file.writeByte(super.getTag()); file.writeLong(bytes); } @@ -100,7 +100,7 @@ public final class ConstantLong extends /** * @param bytes the raw bytes that represent this long */ - public final void setBytes( long bytes ) { + public final void setBytes( final long bytes ) { this.bytes = bytes; } @@ -117,7 +117,7 @@ public final class ConstantLong extends /** @return Long object */ @Override - public Object getConstantValue( ConstantPool cp ) { + public Object getConstantValue( final ConstantPool cp ) { return Long.valueOf(bytes); } } Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ConstantMethodHandle.java URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ConstantMethodHandle.java?rev=1746378&r1=1746377&r2=1746378&view=diff ============================================================================== --- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ConstantMethodHandle.java (original) +++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ConstantMethodHandle.java Wed Jun 1 04:25:27 2016 @@ -39,7 +39,7 @@ public final class ConstantMethodHandle /** * Initialize from another object. */ - public ConstantMethodHandle(ConstantMethodHandle c) { + public ConstantMethodHandle(final ConstantMethodHandle c) { this(c.getReferenceKind(), c.getReferenceIndex()); } @@ -50,12 +50,12 @@ public final class ConstantMethodHandle * @param file Input stream * @throws IOException */ - ConstantMethodHandle(DataInput file) throws IOException { + ConstantMethodHandle(final DataInput file) throws IOException { this(file.readUnsignedByte(), file.readUnsignedShort()); } - public ConstantMethodHandle(int reference_kind, int reference_index) { + public ConstantMethodHandle(final int reference_kind, final int reference_index) { super(Const.CONSTANT_MethodHandle); this.reference_kind = reference_kind; this.reference_index = reference_index; @@ -70,7 +70,7 @@ public final class ConstantMethodHandle * @param v Visitor object */ @Override - public void accept( Visitor v ) { + public void accept( final Visitor v ) { v.visitConstantMethodHandle(this); } @@ -82,7 +82,7 @@ public final class ConstantMethodHandle * @throws IOException */ @Override - public final void dump( DataOutputStream file ) throws IOException { + public final void dump( final DataOutputStream file ) throws IOException { file.writeByte(super.getTag()); file.writeByte(reference_kind); file.writeShort(reference_index); @@ -94,7 +94,7 @@ public final class ConstantMethodHandle } - public void setReferenceKind(int reference_kind) { + public void setReferenceKind(final int reference_kind) { this.reference_kind = reference_kind; } @@ -104,7 +104,7 @@ public final class ConstantMethodHandle } - public void setReferenceIndex(int reference_index) { + public void setReferenceIndex(final int reference_index) { this.reference_index = reference_index; } Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ConstantMethodType.java URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ConstantMethodType.java?rev=1746378&r1=1746377&r2=1746378&view=diff ============================================================================== --- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ConstantMethodType.java (original) +++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ConstantMethodType.java Wed Jun 1 04:25:27 2016 @@ -38,7 +38,7 @@ public final class ConstantMethodType ex /** * Initialize from another object. */ - public ConstantMethodType(ConstantMethodType c) { + public ConstantMethodType(final ConstantMethodType c) { this(c.getDescriptorIndex()); } @@ -49,12 +49,12 @@ public final class ConstantMethodType ex * @param file Input stream * @throws IOException */ - ConstantMethodType(DataInput file) throws IOException { + ConstantMethodType(final DataInput file) throws IOException { this(file.readUnsignedShort()); } - public ConstantMethodType(int descriptor_index) { + public ConstantMethodType(final int descriptor_index) { super(Const.CONSTANT_MethodType); this.descriptor_index = descriptor_index; } @@ -68,7 +68,7 @@ public final class ConstantMethodType ex * @param v Visitor object */ @Override - public void accept( Visitor v ) { + public void accept( final Visitor v ) { v.visitConstantMethodType(this); } @@ -80,7 +80,7 @@ public final class ConstantMethodType ex * @throws IOException */ @Override - public final void dump( DataOutputStream file ) throws IOException { + public final void dump( final DataOutputStream file ) throws IOException { file.writeByte(super.getTag()); file.writeShort(descriptor_index); } @@ -91,7 +91,7 @@ public final class ConstantMethodType ex } - public void setDescriptorIndex(int descriptor_index) { + public void setDescriptorIndex(final int descriptor_index) { this.descriptor_index = descriptor_index; } Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ConstantMethodref.java URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ConstantMethodref.java?rev=1746378&r1=1746377&r2=1746378&view=diff ============================================================================== --- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ConstantMethodref.java (original) +++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ConstantMethodref.java Wed Jun 1 04:25:27 2016 @@ -32,7 +32,7 @@ public final class ConstantMethodref ext /** * Initialize from another object. */ - public ConstantMethodref(ConstantMethodref c) { + public ConstantMethodref(final ConstantMethodref c) { super(Const.CONSTANT_Methodref, c.getClassIndex(), c.getNameAndTypeIndex()); } @@ -43,7 +43,7 @@ public final class ConstantMethodref ext * @param input input stream * @throws IOException */ - ConstantMethodref(DataInput input) throws IOException { + ConstantMethodref(final DataInput input) throws IOException { super(Const.CONSTANT_Methodref, input); } @@ -52,7 +52,7 @@ public final class ConstantMethodref ext * @param class_index Reference to the class containing the method * @param name_and_type_index and the method signature */ - public ConstantMethodref(int class_index, int name_and_type_index) { + public ConstantMethodref(final int class_index, final int name_and_type_index) { super(Const.CONSTANT_Methodref, class_index, name_and_type_index); } @@ -65,7 +65,7 @@ public final class ConstantMethodref ext * @param v Visitor object */ @Override - public void accept( Visitor v ) { + public void accept( final Visitor v ) { v.visitConstantMethodref(this); } } Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ConstantNameAndType.java URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ConstantNameAndType.java?rev=1746378&r1=1746377&r2=1746378&view=diff ============================================================================== --- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ConstantNameAndType.java (original) +++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ConstantNameAndType.java Wed Jun 1 04:25:27 2016 @@ -40,7 +40,7 @@ public final class ConstantNameAndType e /** * Initialize from another object. */ - public ConstantNameAndType(ConstantNameAndType c) { + public ConstantNameAndType(final ConstantNameAndType c) { this(c.getNameIndex(), c.getSignatureIndex()); } @@ -51,7 +51,7 @@ public final class ConstantNameAndType e * @param file Input stream * @throws IOException */ - ConstantNameAndType(DataInput file) throws IOException { + ConstantNameAndType(final DataInput file) throws IOException { this(file.readUnsignedShort(), file.readUnsignedShort()); } @@ -60,7 +60,7 @@ public final class ConstantNameAndType e * @param name_index Name of field/method * @param signature_index and its signature */ - public ConstantNameAndType(int name_index, int signature_index) { + public ConstantNameAndType(final int name_index, final int signature_index) { super(Const.CONSTANT_NameAndType); this.name_index = name_index; this.signature_index = signature_index; @@ -75,7 +75,7 @@ public final class ConstantNameAndType e * @param v Visitor object */ @Override - public void accept( Visitor v ) { + public void accept( final Visitor v ) { v.visitConstantNameAndType(this); } @@ -87,7 +87,7 @@ public final class ConstantNameAndType e * @throws IOException */ @Override - public final void dump( DataOutputStream file ) throws IOException { + public final void dump( final DataOutputStream file ) throws IOException { file.writeByte(super.getTag()); file.writeShort(name_index); file.writeShort(signature_index); @@ -104,7 +104,7 @@ public final class ConstantNameAndType e /** @return name */ - public final String getName( ConstantPool cp ) { + public final String getName( final ConstantPool cp ) { return cp.constantToString(getNameIndex(), Const.CONSTANT_Utf8); } @@ -119,7 +119,7 @@ public final class ConstantNameAndType e /** @return signature */ - public final String getSignature( ConstantPool cp ) { + public final String getSignature( final ConstantPool cp ) { return cp.constantToString(getSignatureIndex(), Const.CONSTANT_Utf8); } @@ -127,7 +127,7 @@ public final class ConstantNameAndType e /** * @param name_index the name index of this constant */ - public final void setNameIndex( int name_index ) { + public final void setNameIndex( final int name_index ) { this.name_index = name_index; } @@ -135,7 +135,7 @@ public final class ConstantNameAndType e /** * @param signature_index the signature index in the constant pool of this type */ - public final void setSignatureIndex( int signature_index ) { + public final void setSignatureIndex( final int signature_index ) { this.signature_index = signature_index; } Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ConstantPool.java URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ConstantPool.java?rev=1746378&r1=1746377&r2=1746378&view=diff ============================================================================== --- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ConstantPool.java (original) +++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ConstantPool.java Wed Jun 1 04:25:27 2016 @@ -43,7 +43,7 @@ public class ConstantPool implements Clo /** * @param constant_pool Array of constants */ - public ConstantPool(Constant[] constant_pool) { + public ConstantPool(final Constant[] constant_pool) { this.constant_pool = constant_pool; } @@ -55,7 +55,7 @@ public class ConstantPool implements Clo * @throws IOException * @throws ClassFormatException */ - public ConstantPool(DataInput input) throws IOException, ClassFormatException { + public ConstantPool(final DataInput input) throws IOException, ClassFormatException { byte tag; int constant_pool_count = input.readUnsignedShort(); constant_pool = new Constant[constant_pool_count]; @@ -87,7 +87,7 @@ public class ConstantPool implements Clo * @param v Visitor object */ @Override - public void accept( Visitor v ) { + public void accept( final Visitor v ) { v.visitConstantPool(this); } @@ -166,7 +166,7 @@ public class ConstantPool implements Clo } - private static String escape( String str ) { + private static String escape( final String str ) { int len = str.length(); StringBuilder buf = new StringBuilder(len + 5); char[] ch = str.toCharArray(); @@ -203,7 +203,7 @@ public class ConstantPool implements Clo * @param tag expected type * @return String representation */ - public String constantToString( int index, byte tag ) throws ClassFormatException { + public String constantToString( final int index, final byte tag ) throws ClassFormatException { Constant c = getConstant(index, tag); return constantToString(c); } @@ -215,7 +215,7 @@ public class ConstantPool implements Clo * @param file Output file stream * @throws IOException */ - public void dump( DataOutputStream file ) throws IOException { + public void dump( final DataOutputStream file ) throws IOException { file.writeShort(constant_pool.length); for (int i = 1; i < constant_pool.length; i++) { if (constant_pool[i] != null) { @@ -232,7 +232,7 @@ public class ConstantPool implements Clo * @return Constant value * @see Constant */ - public Constant getConstant( int index ) { + public Constant getConstant( final int index ) { if (index >= constant_pool.length || index < 0) { throw new ClassFormatException("Invalid constant pool reference: " + index + ". Constant pool size is: " + constant_pool.length); @@ -251,7 +251,7 @@ public class ConstantPool implements Clo * @see Constant * @throws ClassFormatException */ - public Constant getConstant( int index, byte tag ) throws ClassFormatException { + public Constant getConstant( final int index, final byte tag ) throws ClassFormatException { Constant c; c = getConstant(index); if (c == null) { @@ -287,7 +287,7 @@ public class ConstantPool implements Clo * @see ConstantString * @throws ClassFormatException */ - public String getConstantString( int index, byte tag ) throws ClassFormatException { + public String getConstantString( final int index, final byte tag ) throws ClassFormatException { Constant c; int i; c = getConstant(index, tag); @@ -325,7 +325,7 @@ public class ConstantPool implements Clo /** * @param constant Constant to set */ - public void setConstant( int index, Constant constant ) { + public void setConstant( final int index, final Constant constant ) { constant_pool[index] = constant; } @@ -333,7 +333,7 @@ public class ConstantPool implements Clo /** * @param constant_pool */ - public void setConstantPool( Constant[] constant_pool ) { + public void setConstantPool( final Constant[] constant_pool ) { this.constant_pool = constant_pool; } Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ConstantString.java URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ConstantString.java?rev=1746378&r1=1746377&r2=1746378&view=diff ============================================================================== --- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ConstantString.java (original) +++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ConstantString.java Wed Jun 1 04:25:27 2016 @@ -38,7 +38,7 @@ public final class ConstantString extend /** * Initialize from another object. */ - public ConstantString(ConstantString c) { + public ConstantString(final ConstantString c) { this(c.getStringIndex()); } @@ -49,7 +49,7 @@ public final class ConstantString extend * @param file Input stream * @throws IOException */ - ConstantString(DataInput file) throws IOException { + ConstantString(final DataInput file) throws IOException { this(file.readUnsignedShort()); } @@ -57,7 +57,7 @@ public final class ConstantString extend /** * @param string_index Index of Constant_Utf8 in constant pool */ - public ConstantString(int string_index) { + public ConstantString(final int string_index) { super(Const.CONSTANT_String); this.string_index = string_index; } @@ -71,7 +71,7 @@ public final class ConstantString extend * @param v Visitor object */ @Override - public void accept( Visitor v ) { + public void accept( final Visitor v ) { v.visitConstantString(this); } @@ -83,7 +83,7 @@ public final class ConstantString extend * @throws IOException */ @Override - public final void dump( DataOutputStream file ) throws IOException { + public final void dump( final DataOutputStream file ) throws IOException { file.writeByte(super.getTag()); file.writeShort(string_index); } @@ -100,7 +100,7 @@ public final class ConstantString extend /** * @param string_index the index into the constant of the string value */ - public final void setStringIndex( int string_index ) { + public final void setStringIndex( final int string_index ) { this.string_index = string_index; } @@ -117,7 +117,7 @@ public final class ConstantString extend /** @return String object */ @Override - public Object getConstantValue( ConstantPool cp ) { + public Object getConstantValue( final ConstantPool cp ) { Constant c = cp.getConstant(string_index, Const.CONSTANT_Utf8); return ((ConstantUtf8) c).getBytes(); } @@ -125,7 +125,7 @@ public final class ConstantString extend /** @return dereferenced string */ - public String getBytes( ConstantPool cp ) { + public String getBytes( final ConstantPool cp ) { return (String) getConstantValue(cp); } } Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ConstantUtf8.java URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ConstantUtf8.java?rev=1746378&r1=1746377&r2=1746378&view=diff ============================================================================== --- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ConstantUtf8.java (original) +++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ConstantUtf8.java Wed Jun 1 04:25:27 2016 @@ -59,7 +59,7 @@ public final class ConstantUtf8 extends private static final long serialVersionUID = -8506975356158971766L; @Override - protected boolean removeEldestEntry(Map.Entry<String, ConstantUtf8> eldest) { + protected boolean removeEldestEntry(final Map.Entry<String, ConstantUtf8> eldest) { return size() > MAX_CACHE_ENTRIES; } }; @@ -91,7 +91,7 @@ public final class ConstantUtf8 extends /** * @since 6.0 */ - public static ConstantUtf8 getCachedInstance(String s) { + public static ConstantUtf8 getCachedInstance(final String s) { if (s.length() > MAX_CACHED_SIZE) { skipped++; return new ConstantUtf8(s); @@ -112,21 +112,21 @@ public final class ConstantUtf8 extends /** * @since 6.0 */ - public static ConstantUtf8 getInstance(String s) { + public static ConstantUtf8 getInstance(final String s) { return new ConstantUtf8(s); } /** * @since 6.0 */ - public static ConstantUtf8 getInstance (DataInput input) throws IOException { + public static ConstantUtf8 getInstance (final DataInput input) throws IOException { return getInstance(input.readUTF()); } /** * Initialize from another object. */ - public ConstantUtf8(ConstantUtf8 c) { + public ConstantUtf8(final ConstantUtf8 c) { this(c.getBytes()); } @@ -137,7 +137,7 @@ public final class ConstantUtf8 extends * @param file Input stream * @throws IOException */ - ConstantUtf8(DataInput file) throws IOException { + ConstantUtf8(final DataInput file) throws IOException { super(Const.CONSTANT_Utf8); bytes = file.readUTF(); created++; @@ -147,7 +147,7 @@ public final class ConstantUtf8 extends /** * @param bytes Data */ - public ConstantUtf8(String bytes) { + public ConstantUtf8(final String bytes) { super(Const.CONSTANT_Utf8); if (bytes == null) { throw new IllegalArgumentException("bytes must not be null!"); @@ -165,7 +165,7 @@ public final class ConstantUtf8 extends * @param v Visitor object */ @Override - public void accept( Visitor v ) { + public void accept( final Visitor v ) { v.visitConstantUtf8(this); } @@ -177,7 +177,7 @@ public final class ConstantUtf8 extends * @throws IOException */ @Override - public final void dump( DataOutputStream file ) throws IOException { + public final void dump( final DataOutputStream file ) throws IOException { file.writeByte(super.getTag()); file.writeUTF(bytes); } @@ -196,7 +196,7 @@ public final class ConstantUtf8 extends * @deprecated */ @java.lang.Deprecated - public final void setBytes( String bytes ) { + public final void setBytes( final String bytes ) { throw new UnsupportedOperationException(); } Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ConstantValue.java URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ConstantValue.java?rev=1746378&r1=1746377&r2=1746378&view=diff ============================================================================== --- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ConstantValue.java (original) +++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ConstantValue.java Wed Jun 1 04:25:27 2016 @@ -40,7 +40,7 @@ public final class ConstantValue extends * Initialize from another object. Note that both objects use the same * references (shallow copy). Use clone() for a physical copy. */ - public ConstantValue(ConstantValue c) { + public ConstantValue(final ConstantValue c) { this(c.getNameIndex(), c.getLength(), c.getConstantValueIndex(), c.getConstantPool()); } @@ -53,7 +53,7 @@ public final class ConstantValue extends * @param constant_pool Array of constants * @throws IOException */ - ConstantValue(int name_index, int length, DataInput input, ConstantPool constant_pool) + ConstantValue(final int name_index, final int length, final DataInput input, final ConstantPool constant_pool) throws IOException { this(name_index, length, input.readUnsignedShort(), constant_pool); } @@ -65,8 +65,8 @@ public final class ConstantValue extends * @param constantvalue_index Index in constant pool * @param constant_pool Array of constants */ - public ConstantValue(int name_index, int length, int constantvalue_index, - ConstantPool constant_pool) { + public ConstantValue(final int name_index, final int length, final int constantvalue_index, + final ConstantPool constant_pool) { super(Const.ATTR_CONSTANT_VALUE, name_index, length, constant_pool); this.constantvalue_index = constantvalue_index; } @@ -80,7 +80,7 @@ public final class ConstantValue extends * @param v Visitor object */ @Override - public void accept( Visitor v ) { + public void accept( final Visitor v ) { v.visitConstantValue(this); } @@ -92,7 +92,7 @@ public final class ConstantValue extends * @throws IOException */ @Override - public final void dump( DataOutputStream file ) throws IOException { + public final void dump( final DataOutputStream file ) throws IOException { super.dump(file); file.writeShort(constantvalue_index); } @@ -109,7 +109,7 @@ public final class ConstantValue extends /** * @param constantvalue_index the index info the constant pool of this constant value */ - public final void setConstantValueIndex( int constantvalue_index ) { + public final void setConstantValueIndex( final int constantvalue_index ) { this.constantvalue_index = constantvalue_index; } @@ -152,7 +152,7 @@ public final class ConstantValue extends * @return deep copy of this attribute */ @Override - public Attribute copy( ConstantPool _constant_pool ) { + public Attribute copy( final ConstantPool _constant_pool ) { ConstantValue c = (ConstantValue) clone(); c.setConstantPool(_constant_pool); return c; Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/Deprecated.java URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/Deprecated.java?rev=1746378&r1=1746377&r2=1746378&view=diff ============================================================================== --- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/Deprecated.java (original) +++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/Deprecated.java Wed Jun 1 04:25:27 2016 @@ -40,7 +40,7 @@ public final class Deprecated extends At * Initialize from another object. Note that both objects use the same * references (shallow copy). Use clone() for a physical copy. */ - public Deprecated(Deprecated c) { + public Deprecated(final Deprecated c) { this(c.getNameIndex(), c.getLength(), c.getBytes(), c.getConstantPool()); } @@ -51,7 +51,7 @@ public final class Deprecated extends At * @param bytes Attribute contents * @param constant_pool Array of constants */ - public Deprecated(int name_index, int length, byte[] bytes, ConstantPool constant_pool) { + public Deprecated(final int name_index, final int length, final byte[] bytes, final ConstantPool constant_pool) { super(Const.ATTR_DEPRECATED, name_index, length, constant_pool); this.bytes = bytes; } @@ -66,7 +66,7 @@ public final class Deprecated extends At * @param constant_pool Array of constants * @throws IOException */ - Deprecated(int name_index, int length, DataInput input, ConstantPool constant_pool) + Deprecated(final int name_index, final int length, final DataInput input, final ConstantPool constant_pool) throws IOException { this(name_index, length, (byte[]) null, constant_pool); if (length > 0) { @@ -85,7 +85,7 @@ public final class Deprecated extends At * @param v Visitor object */ @Override - public void accept( Visitor v ) { + public void accept( final Visitor v ) { v.visitDeprecated(this); } @@ -97,7 +97,7 @@ public final class Deprecated extends At * @throws IOException */ @Override - public final void dump( DataOutputStream file ) throws IOException { + public final void dump( final DataOutputStream file ) throws IOException { super.dump(file); if (super.getLength() > 0) { file.write(bytes, 0, super.getLength()); @@ -116,7 +116,7 @@ public final class Deprecated extends At /** * @param bytes the raw bytes that represents this byte array */ - public final void setBytes( byte[] bytes ) { + public final void setBytes( final byte[] bytes ) { this.bytes = bytes; } @@ -134,7 +134,7 @@ public final class Deprecated extends At * @return deep copy of this attribute */ @Override - public Attribute copy( ConstantPool _constant_pool ) { + public Attribute copy( final ConstantPool _constant_pool ) { Deprecated c = (Deprecated) clone(); if (bytes != null) { c.bytes = new byte[bytes.length]; Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/DescendingVisitor.java URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/DescendingVisitor.java?rev=1746378&r1=1746377&r2=1746378&view=diff ============================================================================== --- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/DescendingVisitor.java (original) +++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/DescendingVisitor.java Wed Jun 1 04:25:27 2016 @@ -47,7 +47,7 @@ public class DescendingVisitor implement * nesting level, i.e., 0 returns the direct predecessor * @return container of current entitity, i.e., predecessor during traversal */ - public Object predecessor(int level) + public Object predecessor(final int level) { int size = stack.size(); if ((size < 2) || (level < 0)) @@ -71,7 +71,7 @@ public class DescendingVisitor implement * @param visitor * visitor object to apply to all components */ - public DescendingVisitor(JavaClass clazz, Visitor visitor) + public DescendingVisitor(final JavaClass clazz, final Visitor visitor) { this.clazz = clazz; this.visitor = visitor; @@ -86,7 +86,7 @@ public class DescendingVisitor implement } @Override - public void visitJavaClass(JavaClass _clazz) + public void visitJavaClass(final JavaClass _clazz) { stack.push(_clazz); _clazz.accept(visitor); @@ -110,7 +110,7 @@ public class DescendingVisitor implement * @since 6.0 */ @Override - public void visitAnnotation(Annotations annotation) + public void visitAnnotation(final Annotations annotation) { stack.push(annotation); annotation.accept(visitor); @@ -125,7 +125,7 @@ public class DescendingVisitor implement * @since 6.0 */ @Override - public void visitAnnotationEntry(AnnotationEntry annotationEntry) + public void visitAnnotationEntry(final AnnotationEntry annotationEntry) { stack.push(annotationEntry); annotationEntry.accept(visitor); @@ -133,7 +133,7 @@ public class DescendingVisitor implement } @Override - public void visitField(Field field) + public void visitField(final Field field) { stack.push(field); field.accept(visitor); @@ -145,7 +145,7 @@ public class DescendingVisitor implement } @Override - public void visitConstantValue(ConstantValue cv) + public void visitConstantValue(final ConstantValue cv) { stack.push(cv); cv.accept(visitor); @@ -153,7 +153,7 @@ public class DescendingVisitor implement } @Override - public void visitMethod(Method method) + public void visitMethod(final Method method) { stack.push(method); method.accept(visitor); @@ -165,7 +165,7 @@ public class DescendingVisitor implement } @Override - public void visitExceptionTable(ExceptionTable table) + public void visitExceptionTable(final ExceptionTable table) { stack.push(table); table.accept(visitor); @@ -173,7 +173,7 @@ public class DescendingVisitor implement } @Override - public void visitCode(Code code) + public void visitCode(final Code code) { stack.push(code); code.accept(visitor); @@ -189,7 +189,7 @@ public class DescendingVisitor implement } @Override - public void visitCodeException(CodeException ce) + public void visitCodeException(final CodeException ce) { stack.push(ce); ce.accept(visitor); @@ -197,7 +197,7 @@ public class DescendingVisitor implement } @Override - public void visitLineNumberTable(LineNumberTable table) + public void visitLineNumberTable(final LineNumberTable table) { stack.push(table); table.accept(visitor); @@ -209,7 +209,7 @@ public class DescendingVisitor implement } @Override - public void visitLineNumber(LineNumber number) + public void visitLineNumber(final LineNumber number) { stack.push(number); number.accept(visitor); @@ -217,7 +217,7 @@ public class DescendingVisitor implement } @Override - public void visitLocalVariableTable(LocalVariableTable table) + public void visitLocalVariableTable(final LocalVariableTable table) { stack.push(table); table.accept(visitor); @@ -229,7 +229,7 @@ public class DescendingVisitor implement } @Override - public void visitStackMap(StackMap table) + public void visitStackMap(final StackMap table) { stack.push(table); table.accept(visitor); @@ -241,7 +241,7 @@ public class DescendingVisitor implement } @Override - public void visitStackMapEntry(StackMapEntry var) + public void visitStackMapEntry(final StackMapEntry var) { stack.push(var); var.accept(visitor); @@ -275,7 +275,7 @@ public class DescendingVisitor implement */ @Override - public void visitLocalVariable(LocalVariable var) + public void visitLocalVariable(final LocalVariable var) { stack.push(var); var.accept(visitor); @@ -283,7 +283,7 @@ public class DescendingVisitor implement } @Override - public void visitConstantPool(ConstantPool cp) + public void visitConstantPool(final ConstantPool cp) { stack.push(cp); cp.accept(visitor); @@ -299,7 +299,7 @@ public class DescendingVisitor implement } @Override - public void visitConstantClass(ConstantClass constant) + public void visitConstantClass(final ConstantClass constant) { stack.push(constant); constant.accept(visitor); @@ -307,7 +307,7 @@ public class DescendingVisitor implement } @Override - public void visitConstantDouble(ConstantDouble constant) + public void visitConstantDouble(final ConstantDouble constant) { stack.push(constant); constant.accept(visitor); @@ -315,7 +315,7 @@ public class DescendingVisitor implement } @Override - public void visitConstantFieldref(ConstantFieldref constant) + public void visitConstantFieldref(final ConstantFieldref constant) { stack.push(constant); constant.accept(visitor); @@ -323,7 +323,7 @@ public class DescendingVisitor implement } @Override - public void visitConstantFloat(ConstantFloat constant) + public void visitConstantFloat(final ConstantFloat constant) { stack.push(constant); constant.accept(visitor); @@ -331,7 +331,7 @@ public class DescendingVisitor implement } @Override - public void visitConstantInteger(ConstantInteger constant) + public void visitConstantInteger(final ConstantInteger constant) { stack.push(constant); constant.accept(visitor); @@ -340,7 +340,7 @@ public class DescendingVisitor implement @Override public void visitConstantInterfaceMethodref( - ConstantInterfaceMethodref constant) + final ConstantInterfaceMethodref constant) { stack.push(constant); constant.accept(visitor); @@ -352,7 +352,7 @@ public class DescendingVisitor implement */ @Override public void visitConstantInvokeDynamic( - ConstantInvokeDynamic constant) + final ConstantInvokeDynamic constant) { stack.push(constant); constant.accept(visitor); @@ -360,7 +360,7 @@ public class DescendingVisitor implement } @Override - public void visitConstantLong(ConstantLong constant) + public void visitConstantLong(final ConstantLong constant) { stack.push(constant); constant.accept(visitor); @@ -368,7 +368,7 @@ public class DescendingVisitor implement } @Override - public void visitConstantMethodref(ConstantMethodref constant) + public void visitConstantMethodref(final ConstantMethodref constant) { stack.push(constant); constant.accept(visitor); @@ -376,7 +376,7 @@ public class DescendingVisitor implement } @Override - public void visitConstantNameAndType(ConstantNameAndType constant) + public void visitConstantNameAndType(final ConstantNameAndType constant) { stack.push(constant); constant.accept(visitor); @@ -384,7 +384,7 @@ public class DescendingVisitor implement } @Override - public void visitConstantString(ConstantString constant) + public void visitConstantString(final ConstantString constant) { stack.push(constant); constant.accept(visitor); @@ -392,7 +392,7 @@ public class DescendingVisitor implement } @Override - public void visitConstantUtf8(ConstantUtf8 constant) + public void visitConstantUtf8(final ConstantUtf8 constant) { stack.push(constant); constant.accept(visitor); @@ -400,7 +400,7 @@ public class DescendingVisitor implement } @Override - public void visitInnerClasses(InnerClasses ic) + public void visitInnerClasses(final InnerClasses ic) { stack.push(ic); ic.accept(visitor); @@ -412,7 +412,7 @@ public class DescendingVisitor implement } @Override - public void visitInnerClass(InnerClass inner) + public void visitInnerClass(final InnerClass inner) { stack.push(inner); inner.accept(visitor); @@ -423,7 +423,7 @@ public class DescendingVisitor implement * @since 6.0 */ @Override - public void visitBootstrapMethods(BootstrapMethods bm) + public void visitBootstrapMethods(final BootstrapMethods bm) { stack.push(bm); bm.accept(visitor); @@ -436,7 +436,7 @@ public class DescendingVisitor implement } @Override - public void visitDeprecated(Deprecated attribute) + public void visitDeprecated(final Deprecated attribute) { stack.push(attribute); attribute.accept(visitor); @@ -444,7 +444,7 @@ public class DescendingVisitor implement } @Override - public void visitSignature(Signature attribute) + public void visitSignature(final Signature attribute) { stack.push(attribute); attribute.accept(visitor); @@ -452,7 +452,7 @@ public class DescendingVisitor implement } @Override - public void visitSourceFile(SourceFile attribute) + public void visitSourceFile(final SourceFile attribute) { stack.push(attribute); attribute.accept(visitor); @@ -460,7 +460,7 @@ public class DescendingVisitor implement } @Override - public void visitSynthetic(Synthetic attribute) + public void visitSynthetic(final Synthetic attribute) { stack.push(attribute); attribute.accept(visitor); @@ -468,7 +468,7 @@ public class DescendingVisitor implement } @Override - public void visitUnknown(Unknown attribute) + public void visitUnknown(final Unknown attribute) { stack.push(attribute); attribute.accept(visitor); @@ -479,7 +479,7 @@ public class DescendingVisitor implement * @since 6.0 */ @Override - public void visitAnnotationDefault(AnnotationDefault obj) + public void visitAnnotationDefault(final AnnotationDefault obj) { stack.push(obj); obj.accept(visitor); @@ -490,7 +490,7 @@ public class DescendingVisitor implement * @since 6.0 */ @Override - public void visitEnclosingMethod(EnclosingMethod obj) + public void visitEnclosingMethod(final EnclosingMethod obj) { stack.push(obj); obj.accept(visitor); @@ -501,7 +501,7 @@ public class DescendingVisitor implement * @since 6.0 */ @Override - public void visitLocalVariableTypeTable(LocalVariableTypeTable obj) + public void visitLocalVariableTypeTable(final LocalVariableTypeTable obj) { stack.push(obj); obj.accept(visitor); @@ -512,7 +512,7 @@ public class DescendingVisitor implement * @since 6.0 */ @Override - public void visitParameterAnnotation(ParameterAnnotations obj) + public void visitParameterAnnotation(final ParameterAnnotations obj) { stack.push(obj); obj.accept(visitor); @@ -523,7 +523,7 @@ public class DescendingVisitor implement * @since 6.0 */ @Override - public void visitMethodParameters(MethodParameters obj) + public void visitMethodParameters(final MethodParameters obj) { stack.push(obj); obj.accept(visitor); @@ -532,7 +532,7 @@ public class DescendingVisitor implement /** @since 6.0 */ @Override - public void visitConstantMethodType(ConstantMethodType obj) { + public void visitConstantMethodType(final ConstantMethodType obj) { stack.push(obj); obj.accept(visitor); stack.pop(); @@ -540,7 +540,7 @@ public class DescendingVisitor implement /** @since 6.0 */ @Override - public void visitConstantMethodHandle(ConstantMethodHandle obj) { + public void visitConstantMethodHandle(final ConstantMethodHandle obj) { stack.push(obj); obj.accept(visitor); stack.pop(); @@ -548,7 +548,7 @@ public class DescendingVisitor implement /** @since 6.0 */ @Override - public void visitParameterAnnotationEntry(ParameterAnnotationEntry obj) { + public void visitParameterAnnotationEntry(final ParameterAnnotationEntry obj) { stack.push(obj); obj.accept(visitor); stack.pop(); Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ElementValue.java URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ElementValue.java?rev=1746378&r1=1746377&r2=1746378&view=diff ============================================================================== --- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ElementValue.java (original) +++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ElementValue.java Wed Jun 1 04:25:27 2016 @@ -45,7 +45,7 @@ public abstract class ElementValue return stringifyValue(); } - protected ElementValue(int type, ConstantPool cpool) + protected ElementValue(final int type, final ConstantPool cpool) { this.type = type; this.cpool = cpool; @@ -74,7 +74,7 @@ public abstract class ElementValue public static final byte PRIMITIVE_SHORT = 'S'; public static final byte PRIMITIVE_BOOLEAN = 'Z'; - public static ElementValue readElementValue(DataInput input, ConstantPool cpool) throws IOException + public static ElementValue readElementValue(final DataInput input, final ConstantPool cpool) throws IOException { byte type = input.readByte(); switch (type) Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ElementValuePair.java URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ElementValuePair.java?rev=1746378&r1=1746377&r2=1746378&view=diff ============================================================================== --- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ElementValuePair.java (original) +++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ElementValuePair.java Wed Jun 1 04:25:27 2016 @@ -36,8 +36,8 @@ public class ElementValuePair private final int elementNameIndex; - public ElementValuePair(int elementNameIndex, ElementValue elementValue, - ConstantPool constantPool) + public ElementValuePair(final int elementNameIndex, final ElementValue elementValue, + final ConstantPool constantPool) { this.elementValue = elementValue; this.elementNameIndex = elementNameIndex; @@ -69,7 +69,7 @@ public class ElementValuePair return result.toString(); } - protected void dump(DataOutputStream dos) throws IOException { + protected void dump(final DataOutputStream dos) throws IOException { dos.writeShort(elementNameIndex); // u2 name of the element elementValue.dump(dos); } Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/EmptyVisitor.java URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/EmptyVisitor.java?rev=1746378&r1=1746377&r2=1746378&view=diff ============================================================================== --- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/EmptyVisitor.java (original) +++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/EmptyVisitor.java Wed Jun 1 04:25:27 2016 @@ -34,7 +34,7 @@ public class EmptyVisitor implements Vis * @since 6.0 */ @Override - public void visitAnnotation(Annotations obj) + public void visitAnnotation(final Annotations obj) { } @@ -42,7 +42,7 @@ public class EmptyVisitor implements Vis * @since 6.0 */ @Override - public void visitParameterAnnotation(ParameterAnnotations obj) + public void visitParameterAnnotation(final ParameterAnnotations obj) { } @@ -50,7 +50,7 @@ public class EmptyVisitor implements Vis * @since 6.0 */ @Override - public void visitAnnotationEntry(AnnotationEntry obj) + public void visitAnnotationEntry(final AnnotationEntry obj) { } @@ -58,112 +58,112 @@ public class EmptyVisitor implements Vis * @since 6.0 */ @Override - public void visitAnnotationDefault(AnnotationDefault obj) + public void visitAnnotationDefault(final AnnotationDefault obj) { } @Override - public void visitCode(Code obj) + public void visitCode(final Code obj) { } @Override - public void visitCodeException(CodeException obj) + public void visitCodeException(final CodeException obj) { } @Override - public void visitConstantClass(ConstantClass obj) + public void visitConstantClass(final ConstantClass obj) { } @Override - public void visitConstantDouble(ConstantDouble obj) + public void visitConstantDouble(final ConstantDouble obj) { } @Override - public void visitConstantFieldref(ConstantFieldref obj) + public void visitConstantFieldref(final ConstantFieldref obj) { } @Override - public void visitConstantFloat(ConstantFloat obj) + public void visitConstantFloat(final ConstantFloat obj) { } @Override - public void visitConstantInteger(ConstantInteger obj) + public void visitConstantInteger(final ConstantInteger obj) { } @Override - public void visitConstantInterfaceMethodref(ConstantInterfaceMethodref obj) + public void visitConstantInterfaceMethodref(final ConstantInterfaceMethodref obj) { } @Override - public void visitConstantInvokeDynamic(ConstantInvokeDynamic obj) + public void visitConstantInvokeDynamic(final ConstantInvokeDynamic obj) { } @Override - public void visitConstantLong(ConstantLong obj) + public void visitConstantLong(final ConstantLong obj) { } @Override - public void visitConstantMethodref(ConstantMethodref obj) + public void visitConstantMethodref(final ConstantMethodref obj) { } @Override - public void visitConstantNameAndType(ConstantNameAndType obj) + public void visitConstantNameAndType(final ConstantNameAndType obj) { } @Override - public void visitConstantPool(ConstantPool obj) + public void visitConstantPool(final ConstantPool obj) { } @Override - public void visitConstantString(ConstantString obj) + public void visitConstantString(final ConstantString obj) { } @Override - public void visitConstantUtf8(ConstantUtf8 obj) + public void visitConstantUtf8(final ConstantUtf8 obj) { } @Override - public void visitConstantValue(ConstantValue obj) + public void visitConstantValue(final ConstantValue obj) { } @Override - public void visitDeprecated(Deprecated obj) + public void visitDeprecated(final Deprecated obj) { } @Override - public void visitExceptionTable(ExceptionTable obj) + public void visitExceptionTable(final ExceptionTable obj) { } @Override - public void visitField(Field obj) + public void visitField(final Field obj) { } @Override - public void visitInnerClass(InnerClass obj) + public void visitInnerClass(final InnerClass obj) { } @Override - public void visitInnerClasses(InnerClasses obj) + public void visitInnerClasses(final InnerClasses obj) { } @@ -171,67 +171,67 @@ public class EmptyVisitor implements Vis * @since 6.0 */ @Override - public void visitBootstrapMethods(BootstrapMethods obj) + public void visitBootstrapMethods(final BootstrapMethods obj) { } @Override - public void visitJavaClass(JavaClass obj) + public void visitJavaClass(final JavaClass obj) { } @Override - public void visitLineNumber(LineNumber obj) + public void visitLineNumber(final LineNumber obj) { } @Override - public void visitLineNumberTable(LineNumberTable obj) + public void visitLineNumberTable(final LineNumberTable obj) { } @Override - public void visitLocalVariable(LocalVariable obj) + public void visitLocalVariable(final LocalVariable obj) { } @Override - public void visitLocalVariableTable(LocalVariableTable obj) + public void visitLocalVariableTable(final LocalVariableTable obj) { } @Override - public void visitMethod(Method obj) + public void visitMethod(final Method obj) { } @Override - public void visitSignature(Signature obj) + public void visitSignature(final Signature obj) { } @Override - public void visitSourceFile(SourceFile obj) + public void visitSourceFile(final SourceFile obj) { } @Override - public void visitSynthetic(Synthetic obj) + public void visitSynthetic(final Synthetic obj) { } @Override - public void visitUnknown(Unknown obj) + public void visitUnknown(final Unknown obj) { } @Override - public void visitStackMap(StackMap obj) + public void visitStackMap(final StackMap obj) { } @Override - public void visitStackMapEntry(StackMapEntry obj) + public void visitStackMapEntry(final StackMapEntry obj) { } @@ -255,7 +255,7 @@ public class EmptyVisitor implements Vis * @since 6.0 */ @Override - public void visitEnclosingMethod(EnclosingMethod obj) + public void visitEnclosingMethod(final EnclosingMethod obj) { } @@ -263,7 +263,7 @@ public class EmptyVisitor implements Vis * @since 6.0 */ @Override - public void visitLocalVariableTypeTable(LocalVariableTypeTable obj) + public void visitLocalVariableTypeTable(final LocalVariableTypeTable obj) { } @@ -271,7 +271,7 @@ public class EmptyVisitor implements Vis * @since 6.0 */ @Override - public void visitMethodParameters(MethodParameters obj) + public void visitMethodParameters(final MethodParameters obj) { } @@ -279,7 +279,7 @@ public class EmptyVisitor implements Vis * @since 6.0 */ @Override - public void visitConstantMethodType(ConstantMethodType obj) + public void visitConstantMethodType(final ConstantMethodType obj) { } @@ -287,13 +287,13 @@ public class EmptyVisitor implements Vis * @since 6.0 */ @Override - public void visitConstantMethodHandle(ConstantMethodHandle constantMethodHandle) { + public void visitConstantMethodHandle(final ConstantMethodHandle constantMethodHandle) { } /** * @since 6.0 */ @Override - public void visitParameterAnnotationEntry(ParameterAnnotationEntry parameterAnnotationEntry) { + public void visitParameterAnnotationEntry(final ParameterAnnotationEntry parameterAnnotationEntry) { } } Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/EnclosingMethod.java URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/EnclosingMethod.java?rev=1746378&r1=1746377&r2=1746378&view=diff ============================================================================== --- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/EnclosingMethod.java (original) +++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/EnclosingMethod.java Wed Jun 1 04:25:27 2016 @@ -45,23 +45,23 @@ public class EnclosingMethod extends Att private int methodIndex; // Ctors - and code to read an attribute in. - EnclosingMethod(int nameIndex, int len, DataInput input, ConstantPool cpool) throws IOException { + EnclosingMethod(final int nameIndex, final int len, final DataInput input, final ConstantPool cpool) throws IOException { this(nameIndex, len, input.readUnsignedShort(), input.readUnsignedShort(), cpool); } - private EnclosingMethod(int nameIndex, int len, int classIdx,int methodIdx, ConstantPool cpool) { + private EnclosingMethod(final int nameIndex, final int len, final int classIdx,final int methodIdx, final ConstantPool cpool) { super(Const.ATTR_ENCLOSING_METHOD, nameIndex, len, cpool); classIndex = classIdx; methodIndex = methodIdx; } @Override - public void accept(Visitor v) { + public void accept(final Visitor v) { v.visitEnclosingMethod(this); } @Override - public Attribute copy(ConstantPool constant_pool) { + public Attribute copy(final ConstantPool constant_pool) { return (Attribute) clone(); } @@ -69,8 +69,8 @@ public class EnclosingMethod extends Att public final int getEnclosingClassIndex() { return classIndex; } public final int getEnclosingMethodIndex(){ return methodIndex;} - public final void setEnclosingClassIndex(int idx) {classIndex = idx;} - public final void setEnclosingMethodIndex(int idx){methodIndex= idx;} + public final void setEnclosingClassIndex(final int idx) {classIndex = idx;} + public final void setEnclosingMethodIndex(final int idx){methodIndex= idx;} public final ConstantClass getEnclosingClass() { ConstantClass c = @@ -88,7 +88,7 @@ public class EnclosingMethod extends Att } @Override - public final void dump(DataOutputStream file) throws IOException { + public final void dump(final DataOutputStream file) throws IOException { super.dump(file); file.writeShort(classIndex); file.writeShort(methodIndex); Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/EnumElementValue.java URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/EnumElementValue.java?rev=1746378&r1=1746377&r2=1746378&view=diff ============================================================================== --- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/EnumElementValue.java (original) +++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/EnumElementValue.java Wed Jun 1 04:25:27 2016 @@ -32,8 +32,8 @@ public class EnumElementValue extends El private final int valueIdx; - public EnumElementValue(int type, int typeIdx, int valueIdx, - ConstantPool cpool) + public EnumElementValue(final int type, final int typeIdx, final int valueIdx, + final ConstantPool cpool) { super(type, cpool); if (type != ENUM_CONSTANT) { @@ -45,7 +45,7 @@ public class EnumElementValue extends El } @Override - public void dump(DataOutputStream dos) throws IOException + public void dump(final DataOutputStream dos) throws IOException { dos.writeByte(super.getType()); // u1 type of value (ENUM_CONSTANT == 'e') dos.writeShort(typeIdx); // u2 Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ExceptionTable.java URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ExceptionTable.java?rev=1746378&r1=1746377&r2=1746378&view=diff ============================================================================== --- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ExceptionTable.java (original) +++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ExceptionTable.java Wed Jun 1 04:25:27 2016 @@ -43,7 +43,7 @@ public final class ExceptionTable extend * Initialize from another object. Note that both objects use the same * references (shallow copy). Use copy() for a physical copy. */ - public ExceptionTable(ExceptionTable c) { + public ExceptionTable(final ExceptionTable c) { this(c.getNameIndex(), c.getLength(), c.getExceptionIndexTable(), c.getConstantPool()); } @@ -54,8 +54,8 @@ public final class ExceptionTable extend * @param exception_index_table Table of indices in constant pool * @param constant_pool Array of constants */ - public ExceptionTable(int name_index, int length, int[] exception_index_table, - ConstantPool constant_pool) { + public ExceptionTable(final int name_index, final int length, final int[] exception_index_table, + final ConstantPool constant_pool) { super(Const.ATTR_EXCEPTIONS, name_index, length, constant_pool); this.exception_index_table = exception_index_table != null ? exception_index_table : new int[0]; } @@ -69,7 +69,7 @@ public final class ExceptionTable extend * @param constant_pool Array of constants * @throws IOException */ - ExceptionTable(int name_index, int length, DataInput input, ConstantPool constant_pool) throws IOException { + ExceptionTable(final int name_index, final int length, final DataInput input, final ConstantPool constant_pool) throws IOException { this(name_index, length, (int[]) null, constant_pool); int number_of_exceptions = input.readUnsignedShort(); exception_index_table = new int[number_of_exceptions]; @@ -87,7 +87,7 @@ public final class ExceptionTable extend * @param v Visitor object */ @Override - public void accept( Visitor v ) { + public void accept( final Visitor v ) { v.visitExceptionTable(this); } @@ -99,7 +99,7 @@ public final class ExceptionTable extend * @throws IOException */ @Override - public final void dump( DataOutputStream file ) throws IOException { + public final void dump( final DataOutputStream file ) throws IOException { super.dump(file); file.writeShort(exception_index_table.length); for (int index : exception_index_table) { @@ -141,7 +141,7 @@ public final class ExceptionTable extend * @param exception_index_table the list of exception indexes * Also redefines number_of_exceptions according to table length. */ - public final void setExceptionIndexTable( int[] exception_index_table ) { + public final void setExceptionIndexTable( final int[] exception_index_table ) { this.exception_index_table = exception_index_table != null ? exception_index_table : new int[0]; } @@ -169,7 +169,7 @@ public final class ExceptionTable extend * @return deep copy of this attribute */ @Override - public Attribute copy( ConstantPool _constant_pool ) { + public Attribute copy( final ConstantPool _constant_pool ) { ExceptionTable c = (ExceptionTable) clone(); if (exception_index_table != null) { c.exception_index_table = new int[exception_index_table.length];
