svn commit: r1744392 - /commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/digest/MessageDigestAlgorithms.java

[sebb]

Author: sebb
Date: Wed May 18 11:28:17 2016
New Revision: 1744392

URL: http://svn.apache.org/viewvc?rev=1744392&view=rev
Log:
Why we create the array anew each time

Modified:
    
commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/digest/MessageDigestAlgorithms.java

Modified: 
commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/digest/MessageDigestAlgorithms.java
URL: 
http://svn.apache.org/viewvc/commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/digest/MessageDigestAlgorithms.java?rev=1744392&r1=1744391&r2=1744392&view=diff
==============================================================================
--- 
commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/digest/MessageDigestAlgorithms.java
 (original)
+++ 
commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/digest/MessageDigestAlgorithms.java
 Wed May 18 11:28:17 2016
@@ -128,6 +128,7 @@ public class MessageDigestAlgorithms {
      * @since 1.11
      */
     public static String[] values() {
+        // N.B. do not use a constant array here as that can be changed 
externally by accident or design
         return new String[] { MD2, MD5, SHA_1, SHA_224, SHA_256, SHA_384, 
SHA_512, SHA3_224, SHA3_256, SHA3_384, SHA3_512 };
     }