Repository: commons-compress
Updated Branches:
  refs/heads/master 05bb97bf7 -> e21728cef


Statement unnecessarily nested within else clause.

Project: http://git-wip-us.apache.org/repos/asf/commons-compress/repo
Commit: http://git-wip-us.apache.org/repos/asf/commons-compress/commit/e21728ce
Tree: http://git-wip-us.apache.org/repos/asf/commons-compress/tree/e21728ce
Diff: http://git-wip-us.apache.org/repos/asf/commons-compress/diff/e21728ce

Branch: refs/heads/master
Commit: e21728cef4e89ff5fb173c230d56d16d424dc6c2
Parents: 05bb97b
Author: ggregory <ggreg...@apache.org>
Authored: Sat Apr 9 08:54:32 2016 -0700
Committer: ggregory <ggreg...@apache.org>
Committed: Sat Apr 9 08:54:32 2016 -0700

----------------------------------------------------------------------
 .../commons/compress/archivers/ArchiveStreamFactoryTest.java    | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/commons-compress/blob/e21728ce/src/test/java/org/apache/commons/compress/archivers/ArchiveStreamFactoryTest.java
----------------------------------------------------------------------
diff --git 
a/src/test/java/org/apache/commons/compress/archivers/ArchiveStreamFactoryTest.java
 
b/src/test/java/org/apache/commons/compress/archivers/ArchiveStreamFactoryTest.java
index 0352fed..a64b9a6 100644
--- 
a/src/test/java/org/apache/commons/compress/archivers/ArchiveStreamFactoryTest.java
+++ 
b/src/test/java/org/apache/commons/compress/archivers/ArchiveStreamFactoryTest.java
@@ -368,10 +368,9 @@ public class ArchiveStreamFactoryTest {
             final Object object = fld.get(instance);
             if (object instanceof String || object == null) {
                 return (String) object;
-            } else {
-                System.out.println("Wrong type: " + 
object.getClass().getCanonicalName() + " for " + name + " in class " + 
instance.getClass().getSimpleName());
-                return "??";                
             }
+            System.out.println("Wrong type: " + 
object.getClass().getCanonicalName() + " for " + name + " in class " + 
instance.getClass().getSimpleName());
+            return "??";
         } catch (Exception e) {
             e.printStackTrace();
             return "??";

Reply via email to