svn commit: r1692734 - in /commons/proper/email/trunk/src: main/java/org/apache/commons/mail/HtmlEmail.java test/java/org/apache/commons/mail/ImageHtmlEmailTest.java test/java/org/apache/commons/mail/resolver/AbstractDataSourceResolverTest.java

[ggregory]

Author: ggregory
Date: Sun Jul 26 17:44:44 2015
New Revision: 1692734

URL: http://svn.apache.org/r1692734
Log:
Add final modifier where possible.

Modified:
    
commons/proper/email/trunk/src/main/java/org/apache/commons/mail/HtmlEmail.java
    
commons/proper/email/trunk/src/test/java/org/apache/commons/mail/ImageHtmlEmailTest.java
    
commons/proper/email/trunk/src/test/java/org/apache/commons/mail/resolver/AbstractDataSourceResolverTest.java

Modified: 
commons/proper/email/trunk/src/main/java/org/apache/commons/mail/HtmlEmail.java
URL: 
http://svn.apache.org/viewvc/commons/proper/email/trunk/src/main/java/org/apache/commons/mail/HtmlEmail.java?rev=1692734&r1=1692733&r2=1692734&view=diff
==============================================================================
--- 
commons/proper/email/trunk/src/main/java/org/apache/commons/mail/HtmlEmail.java 
(original)
+++ 
commons/proper/email/trunk/src/main/java/org/apache/commons/mail/HtmlEmail.java 
Sun Jul 26 17:44:44 2015
@@ -471,7 +471,7 @@ public class HtmlEmail extends MultiPart
         try
         {
             // URL encode the cid according to RFC 2392
-            String encodedCid = EmailUtils.encodeUrl(cid);
+            final String encodedCid = EmailUtils.encodeUrl(cid);
 
             mbp.setDataHandler(new DataHandler(dataSource));
             mbp.setFileName(name);

Modified: 
commons/proper/email/trunk/src/test/java/org/apache/commons/mail/ImageHtmlEmailTest.java
URL: 
http://svn.apache.org/viewvc/commons/proper/email/trunk/src/test/java/org/apache/commons/mail/ImageHtmlEmailTest.java?rev=1692734&r1=1692733&r2=1692734&view=diff
==============================================================================
--- 
commons/proper/email/trunk/src/test/java/org/apache/commons/mail/ImageHtmlEmailTest.java
 (original)
+++ 
commons/proper/email/trunk/src/test/java/org/apache/commons/mail/ImageHtmlEmailTest.java
 Sun Jul 26 17:44:44 2015
@@ -498,8 +498,8 @@ public class ImageHtmlEmailTest extends
         }
 
         @Override
-        public DataSource resolve(String resourceLocation, boolean isLenient) 
throws IOException {
-            javax.mail.util.ByteArrayDataSource ds =
+        public DataSource resolve(final String resourceLocation, final boolean 
isLenient) throws IOException {
+            final javax.mail.util.ByteArrayDataSource ds =
                     (javax.mail.util.ByteArrayDataSource) 
super.resolve(resourceLocation, isLenient);
             ds.setName(null);
             return ds;

Modified: 
commons/proper/email/trunk/src/test/java/org/apache/commons/mail/resolver/AbstractDataSourceResolverTest.java
URL: 
http://svn.apache.org/viewvc/commons/proper/email/trunk/src/test/java/org/apache/commons/mail/resolver/AbstractDataSourceResolverTest.java?rev=1692734&r1=1692733&r2=1692734&view=diff
==============================================================================
--- 
commons/proper/email/trunk/src/test/java/org/apache/commons/mail/resolver/AbstractDataSourceResolverTest.java
 (original)
+++ 
commons/proper/email/trunk/src/test/java/org/apache/commons/mail/resolver/AbstractDataSourceResolverTest.java
 Sun Jul 26 17:44:44 2015
@@ -31,7 +31,7 @@ public abstract class AbstractDataSource
     {
         if(dataSource != null)
         {
-            InputStream is = dataSource.getInputStream();
+            final InputStream is = dataSource.getInputStream();
             try {
                 return IOUtils.toByteArray(is);
             } finally {