Author: britter
Date: Sat Mar 28 18:09:26 2015
New Revision: 1669814
URL: http://svn.apache.org/r1669814
Log:
Make fields final where possible
Modified:
commons/proper/cli/trunk/src/main/java/org/apache/commons/cli/AmbiguousOptionException.java
commons/proper/cli/trunk/src/main/java/org/apache/commons/cli/Option.java
commons/proper/cli/trunk/src/main/java/org/apache/commons/cli/OptionBuilder.java
commons/proper/cli/trunk/src/main/java/org/apache/commons/cli/OptionGroup.java
commons/proper/cli/trunk/src/main/java/org/apache/commons/cli/Options.java
commons/proper/cli/trunk/src/main/java/org/apache/commons/cli/PosixParser.java
commons/proper/cli/trunk/src/test/java/org/apache/commons/cli/OptionGroupTest.java
commons/proper/cli/trunk/src/test/java/org/apache/commons/cli/ValueTest.java
Modified:
commons/proper/cli/trunk/src/main/java/org/apache/commons/cli/AmbiguousOptionException.java
URL:
http://svn.apache.org/viewvc/commons/proper/cli/trunk/src/main/java/org/apache/commons/cli/AmbiguousOptionException.java?rev=1669814&r1=1669813&r2=1669814&view=diff
==============================================================================
---
commons/proper/cli/trunk/src/main/java/org/apache/commons/cli/AmbiguousOptionException.java
(original)
+++
commons/proper/cli/trunk/src/main/java/org/apache/commons/cli/AmbiguousOptionException.java
Sat Mar 28 18:09:26 2015
@@ -34,7 +34,7 @@ public class AmbiguousOptionException ex
private static final long serialVersionUID = 5829816121277947229L;
/** The list of options matching the partial name specified */
- private Collection<String> matchingOptions;
+ private final Collection<String> matchingOptions;
/**
* Constructs a new AmbiguousOptionException.
Modified:
commons/proper/cli/trunk/src/main/java/org/apache/commons/cli/Option.java
URL:
http://svn.apache.org/viewvc/commons/proper/cli/trunk/src/main/java/org/apache/commons/cli/Option.java?rev=1669814&r1=1669813&r2=1669814&view=diff
==============================================================================
--- commons/proper/cli/trunk/src/main/java/org/apache/commons/cli/Option.java
(original)
+++ commons/proper/cli/trunk/src/main/java/org/apache/commons/cli/Option.java
Sat Mar 28 18:09:26 2015
@@ -51,7 +51,7 @@ public class Option implements Cloneable
private static final long serialVersionUID = 1L;
/** the name of the option */
- private String opt;
+ private final String opt;
/** the long representation of the option */
private String longOpt;
Modified:
commons/proper/cli/trunk/src/main/java/org/apache/commons/cli/OptionBuilder.java
URL:
http://svn.apache.org/viewvc/commons/proper/cli/trunk/src/main/java/org/apache/commons/cli/OptionBuilder.java?rev=1669814&r1=1669813&r2=1669814&view=diff
==============================================================================
---
commons/proper/cli/trunk/src/main/java/org/apache/commons/cli/OptionBuilder.java
(original)
+++
commons/proper/cli/trunk/src/main/java/org/apache/commons/cli/OptionBuilder.java
Sat Mar 28 18:09:26 2015
@@ -57,7 +57,7 @@ public final class OptionBuilder
private static char valuesep;
/** option builder instance */
- private static OptionBuilder instance = new OptionBuilder();
+ private static final OptionBuilder instance = new OptionBuilder();
static
{
Modified:
commons/proper/cli/trunk/src/main/java/org/apache/commons/cli/OptionGroup.java
URL:
http://svn.apache.org/viewvc/commons/proper/cli/trunk/src/main/java/org/apache/commons/cli/OptionGroup.java?rev=1669814&r1=1669813&r2=1669814&view=diff
==============================================================================
---
commons/proper/cli/trunk/src/main/java/org/apache/commons/cli/OptionGroup.java
(original)
+++
commons/proper/cli/trunk/src/main/java/org/apache/commons/cli/OptionGroup.java
Sat Mar 28 18:09:26 2015
@@ -34,7 +34,7 @@ public class OptionGroup implements Seri
private static final long serialVersionUID = 1L;
/** hold the options */
- private Map<String, Option> optionMap = new HashMap<String, Option>();
+ private final Map<String, Option> optionMap = new HashMap<String,
Option>();
/** the name of the selected option */
private String selected;
Modified:
commons/proper/cli/trunk/src/main/java/org/apache/commons/cli/Options.java
URL:
http://svn.apache.org/viewvc/commons/proper/cli/trunk/src/main/java/org/apache/commons/cli/Options.java?rev=1669814&r1=1669813&r2=1669814&view=diff
==============================================================================
--- commons/proper/cli/trunk/src/main/java/org/apache/commons/cli/Options.java
(original)
+++ commons/proper/cli/trunk/src/main/java/org/apache/commons/cli/Options.java
Sat Mar 28 18:09:26 2015
@@ -47,18 +47,18 @@ public class Options implements Serializ
private static final long serialVersionUID = 1L;
/** a map of the options with the character key */
- private Map<String, Option> shortOpts = new LinkedHashMap<String,
Option>();
+ private final Map<String, Option> shortOpts = new LinkedHashMap<String,
Option>();
/** a map of the options with the long key */
- private Map<String, Option> longOpts = new LinkedHashMap<String, Option>();
+ private final Map<String, Option> longOpts = new LinkedHashMap<String,
Option>();
/** a map of the required options */
// N.B. This can contain either a String (addOption) or an OptionGroup
(addOptionGroup)
// TODO this seems wrong
- private List<Object> requiredOpts = new ArrayList<Object>();
+ private final List<Object> requiredOpts = new ArrayList<Object>();
/** a map of the option groups */
- private Map<String, OptionGroup> optionGroups = new HashMap<String,
OptionGroup>();
+ private final Map<String, OptionGroup> optionGroups = new HashMap<String,
OptionGroup>();
/**
* Add the specified option group.
Modified:
commons/proper/cli/trunk/src/main/java/org/apache/commons/cli/PosixParser.java
URL:
http://svn.apache.org/viewvc/commons/proper/cli/trunk/src/main/java/org/apache/commons/cli/PosixParser.java?rev=1669814&r1=1669813&r2=1669814&view=diff
==============================================================================
---
commons/proper/cli/trunk/src/main/java/org/apache/commons/cli/PosixParser.java
(original)
+++
commons/proper/cli/trunk/src/main/java/org/apache/commons/cli/PosixParser.java
Sat Mar 28 18:09:26 2015
@@ -33,7 +33,7 @@ import java.util.List;
public class PosixParser extends Parser
{
/** holder for flattened tokens */
- private List<String> tokens = new ArrayList<String>();
+ private final List<String> tokens = new ArrayList<String>();
/** specifies if bursting should continue */
private boolean eatTheRest;
Modified:
commons/proper/cli/trunk/src/test/java/org/apache/commons/cli/OptionGroupTest.java
URL:
http://svn.apache.org/viewvc/commons/proper/cli/trunk/src/test/java/org/apache/commons/cli/OptionGroupTest.java?rev=1669814&r1=1669813&r2=1669814&view=diff
==============================================================================
---
commons/proper/cli/trunk/src/test/java/org/apache/commons/cli/OptionGroupTest.java
(original)
+++
commons/proper/cli/trunk/src/test/java/org/apache/commons/cli/OptionGroupTest.java
Sat Mar 28 18:09:26 2015
@@ -31,7 +31,7 @@ import org.junit.Test;
public class OptionGroupTest
{
private Options _options = null;
- private Parser parser = new PosixParser();
+ private final Parser parser = new PosixParser();
@Before
public void setUp()
Modified:
commons/proper/cli/trunk/src/test/java/org/apache/commons/cli/ValueTest.java
URL:
http://svn.apache.org/viewvc/commons/proper/cli/trunk/src/test/java/org/apache/commons/cli/ValueTest.java?rev=1669814&r1=1669813&r2=1669814&view=diff
==============================================================================
---
commons/proper/cli/trunk/src/test/java/org/apache/commons/cli/ValueTest.java
(original)
+++
commons/proper/cli/trunk/src/test/java/org/apache/commons/cli/ValueTest.java
Sat Mar 28 18:09:26 2015
@@ -29,7 +29,7 @@ import org.junit.Test;
public class ValueTest
{
private CommandLine _cl = null;
- private Options opts = new Options();
+ private final Options opts = new Options();
@Before
public void setUp() throws Exception
