svn commit: r1650418 - in /commons/proper/net/trunk/src/main/java/org/apache/commons/net: ftp/FTPSClient.java imap/IMAPSClient.java pop3/POP3SClient.java smtp/SMTPSClient.java

[sebb]

Author: sebb
Date: Thu Jan  8 23:26:38 2015
New Revision: 1650418

URL: http://svn.apache.org/r1650418
Log:
Document what looks like code duplication

Modified:
    
commons/proper/net/trunk/src/main/java/org/apache/commons/net/ftp/FTPSClient.java
    
commons/proper/net/trunk/src/main/java/org/apache/commons/net/imap/IMAPSClient.java
    
commons/proper/net/trunk/src/main/java/org/apache/commons/net/pop3/POP3SClient.java
    
commons/proper/net/trunk/src/main/java/org/apache/commons/net/smtp/SMTPSClient.java

Modified: 
commons/proper/net/trunk/src/main/java/org/apache/commons/net/ftp/FTPSClient.java
URL: 
http://svn.apache.org/viewvc/commons/proper/net/trunk/src/main/java/org/apache/commons/net/ftp/FTPSClient.java?rev=1650418&r1=1650417&r2=1650418&view=diff
==============================================================================
--- 
commons/proper/net/trunk/src/main/java/org/apache/commons/net/ftp/FTPSClient.java
 (original)
+++ 
commons/proper/net/trunk/src/main/java/org/apache/commons/net/ftp/FTPSClient.java
 Thu Jan  8 23:26:38 2015
@@ -268,6 +268,7 @@ public class FTPSClient extends FTPClien
         }
         socket.startHandshake();
 
+        // TODO the following setup appears to duplicate that in the super 
class methods
         _socket_ = socket;
         _controlInput_ = new BufferedReader(new InputStreamReader(
                 socket .getInputStream(), getControlEncoding()));

Modified: 
commons/proper/net/trunk/src/main/java/org/apache/commons/net/imap/IMAPSClient.java
URL: 
http://svn.apache.org/viewvc/commons/proper/net/trunk/src/main/java/org/apache/commons/net/imap/IMAPSClient.java?rev=1650418&r1=1650417&r2=1650418&view=diff
==============================================================================
--- 
commons/proper/net/trunk/src/main/java/org/apache/commons/net/imap/IMAPSClient.java
 (original)
+++ 
commons/proper/net/trunk/src/main/java/org/apache/commons/net/imap/IMAPSClient.java
 Thu Jan  8 23:26:38 2015
@@ -199,6 +199,7 @@ public class IMAPSClient extends IMAPCli
         }
         socket.startHandshake();
 
+        // TODO the following setup appears to duplicate that in the super 
class methods
         _socket_ = socket;
         _input_ = socket.getInputStream();
         _output_ = socket.getOutputStream();

Modified: 
commons/proper/net/trunk/src/main/java/org/apache/commons/net/pop3/POP3SClient.java
URL: 
http://svn.apache.org/viewvc/commons/proper/net/trunk/src/main/java/org/apache/commons/net/pop3/POP3SClient.java?rev=1650418&r1=1650417&r2=1650418&view=diff
==============================================================================
--- 
commons/proper/net/trunk/src/main/java/org/apache/commons/net/pop3/POP3SClient.java
 (original)
+++ 
commons/proper/net/trunk/src/main/java/org/apache/commons/net/pop3/POP3SClient.java
 Thu Jan  8 23:26:38 2015
@@ -209,6 +209,7 @@ public class POP3SClient extends POP3Cli
         }
         socket.startHandshake();
 
+        // TODO the following setup appears to duplicate that in the super 
class methods
         _socket_ = socket;
         _input_ = socket.getInputStream();
         _output_ = socket.getOutputStream();

Modified: 
commons/proper/net/trunk/src/main/java/org/apache/commons/net/smtp/SMTPSClient.java
URL: 
http://svn.apache.org/viewvc/commons/proper/net/trunk/src/main/java/org/apache/commons/net/smtp/SMTPSClient.java?rev=1650418&r1=1650417&r2=1650418&view=diff
==============================================================================
--- 
commons/proper/net/trunk/src/main/java/org/apache/commons/net/smtp/SMTPSClient.java
 (original)
+++ 
commons/proper/net/trunk/src/main/java/org/apache/commons/net/smtp/SMTPSClient.java
 Thu Jan  8 23:26:38 2015
@@ -198,6 +198,7 @@ public class SMTPSClient extends SMTPCli
         }
         socket.startHandshake();
 
+        // TODO the following setup appears to duplicate that in the super 
class methods
         _socket_ = socket;
         _input_ = socket.getInputStream();
         _output_ = socket.getOutputStream();