Author: sebb
Date: Tue Jan 6 23:50:46 2015
New Revision: 1649975
URL: http://svn.apache.org/r1649975
Log:
VALIDATOR-342 - URLValidator returns false for http://example.rocks
Modified:
commons/proper/validator/trunk/RELEASE-NOTES.txt
commons/proper/validator/trunk/src/changes/changes.xml
commons/proper/validator/trunk/src/test/java/org/apache/commons/validator/routines/UrlValidatorTest.java
Modified: commons/proper/validator/trunk/RELEASE-NOTES.txt
URL:
http://svn.apache.org/viewvc/commons/proper/validator/trunk/RELEASE-NOTES.txt?rev=1649975&r1=1649974&r2=1649975&view=diff
==============================================================================
--- commons/proper/validator/trunk/RELEASE-NOTES.txt (original)
+++ commons/proper/validator/trunk/RELEASE-NOTES.txt Tue Jan 6 23:50:46 2015
@@ -100,6 +100,8 @@ IMPROVEMENTS OVER PREVIOUS RELEASE
* [VALIDATOR-290] - Create new url validation using rfc3986 and IDN - added
new test
Thanks to Alexander Rytov
* [VALIDATOR-349] - TLD tables should be pre-sorted
+ * [VALIDATOR-342] - URLValidator returns false for http://example.rocks
+ Thanks to Donal Murtagh
DEPRECATIONS
============
Modified: commons/proper/validator/trunk/src/changes/changes.xml
URL:
http://svn.apache.org/viewvc/commons/proper/validator/trunk/src/changes/changes.xml?rev=1649975&r1=1649974&r2=1649975&view=diff
==============================================================================
--- commons/proper/validator/trunk/src/changes/changes.xml (original)
+++ commons/proper/validator/trunk/src/changes/changes.xml Tue Jan 6 23:50:46
2015
@@ -43,6 +43,9 @@ The <action> type attribute can be add,u
<body>
<release version="1.4.1" date="tba" description="1.4 Maintenance release">
+ <action issue="VALIDATOR-342" dev="sebb" type="fix" due-to="Donal Murtagh">
+ URLValidator returns false for http://example.rocks
+ </action>
<action issue="VALIDATOR-235" dev="sebb" type="fix" due-to="Brian PreuÃ">
UrlValidator rejects url with Unicode characters in domain label or TLD
</action>
Modified:
commons/proper/validator/trunk/src/test/java/org/apache/commons/validator/routines/UrlValidatorTest.java
URL:
http://svn.apache.org/viewvc/commons/proper/validator/trunk/src/test/java/org/apache/commons/validator/routines/UrlValidatorTest.java?rev=1649975&r1=1649974&r2=1649975&view=diff
==============================================================================
---
commons/proper/validator/trunk/src/test/java/org/apache/commons/validator/routines/UrlValidatorTest.java
(original)
+++
commons/proper/validator/trunk/src/test/java/org/apache/commons/validator/routines/UrlValidatorTest.java
Tue Jan 6 23:50:46 2015
@@ -295,6 +295,12 @@ public class UrlValidatorTest extends Te
assertFalse(urlValidator.isValid("http://www.cnn.invalid./";)); //
check . does not affect invalid domains
}
+ public void testValidator342(){
+ UrlValidator urlValidator = new UrlValidator();
+ assertTrue(urlValidator.isValid("http://example.rocks/";));
+ assertTrue(urlValidator.isValid("http://example.rocks";));
+ }
+
static boolean incrementTestPartsIndex(int[] testPartsIndex, Object[]
testParts) {
boolean carry = true; //add 1 to lowest order part.
boolean maxIndex = true;
