Author: britter Date: Sat Dec 27 16:45:42 2014 New Revision: 1648067 URL: http://svn.apache.org/r1648067 Log: LANG-1071: Fix wrong examples in JavaDoc of StringUtils.replaceEachRepeatedly(...), StringUtils.replaceEach(...). Thanks to Arno Noordover.
Modified: commons/proper/lang/trunk/src/changes/changes.xml commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/StringUtils.java Modified: commons/proper/lang/trunk/src/changes/changes.xml URL: http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/changes/changes.xml?rev=1648067&r1=1648066&r2=1648067&view=diff ============================================================================== --- commons/proper/lang/trunk/src/changes/changes.xml [utf-8] (original) +++ commons/proper/lang/trunk/src/changes/changes.xml [utf-8] Sat Dec 27 16:45:42 2014 @@ -22,6 +22,7 @@ <body> <release version="3.4" date="tba" description="tba"> + <action issue="LANG-1071" type="update" dev="britter" due-to="Arno Noordover">Fix wrong examples in JavaDoc of StringUtils.replaceEachRepeatedly(...), StringUtils.replaceEach(...)</action> <action issue="LANG-883" type="add" dev="britter" due-to="Daniel Stewart">Add StringUtils.containsAny(CharSequence, CharSequence...) method</action> <action issue="LANG-1073" type="fix" dev="kinow" due-to="haiyang li">Read wrong component type of array in add in ArrayUtils</action> <action issue="LANG-1077" type="fix" dev="kinow" due-to="haiyang li">StringUtils.ordinalIndexOf("aaaaaa", "aa", 2) != 3 in StringUtils</action> Modified: commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/StringUtils.java URL: http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/StringUtils.java?rev=1648067&r1=1648066&r2=1648067&view=diff ============================================================================== --- commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/StringUtils.java (original) +++ commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/StringUtils.java Sat Dec 27 16:45:42 2014 @@ -4620,20 +4620,18 @@ public class StringUtils { * </p> * * <pre> - * StringUtils.replaceEach(null, *, *, *) = null - * StringUtils.replaceEach("", *, *, *) = "" - * StringUtils.replaceEach("aba", null, null, *) = "aba" - * StringUtils.replaceEach("aba", new String[0], null, *) = "aba" - * StringUtils.replaceEach("aba", null, new String[0], *) = "aba" - * StringUtils.replaceEach("aba", new String[]{"a"}, null, *) = "aba" - * StringUtils.replaceEach("aba", new String[]{"a"}, new String[]{""}, *) = "b" - * StringUtils.replaceEach("aba", new String[]{null}, new String[]{"a"}, *) = "aba" - * StringUtils.replaceEach("abcde", new String[]{"ab", "d"}, new String[]{"w", "t"}, *) = "wcte" + * StringUtils.replaceEachRepeatedly(null, *, *) = null + * StringUtils.replaceEachRepeatedly("", *, *) = "" + * StringUtils.replaceEachRepeatedly("aba", null, null) = "aba" + * StringUtils.replaceEachRepeatedly("aba", new String[0], null) = "aba" + * StringUtils.replaceEachRepeatedly("aba", null, new String[0]) = "aba" + * StringUtils.replaceEachRepeatedly("aba", new String[]{"a"}, null) = "aba" + * StringUtils.replaceEachRepeatedly("aba", new String[]{"a"}, new String[]{""}) = "b" + * StringUtils.replaceEachRepeatedly("aba", new String[]{null}, new String[]{"a"}) = "aba" + * StringUtils.replaceEachRepeatedly("abcde", new String[]{"ab", "d"}, new String[]{"w", "t"}) = "wcte" * (example of how it repeats) - * StringUtils.replaceEach("abcde", new String[]{"ab", "d"}, new String[]{"d", "t"}, false) = "dcte" - * StringUtils.replaceEach("abcde", new String[]{"ab", "d"}, new String[]{"d", "t"}, true) = "tcte" - * StringUtils.replaceEach("abcde", new String[]{"ab", "d"}, new String[]{"d", "ab"}, true) = IllegalStateException - * StringUtils.replaceEach("abcde", new String[]{"ab", "d"}, new String[]{"d", "ab"}, false) = "dcabe" + * StringUtils.replaceEachRepeatedly("abcde", new String[]{"ab", "d"}, new String[]{"d", "t"}) = "tcte" + * StringUtils.replaceEachRepeatedly("abcde", new String[]{"ab", "d"}, new String[]{"d", "ab"}) = IllegalStateException * </pre> * * @param text @@ -4661,7 +4659,9 @@ public class StringUtils { /** * <p> - * Replaces all occurrences of Strings within another String. + * Replace all occurrences of Strings within another String. + * This is a private recursive helper method for {@link #replaceEachRepeatedly(String, String[], String[])} and + * {@link #replaceEach(String, String[], String[])} * </p> * * <p> @@ -4671,19 +4671,19 @@ public class StringUtils { * </p> * * <pre> - * StringUtils.replaceEach(null, *, *, *) = null - * StringUtils.replaceEach("", *, *, *) = "" - * StringUtils.replaceEach("aba", null, null, *) = "aba" - * StringUtils.replaceEach("aba", new String[0], null, *) = "aba" - * StringUtils.replaceEach("aba", null, new String[0], *) = "aba" - * StringUtils.replaceEach("aba", new String[]{"a"}, null, *) = "aba" - * StringUtils.replaceEach("aba", new String[]{"a"}, new String[]{""}, *) = "b" - * StringUtils.replaceEach("aba", new String[]{null}, new String[]{"a"}, *) = "aba" - * StringUtils.replaceEach("abcde", new String[]{"ab", "d"}, new String[]{"w", "t"}, *) = "wcte" + * StringUtils.replaceEach(null, *, *, *, *) = null + * StringUtils.replaceEach("", *, *, *, *) = "" + * StringUtils.replaceEach("aba", null, null, *, *) = "aba" + * StringUtils.replaceEach("aba", new String[0], null, *, *) = "aba" + * StringUtils.replaceEach("aba", null, new String[0], *, *) = "aba" + * StringUtils.replaceEach("aba", new String[]{"a"}, null, *, *) = "aba" + * StringUtils.replaceEach("aba", new String[]{"a"}, new String[]{""}, *, >=0) = "b" + * StringUtils.replaceEach("aba", new String[]{null}, new String[]{"a"}, *, >=0) = "aba" + * StringUtils.replaceEach("abcde", new String[]{"ab", "d"}, new String[]{"w", "t"}, *, >=0) = "wcte" * (example of how it repeats) - * StringUtils.replaceEach("abcde", new String[]{"ab", "d"}, new String[]{"d", "t"}, false) = "dcte" - * StringUtils.replaceEach("abcde", new String[]{"ab", "d"}, new String[]{"d", "t"}, true) = "tcte" - * StringUtils.replaceEach("abcde", new String[]{"ab", "d"}, new String[]{"d", "ab"}, *) = IllegalStateException + * StringUtils.replaceEach("abcde", new String[]{"ab", "d"}, new String[]{"d", "t"}, false, >=0) = "dcte" + * StringUtils.replaceEach("abcde", new String[]{"ab", "d"}, new String[]{"d", "t"}, true, >=2) = "tcte" + * StringUtils.replaceEach("abcde", new String[]{"ab", "d"}, new String[]{"d", "ab"}, *, *) = IllegalStateException * </pre> * * @param text