Author: psteitz
Date: Fri Dec 26 17:40:11 2014
New Revision: 1648001
URL: http://svn.apache.org/r1648001
Log:
Fixed errors in comments; reduced execution time of POOL-259 tests.
Modified:
commons/proper/pool/trunk/src/test/java/org/apache/commons/pool2/impl/TestGenericKeyedObjectPool.java
commons/proper/pool/trunk/src/test/java/org/apache/commons/pool2/impl/TestGenericObjectPool.java
Modified:
commons/proper/pool/trunk/src/test/java/org/apache/commons/pool2/impl/TestGenericKeyedObjectPool.java
URL:
http://svn.apache.org/viewvc/commons/proper/pool/trunk/src/test/java/org/apache/commons/pool2/impl/TestGenericKeyedObjectPool.java?rev=1648001&r1=1648000&r2=1648001&view=diff
==============================================================================
---
commons/proper/pool/trunk/src/test/java/org/apache/commons/pool2/impl/TestGenericKeyedObjectPool.java
(original)
+++
commons/proper/pool/trunk/src/test/java/org/apache/commons/pool2/impl/TestGenericKeyedObjectPool.java
Fri Dec 26 17:40:11 2014
@@ -1575,19 +1575,20 @@ public class TestGenericKeyedObjectPool
public void testClientWaitStats() throws Exception {
SimpleFactory<String> factory = new SimpleFactory<String>();
// Give makeObject a little latency
- factory.setMakeLatency(1000);
+ factory.setMakeLatency(200);
final GenericKeyedObjectPool<String, String> pool = new
GenericKeyedObjectPool<String, String>(
factory, new GenericKeyedObjectPoolConfig());
String s = pool.borrowObject("one");
- // First borrow waits on create, so wait time should be at least 100 ms
+ // First borrow waits on create, so wait time should be at least 200 ms
+ // Allow 100ms error in clock times
Assert.assertTrue(pool.getMaxBorrowWaitTimeMillis() >= 100);
Assert.assertTrue(pool.getMeanBorrowWaitTimeMillis() >= 100);
pool.returnObject("one", s);
pool.borrowObject("one");
- // Second borrow does not have to wait on create, average should be
about 50
- Assert.assertTrue(pool.getMaxBorrowWaitTimeMillis() > 500);
- Assert.assertTrue(pool.getMeanBorrowWaitTimeMillis() < 800);
- Assert.assertTrue(pool.getMeanBorrowWaitTimeMillis() > 100);
+ // Second borrow does not have to wait on create, average should be
about 100
+ Assert.assertTrue(pool.getMaxBorrowWaitTimeMillis() > 100);
+ Assert.assertTrue(pool.getMeanBorrowWaitTimeMillis() < 200);
+ Assert.assertTrue(pool.getMeanBorrowWaitTimeMillis() > 20);
}
// POOL-276
Modified:
commons/proper/pool/trunk/src/test/java/org/apache/commons/pool2/impl/TestGenericObjectPool.java
URL:
http://svn.apache.org/viewvc/commons/proper/pool/trunk/src/test/java/org/apache/commons/pool2/impl/TestGenericObjectPool.java?rev=1648001&r1=1648000&r2=1648001&view=diff
==============================================================================
---
commons/proper/pool/trunk/src/test/java/org/apache/commons/pool2/impl/TestGenericObjectPool.java
(original)
+++
commons/proper/pool/trunk/src/test/java/org/apache/commons/pool2/impl/TestGenericObjectPool.java
Fri Dec 26 17:40:11 2014
@@ -2357,19 +2357,20 @@ public class TestGenericObjectPool exten
public void testClientWaitStats() throws Exception {
SimpleFactory factory = new SimpleFactory();
// Give makeObject a little latency
- factory.setMakeLatency(1000);
+ factory.setMakeLatency(200);
final GenericObjectPool<String> pool = new GenericObjectPool<String>(
factory, new GenericObjectPoolConfig());
String s = pool.borrowObject();
- // First borrow waits on create, so wait time should be at least 100 ms
+ // First borrow waits on create, so wait time should be at least 200 ms
+ // Allow 100ms error in clock times
Assert.assertTrue(pool.getMaxBorrowWaitTimeMillis() >= 100);
Assert.assertTrue(pool.getMeanBorrowWaitTimeMillis() >= 100);
pool.returnObject(s);
pool.borrowObject();
- // Second borrow does not have to wait on create, average should be
about 50
- Assert.assertTrue(pool.getMaxBorrowWaitTimeMillis() > 500);
- Assert.assertTrue(pool.getMeanBorrowWaitTimeMillis() < 800);
- Assert.assertTrue(pool.getMeanBorrowWaitTimeMillis() > 100);
+ // Second borrow does not have to wait on create, average should be
about 100
+ Assert.assertTrue(pool.getMaxBorrowWaitTimeMillis() > 100);
+ Assert.assertTrue(pool.getMeanBorrowWaitTimeMillis() < 200);
+ Assert.assertTrue(pool.getMeanBorrowWaitTimeMillis() > 20);
}
// POOL-276
