Author: psteitz Date: Thu Dec 25 03:38:57 2014 New Revision: 1647869 URL: http://svn.apache.org/r1647869 Log: Made POOL-259 tests less dependent on system clock resolution.
Modified: commons/proper/pool/trunk/src/test/java/org/apache/commons/pool2/impl/TestGenericKeyedObjectPool.java commons/proper/pool/trunk/src/test/java/org/apache/commons/pool2/impl/TestGenericObjectPool.java Modified: commons/proper/pool/trunk/src/test/java/org/apache/commons/pool2/impl/TestGenericKeyedObjectPool.java URL: http://svn.apache.org/viewvc/commons/proper/pool/trunk/src/test/java/org/apache/commons/pool2/impl/TestGenericKeyedObjectPool.java?rev=1647869&r1=1647868&r2=1647869&view=diff ============================================================================== --- commons/proper/pool/trunk/src/test/java/org/apache/commons/pool2/impl/TestGenericKeyedObjectPool.java (original) +++ commons/proper/pool/trunk/src/test/java/org/apache/commons/pool2/impl/TestGenericKeyedObjectPool.java Thu Dec 25 03:38:57 2014 @@ -1575,7 +1575,7 @@ public class TestGenericKeyedObjectPool public void testClientWaitStats() throws Exception { SimpleFactory<String> factory = new SimpleFactory<String>(); // Give makeObject a little latency - factory.setMakeLatency(100); + factory.setMakeLatency(1000); final GenericKeyedObjectPool<String, String> pool = new GenericKeyedObjectPool<String, String>( factory, new GenericKeyedObjectPoolConfig()); String s = pool.borrowObject("one"); @@ -1585,9 +1585,9 @@ public class TestGenericKeyedObjectPool pool.returnObject("one", s); pool.borrowObject("one"); // Second borrow does not have to wait on create, average should be about 50 - Assert.assertTrue(pool.getMaxBorrowWaitTimeMillis() >= 100); - Assert.assertTrue(pool.getMeanBorrowWaitTimeMillis() < 60); - Assert.assertTrue(pool.getMeanBorrowWaitTimeMillis() > 40); + Assert.assertTrue(pool.getMaxBorrowWaitTimeMillis() > 500); + Assert.assertTrue(pool.getMeanBorrowWaitTimeMillis() < 800); + Assert.assertTrue(pool.getMeanBorrowWaitTimeMillis() > 100); } // POOL-276 Modified: commons/proper/pool/trunk/src/test/java/org/apache/commons/pool2/impl/TestGenericObjectPool.java URL: http://svn.apache.org/viewvc/commons/proper/pool/trunk/src/test/java/org/apache/commons/pool2/impl/TestGenericObjectPool.java?rev=1647869&r1=1647868&r2=1647869&view=diff ============================================================================== --- commons/proper/pool/trunk/src/test/java/org/apache/commons/pool2/impl/TestGenericObjectPool.java (original) +++ commons/proper/pool/trunk/src/test/java/org/apache/commons/pool2/impl/TestGenericObjectPool.java Thu Dec 25 03:38:57 2014 @@ -2357,7 +2357,7 @@ public class TestGenericObjectPool exten public void testClientWaitStats() throws Exception { SimpleFactory factory = new SimpleFactory(); // Give makeObject a little latency - factory.setMakeLatency(100); + factory.setMakeLatency(1000); final GenericObjectPool<String> pool = new GenericObjectPool<String>( factory, new GenericObjectPoolConfig()); String s = pool.borrowObject(); @@ -2367,9 +2367,9 @@ public class TestGenericObjectPool exten pool.returnObject(s); pool.borrowObject(); // Second borrow does not have to wait on create, average should be about 50 - Assert.assertTrue(pool.getMaxBorrowWaitTimeMillis() >= 100); - Assert.assertTrue(pool.getMeanBorrowWaitTimeMillis() < 60); - Assert.assertTrue(pool.getMeanBorrowWaitTimeMillis() > 40); + Assert.assertTrue(pool.getMaxBorrowWaitTimeMillis() > 500); + Assert.assertTrue(pool.getMeanBorrowWaitTimeMillis() < 800); + Assert.assertTrue(pool.getMeanBorrowWaitTimeMillis() > 100); } // POOL-276