Author: britter
Date: Thu Oct  9 17:22:05 2014
New Revision: 1630537

URL: http://svn.apache.org/r1630537
Log:
Don't swallow test errors silently. Test works when running mvn clean test, so 
remove try-catch-block.

Modified:
    
commons/proper/dbutils/trunk/src/test/java/org/apache/commons/dbutils/QueryLoaderTest.java

Modified: 
commons/proper/dbutils/trunk/src/test/java/org/apache/commons/dbutils/QueryLoaderTest.java
URL: 
http://svn.apache.org/viewvc/commons/proper/dbutils/trunk/src/test/java/org/apache/commons/dbutils/QueryLoaderTest.java?rev=1630537&r1=1630536&r2=1630537&view=diff
==============================================================================
--- 
commons/proper/dbutils/trunk/src/test/java/org/apache/commons/dbutils/QueryLoaderTest.java
 (original)
+++ 
commons/proper/dbutils/trunk/src/test/java/org/apache/commons/dbutils/QueryLoaderTest.java
 Thu Oct  9 17:22:05 2014
@@ -28,22 +28,15 @@ public class QueryLoaderTest extends Bas
         "/org/apache/commons/dbutils/TestQueries.properties";
 
     public void testLoad() throws IOException {
-        try {
-            QueryLoader loader = QueryLoader.instance();
-            Map<String,String> q = loader.load(QUERIES);
-            Map<String,String> q2 = loader.load(QUERIES);
-            assertTrue(q == q2); // pointer comparison should return true
-            assertEquals("SELECT * FROM SomeTable", q.get("test.query"));
+        QueryLoader loader = QueryLoader.instance();
+        Map<String,String> q = loader.load(QUERIES);
+        Map<String,String> q2 = loader.load(QUERIES);
+        assertTrue(q == q2); // pointer comparison should return true
+        assertEquals("SELECT * FROM SomeTable", q.get("test.query"));
 
-            loader.unload(QUERIES);
-            Map<String,String> q3 = loader.load(QUERIES);
-            assertTrue(q != q3); // pointer comparison should return false
-
-        } catch (IllegalArgumentException e) {
-            // TODO Figure out why the Maven build can't find the properties
-            // file.  The tests run fine in Eclipse so just catch this
-            // exception for now.
-        }
+        loader.unload(QUERIES);
+        Map<String,String> q3 = loader.load(QUERIES);
+        assertTrue(q != q3); // pointer comparison should return false
     }
 
 }


Reply via email to