Author: sebb Date: Tue Sep 2 19:03:36 2014 New Revision: 1622092 URL: http://svn.apache.org/r1622092 Log: Not thread-safe without volatile - needed to ensure safe publication
Modified: commons/proper/pool/trunk/src/main/java/org/apache/commons/pool2/impl/BaseGenericObjectPool.java Modified: commons/proper/pool/trunk/src/main/java/org/apache/commons/pool2/impl/BaseGenericObjectPool.java URL: http://svn.apache.org/viewvc/commons/proper/pool/trunk/src/main/java/org/apache/commons/pool2/impl/BaseGenericObjectPool.java?rev=1622092&r1=1622091&r2=1622092&view=diff ============================================================================== --- commons/proper/pool/trunk/src/main/java/org/apache/commons/pool2/impl/BaseGenericObjectPool.java (original) +++ commons/proper/pool/trunk/src/main/java/org/apache/commons/pool2/impl/BaseGenericObjectPool.java Tue Sep 2 19:03:36 2014 @@ -113,7 +113,7 @@ public abstract class BaseGenericObjectP private final StatsStore waitTimes = new StatsStore(MEAN_TIMING_STATS_CACHE_SIZE); private final Object maxBorrowWaitTimeMillisLock = new Object(); private volatile long maxBorrowWaitTimeMillis = 0; // @GuardedBy("maxBorrowWaitTimeMillisLock") - private SwallowedExceptionListener swallowedExceptionListener = null; + private volatile SwallowedExceptionListener swallowedExceptionListener = null; /**