Author: sebb
Date: Wed Feb 12 23:19:37 2014
New Revision: 1567796
URL: http://svn.apache.org/r1567796
Log:
LANG-973 Make some private fields final
Modified:
commons/proper/lang/trunk/src/changes/changes.xml
commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/JavaVersion.java
commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/NotImplementedException.java
commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/time/FastDateParser.java
commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/time/FastDatePrinter.java
Modified: commons/proper/lang/trunk/src/changes/changes.xml
URL:
http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/changes/changes.xml?rev=1567796&r1=1567795&r2=1567796&view=diff
==============================================================================
--- commons/proper/lang/trunk/src/changes/changes.xml [utf-8] (original)
+++ commons/proper/lang/trunk/src/changes/changes.xml [utf-8] Wed Feb 12
23:19:37 2014
@@ -22,6 +22,7 @@
<body>
<release version="3.3" date="TBA" description="Bugfix and Feature release">
+ <action issue="LANG-973" type="fix" dev="sebb">Make some private fields
final</action>
<action issue="LANG-971" type="fix"
dev="sebb">NumberUtils#isNumber(String) fails to reject invalid Octal
numbers</action>
<action issue="LANG-972" type="fix" dev="sebb">NumberUtils#isNumber does
not allow for hex 0XABCD</action>
<action issue="LANG-969" type="fix" dev="ggregory" due-to="Matt
Bishop">StringUtils.toEncodedString(byte[], Charset) needlessly throws
UnsupportedEncodingException</action>
Modified:
commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/JavaVersion.java
URL:
http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/JavaVersion.java?rev=1567796&r1=1567795&r2=1567796&view=diff
==============================================================================
---
commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/JavaVersion.java
(original)
+++
commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/JavaVersion.java
Wed Feb 12 23:19:37 2014
@@ -74,11 +74,11 @@ public enum JavaVersion {
/**
* The float value.
*/
- private float value;
+ private final float value;
/**
* The standard name.
*/
- private String name;
+ private final String name;
/**
* Constructor.
Modified:
commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/NotImplementedException.java
URL:
http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/NotImplementedException.java?rev=1567796&r1=1567795&r2=1567796&view=diff
==============================================================================
---
commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/NotImplementedException.java
(original)
+++
commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/NotImplementedException.java
Wed Feb 12 23:19:37 2014
@@ -45,7 +45,7 @@ public class NotImplementedException ext
private static final long serialVersionUID = 20131021L;
- private String code;
+ private final String code;
/**
* Constructs a NotImplementedException.
@@ -54,7 +54,7 @@ public class NotImplementedException ext
* @since 3.2
*/
public NotImplementedException(final String message) {
- super(message);
+ this(message, (String) null);
}
/**
@@ -64,7 +64,7 @@ public class NotImplementedException ext
* @since 3.2
*/
public NotImplementedException(final Throwable cause) {
- super(cause);
+ this(cause, null);
}
/**
@@ -75,7 +75,7 @@ public class NotImplementedException ext
* @since 3.2
*/
public NotImplementedException(final String message, final Throwable
cause) {
- super(message, cause);
+ this(message, cause, null);
}
/**
Modified:
commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/time/FastDateParser.java
URL:
http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/time/FastDateParser.java?rev=1567796&r1=1567795&r2=1567796&view=diff
==============================================================================
---
commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/time/FastDateParser.java
(original)
+++
commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/time/FastDateParser.java
Wed Feb 12 23:19:37 2014
@@ -491,7 +491,7 @@ public class FastDateParser implements D
}
@SuppressWarnings("unchecked") // OK because we are creating an array with
no entries
- private static ConcurrentMap<Locale, Strategy>[] caches = new
ConcurrentMap[Calendar.FIELD_COUNT];
+ private static final ConcurrentMap<Locale, Strategy>[] caches = new
ConcurrentMap[Calendar.FIELD_COUNT];
/**
* Get a cache of Strategies for a particular field
Modified:
commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/time/FastDatePrinter.java
URL:
http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/time/FastDatePrinter.java?rev=1567796&r1=1567795&r2=1567796&view=diff
==============================================================================
---
commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/time/FastDatePrinter.java
(original)
+++
commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/time/FastDatePrinter.java
Wed Feb 12 23:19:37 2014
@@ -1085,7 +1085,7 @@ public class FastDatePrinter implements
//-----------------------------------------------------------------------
- private static ConcurrentMap<TimeZoneDisplayKey, String>
cTimeZoneDisplayCache =
+ private static final ConcurrentMap<TimeZoneDisplayKey, String>
cTimeZoneDisplayCache =
new ConcurrentHashMap<TimeZoneDisplayKey, String>(7);
/**
* <p>Gets the time zone display name, using a cache for performance.</p>
