Author: damjan Date: Tue Oct 22 01:21:49 2013 New Revision: 1534447 URL: http://svn.apache.org/r1534447 Log: Eliminate RgbeConstants.
Jira issue key: IMAGING-118 Removed: commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging/formats/rgbe/RgbeConstants.java Modified: commons/proper/imaging/trunk/src/changes/changes.xml commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging/formats/rgbe/RgbeInfo.java Modified: commons/proper/imaging/trunk/src/changes/changes.xml URL: http://svn.apache.org/viewvc/commons/proper/imaging/trunk/src/changes/changes.xml?rev=1534447&r1=1534446&r2=1534447&view=diff ============================================================================== --- commons/proper/imaging/trunk/src/changes/changes.xml (original) +++ commons/proper/imaging/trunk/src/changes/changes.xml Tue Oct 22 01:21:49 2013 @@ -46,6 +46,9 @@ The <action> type attribute can be add,u <body> <release version="1.0" date="TBA" description="TBA"> + <action issue="IMAGING-118" dev="damjan" type="fix"> + interface RgbeConstants contains mutable array. + </action> <action issue="IMAGING-114" dev="damjan" type="fix"> ComSegment.comment is a public final byte array. </action> Modified: commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging/formats/rgbe/RgbeInfo.java URL: http://svn.apache.org/viewvc/commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging/formats/rgbe/RgbeInfo.java?rev=1534447&r1=1534446&r2=1534447&view=diff ============================================================================== --- commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging/formats/rgbe/RgbeInfo.java (original) +++ commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging/formats/rgbe/RgbeInfo.java Tue Oct 22 01:21:49 2013 @@ -32,6 +32,10 @@ import org.apache.commons.imaging.common import org.apache.commons.imaging.util.Debug; class RgbeInfo extends BinaryFunctions { + // #?RADIANCE + private static byte[] HEADER = new byte[] { + 0x23, 0x3F, 0x52, 0x41, 0x44, 0x49, 0x41, 0x4E, 0x43, 0x45 + }; private static final Pattern RESOLUTION_STRING = Pattern .compile("-Y (\\d+) \\+X (\\d+)"); @@ -96,7 +100,7 @@ class RgbeInfo extends BinaryFunctions { } private void readMetadata() throws IOException, ImageReadException { - in.readAndVerifyBytes(RgbeConstants.HEADER, + in.readAndVerifyBytes(HEADER, "Not a valid HDR: Incorrect Header"); final InfoHeaderReader reader = new InfoHeaderReader(in);