Author: tn
Date: Fri Oct 11 20:47:20 2013
New Revision: 1531413
URL: http://svn.apache.org/r1531413
Log:
[MATH-1037] Fix GeometricDistributionTest. Thanks to Aleksei Dievskii for the
report.
Modified:
commons/proper/math/trunk/src/changes/changes.xml
commons/proper/math/trunk/src/test/java/org/apache/commons/math3/distribution/GeometricDistributionTest.java
commons/proper/math/trunk/src/test/java/org/apache/commons/math3/distribution/IntegerDistributionAbstractTest.java
Modified: commons/proper/math/trunk/src/changes/changes.xml
URL:
http://svn.apache.org/viewvc/commons/proper/math/trunk/src/changes/changes.xml?rev=1531413&r1=1531412&r2=1531413&view=diff
==============================================================================
--- commons/proper/math/trunk/src/changes/changes.xml (original)
+++ commons/proper/math/trunk/src/changes/changes.xml Fri Oct 11 20:47:20 2013
@@ -51,6 +51,10 @@ If the output is not quite correct, chec
</properties>
<body>
<release version="x.y" date="TBD" description="TBD">
+ <action dev="tn" type="fix" issue="MATH-1037" due-to="Aleksei Dievskii">
+ Fix a typo in the "GeometricDistributionTest" and ensure that a
meaningful
+ tolerance value is used when comparing test results with expected
values.
+ </action>
<action dev="psteitz" type="add" issue="MATH-1034" due-to="Thorsten
Schaefer">
Added exact binomial test implementation.
</action>
Modified:
commons/proper/math/trunk/src/test/java/org/apache/commons/math3/distribution/GeometricDistributionTest.java
URL:
http://svn.apache.org/viewvc/commons/proper/math/trunk/src/test/java/org/apache/commons/math3/distribution/GeometricDistributionTest.java?rev=1531413&r1=1531412&r2=1531413&view=diff
==============================================================================
---
commons/proper/math/trunk/src/test/java/org/apache/commons/math3/distribution/GeometricDistributionTest.java
(original)
+++
commons/proper/math/trunk/src/test/java/org/apache/commons/math3/distribution/GeometricDistributionTest.java
Fri Oct 11 20:47:20 2013
@@ -26,6 +26,10 @@ import org.junit.Test;
*/
public class GeometricDistributionTest extends IntegerDistributionAbstractTest
{
+ public GeometricDistributionTest() {
+ setTolerance(1e-7);
+ }
+
// -------------- Implementations for abstract methods --------------------
/** Creates the default discrete distribution instance to use in tests. */
@@ -39,7 +43,7 @@ public class GeometricDistributionTest e
public int[] makeDensityTestPoints() {
return new int[] { -1, 0, 1, 2, 3, 4, 5, 6, 7, 8,
9, 10, 11, 12, 13, 14, 15, 16, 17, 18,
- 29, 20, 21, 22, 23, 24, 25, 26, 27, 28 };
+ 19, 20, 21, 22, 23, 24, 25, 26, 27, 28 };
}
/** Creates the default probability density test expected values */
Modified:
commons/proper/math/trunk/src/test/java/org/apache/commons/math3/distribution/IntegerDistributionAbstractTest.java
URL:
http://svn.apache.org/viewvc/commons/proper/math/trunk/src/test/java/org/apache/commons/math3/distribution/IntegerDistributionAbstractTest.java?rev=1531413&r1=1531412&r2=1531413&view=diff
==============================================================================
---
commons/proper/math/trunk/src/test/java/org/apache/commons/math3/distribution/IntegerDistributionAbstractTest.java
(original)
+++
commons/proper/math/trunk/src/test/java/org/apache/commons/math3/distribution/IntegerDistributionAbstractTest.java
Fri Oct 11 20:47:20 2013
@@ -135,7 +135,7 @@ public abstract class IntegerDistributio
for (int i = 0; i < densityTestPoints.length; i++) {
Assert.assertEquals("Incorrect density value returned for " +
densityTestPoints[i],
densityTestValues[i],
- distribution.probability(densityTestPoints[i]), tolerance);
+ distribution.probability(densityTestPoints[i]),
getTolerance());
}
}
@@ -147,7 +147,7 @@ public abstract class IntegerDistributio
for (int i = 0; i < cumulativeTestPoints.length; i++) {
Assert.assertEquals("Incorrect cumulative probability value
returned for " + cumulativeTestPoints[i],
cumulativeTestValues[i],
-
distribution.cumulativeProbability(cumulativeTestPoints[i]), tolerance);
+
distribution.cumulativeProbability(cumulativeTestPoints[i]), getTolerance());
}
}
@@ -199,7 +199,7 @@ public abstract class IntegerDistributio
Assert.assertEquals("Cumulative probability mmust be 0 below support
lower bound.",
0.0, distribution.cumulativeProbability(lower - 1), 0.0);
Assert.assertEquals("Cumulative probability of support lower bound
must be equal to probability mass at this point.",
- distribution.probability(lower),
distribution.cumulativeProbability(lower), tolerance);
+ distribution.probability(lower),
distribution.cumulativeProbability(lower), getTolerance());
Assert.assertEquals("Inverse cumulative probability of 0 must be equal
to support lower bound.",
lower, distribution.inverseCumulativeProbability(0.0));
