Author: luc
Date: Mon Oct 1 19:32:55 2012
New Revision: 1392553
URL: http://svn.apache.org/viewvc?rev=1392553&view=rev
Log:
Track "TODO:" with checkstyle
Modified:
commons/sandbox/nabla/trunk/checkstyle.xml
commons/sandbox/nabla/trunk/src/main/java/org/apache/commons/nabla/caching/FetchDifferentiator.java
commons/sandbox/nabla/trunk/src/main/java/org/apache/commons/nabla/forward/ForwardModeDifferentiator.java
commons/sandbox/nabla/trunk/src/main/java/org/apache/commons/nabla/forward/analysis/MethodDifferentiator.java
commons/sandbox/nabla/trunk/src/main/java/org/apache/commons/nabla/forward/instructions/InvokeStaticTransformer.java
Modified: commons/sandbox/nabla/trunk/checkstyle.xml
URL:
http://svn.apache.org/viewvc/commons/sandbox/nabla/trunk/checkstyle.xml?rev=1392553&r1=1392552&r2=1392553&view=diff
==============================================================================
--- commons/sandbox/nabla/trunk/checkstyle.xml (original)
+++ commons/sandbox/nabla/trunk/checkstyle.xml Mon Oct 1 19:32:55 2012
@@ -163,7 +163,7 @@
<property name="caseIndent" value="4"/>
</module>
- <!-- <module name="TodoComment" /> -->
+ <module name="TodoComment" />
</module>
Modified:
commons/sandbox/nabla/trunk/src/main/java/org/apache/commons/nabla/caching/FetchDifferentiator.java
URL:
http://svn.apache.org/viewvc/commons/sandbox/nabla/trunk/src/main/java/org/apache/commons/nabla/caching/FetchDifferentiator.java?rev=1392553&r1=1392552&r2=1392553&view=diff
==============================================================================
---
commons/sandbox/nabla/trunk/src/main/java/org/apache/commons/nabla/caching/FetchDifferentiator.java
(original)
+++
commons/sandbox/nabla/trunk/src/main/java/org/apache/commons/nabla/caching/FetchDifferentiator.java
Mon Oct 1 19:32:55 2012
@@ -30,7 +30,7 @@ public class FetchDifferentiator impleme
/** {@inheritDoc} */
public UnivariateDifferentiableVectorFunction differentiate(final
UnivariateVectorFunction function) {
- // TODO implement differentiation by fetching an already derived class
+ // TODO: implement differentiation by fetching an already derived class
return null;
}
Modified:
commons/sandbox/nabla/trunk/src/main/java/org/apache/commons/nabla/forward/ForwardModeDifferentiator.java
URL:
http://svn.apache.org/viewvc/commons/sandbox/nabla/trunk/src/main/java/org/apache/commons/nabla/forward/ForwardModeDifferentiator.java?rev=1392553&r1=1392552&r2=1392553&view=diff
==============================================================================
---
commons/sandbox/nabla/trunk/src/main/java/org/apache/commons/nabla/forward/ForwardModeDifferentiator.java
(original)
+++
commons/sandbox/nabla/trunk/src/main/java/org/apache/commons/nabla/forward/ForwardModeDifferentiator.java
Mon Oct 1 19:32:55 2012
@@ -96,7 +96,7 @@ public class ForwardModeDifferentiator i
* @param out output stream where to dump the cache
*/
public void dumpCache(final OutputStream out) {
- // TODO implement cache persistence
+ // TODO: implement cache persistence
throw new RuntimeException("not implemented yet");
}
Modified:
commons/sandbox/nabla/trunk/src/main/java/org/apache/commons/nabla/forward/analysis/MethodDifferentiator.java
URL:
http://svn.apache.org/viewvc/commons/sandbox/nabla/trunk/src/main/java/org/apache/commons/nabla/forward/analysis/MethodDifferentiator.java?rev=1392553&r1=1392552&r2=1392553&view=diff
==============================================================================
---
commons/sandbox/nabla/trunk/src/main/java/org/apache/commons/nabla/forward/analysis/MethodDifferentiator.java
(original)
+++
commons/sandbox/nabla/trunk/src/main/java/org/apache/commons/nabla/forward/analysis/MethodDifferentiator.java
Mon Oct 1 19:32:55 2012
@@ -395,13 +395,13 @@ public class MethodDifferentiator {
useLocal(((VarInsnNode) insn).var, 4);
return new DLoadTransformer().getReplacement(insn, this);
case Opcodes.DALOAD :
- // TODO add support for DALOAD differentiation
+ // TODO: add support for DALOAD differentiation
throw new RuntimeException("DALOAD not handled yet");
case Opcodes.DSTORE :
useLocal(((VarInsnNode) insn).var, 4);
return new DStoreTransformer().getReplacement(insn, this);
case Opcodes.DASTORE :
- // TODO add support for DASTORE differentiation
+ // TODO: add support for DASTORE differentiation
throw new RuntimeException("DASTORE not handled yet");
case Opcodes.DUP2 :
return new Dup2Transformer().getReplacement(insn, this);
@@ -438,41 +438,41 @@ public class MethodDifferentiator {
case Opcodes.DCMPG :
return new DcmpTransformer(stack0Converted,
stack1Converted).getReplacement(insn, this);
case Opcodes.DRETURN :
- // TODO the constructor parameter forced to true seems
strange...
+ // TODO: the constructor parameter forced to true seems
strange...
return new DReturnTransformer(true).getReplacement(insn, this);
case Opcodes.GETSTATIC :
- // TODO add support for GETSTATIC differentiation
+ // TODO: add support for GETSTATIC differentiation
throw new RuntimeException("GETSTATIC not handled yet");
case Opcodes.PUTSTATIC :
- // TODO add support for PUTSTATIC differentiation
+ // TODO: add support for PUTSTATIC differentiation
throw new RuntimeException("PUTSTATIC not handled yet");
case Opcodes.GETFIELD :
return replaceGetField((FieldInsnNode) insn);
case Opcodes.PUTFIELD :
- // TODO add support for PUTFIELD differentiation
+ // TODO: add support for PUTFIELD differentiation
throw new RuntimeException("PUTFIELD not handled yet");
case Opcodes.INVOKEVIRTUAL :
- // TODO add support for INVOKEVIRTUAL differentiation
+ // TODO: add support for INVOKEVIRTUAL differentiation
throw new RuntimeException("INVOKEVIRTUAL not handled yet");
case Opcodes.INVOKESPECIAL :
- // TODO add support for INVOKESPECIAL differentiation
+ // TODO: add support for INVOKESPECIAL differentiation
throw new RuntimeException("INVOKESPECIAL not handled yet");
case Opcodes.INVOKESTATIC :
return new InvokeStaticTransformer(stack0Converted,
stack1Converted).getReplacement(insn, this);
case Opcodes.INVOKEINTERFACE :
- // TODO add support for INVOKEINTERFACE differentiation
+ // TODO: add support for INVOKEINTERFACE differentiation
throw new RuntimeException("INVOKEINTERFACE not handled yet");
case Opcodes.INVOKEDYNAMIC :
- // TODO add support for INVOKEDYNAMIC differentiation
+ // TODO: add support for INVOKEDYNAMIC differentiation
throw new RuntimeException("INVOKEDYNAMIC not handled yet");
case Opcodes.NEWARRAY :
- // TODO add support for NEWARRAY differentiation
+ // TODO: add support for NEWARRAY differentiation
throw new RuntimeException("NEWARRAY not handled yet");
case Opcodes.ANEWARRAY :
- // TODO add support for ANEWARRAY differentiation
+ // TODO: add support for ANEWARRAY differentiation
throw new RuntimeException("ANEWARRAY not handled yet");
case Opcodes.MULTIANEWARRAY :
- // TODO add support for MULTIANEWARRAY differentiation
+ // TODO: add support for MULTIANEWARRAY differentiation
throw new RuntimeException("MULTIANEWARRAY not handled yet");
default:
throw new
DifferentiationException(NablaMessages.UNABLE_TO_HANDLE_INSTRUCTION,
insn.getOpcode());
Modified:
commons/sandbox/nabla/trunk/src/main/java/org/apache/commons/nabla/forward/instructions/InvokeStaticTransformer.java
URL:
http://svn.apache.org/viewvc/commons/sandbox/nabla/trunk/src/main/java/org/apache/commons/nabla/forward/instructions/InvokeStaticTransformer.java?rev=1392553&r1=1392552&r2=1392553&view=diff
==============================================================================
---
commons/sandbox/nabla/trunk/src/main/java/org/apache/commons/nabla/forward/instructions/InvokeStaticTransformer.java
(original)
+++
commons/sandbox/nabla/trunk/src/main/java/org/apache/commons/nabla/forward/instructions/InvokeStaticTransformer.java
Mon Oct 1 19:32:55 2012
@@ -55,7 +55,7 @@ public class InvokeStaticTransformer imp
final MethodInsnNode methodInsn = (MethodInsnNode) insn;
if (!methodDifferentiator.isMathImplementationClass(methodInsn.owner))
{
- // TODO
+ // TODO: handle INVOKESTATIC on non math related classes
throw new RuntimeException("INVOKESTATIC on non math related
classes not handled yet" +
methodInsn.owner + methodInsn.owner);
}
