Author: tn Date: Sun Aug 5 09:32:46 2012 New Revision: 1369540 URL: http://svn.apache.org/viewvc?rev=1369540&view=rev Log: Fixed findbugs finding when comparing Integer references.
Modified: commons/proper/math/trunk/src/main/java/org/apache/commons/math3/optimization/linear/SimplexSolver.java Modified: commons/proper/math/trunk/src/main/java/org/apache/commons/math3/optimization/linear/SimplexSolver.java URL: http://svn.apache.org/viewvc/commons/proper/math/trunk/src/main/java/org/apache/commons/math3/optimization/linear/SimplexSolver.java?rev=1369540&r1=1369539&r2=1369540&view=diff ============================================================================== --- commons/proper/math/trunk/src/main/java/org/apache/commons/math3/optimization/linear/SimplexSolver.java (original) +++ commons/proper/math/trunk/src/main/java/org/apache/commons/math3/optimization/linear/SimplexSolver.java Sun Aug 5 09:32:46 2012 @@ -142,8 +142,9 @@ public class SimplexSolver extends Abstr int minIndex = tableau.getWidth(); for (Integer row : minRatioPositions) { int i = tableau.getNumObjectiveFunctions(); - for (; i < tableau.getWidth() - 1 && minRow != row; i++) { - if (row == tableau.getBasicRow(i)) { + for (; i < tableau.getWidth() - 1 && !row.equals(minRow); i++) { + Integer basicRow = tableau.getBasicRow(i); + if (basicRow != null && basicRow.equals(row)) { if (i < minIndex) { minIndex = i; minRow = row;