This is an automated email from the ASF dual-hosted git repository. garydgregory pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/commons-secure-xml.git
commit e9e08a09620bb1474302f98c2ca237422a0353b7 Author: Gary Gregory <[email protected]> AuthorDate: Wed Sep 2 07:02:52 2026 -0400 Javadoc: Fix word salad --- .../org/apache/commons/xml/secure/FallbackIgnoreXMLResolver.java | 5 ++++- .../java/org/apache/commons/xml/secure/SecureXMLInputFactory.java | 4 ++-- src/main/java/org/apache/commons/xml/secure/package-info.java | 2 +- 3 files changed, 7 insertions(+), 4 deletions(-) diff --git a/src/main/java/org/apache/commons/xml/secure/FallbackIgnoreXMLResolver.java b/src/main/java/org/apache/commons/xml/secure/FallbackIgnoreXMLResolver.java index 9978b64..93a5c4c 100644 --- a/src/main/java/org/apache/commons/xml/secure/FallbackIgnoreXMLResolver.java +++ b/src/main/java/org/apache/commons/xml/secure/FallbackIgnoreXMLResolver.java @@ -73,7 +73,10 @@ public Object resolveEntity(final String publicID, final String systemID, final } /** - * Sets the delegate to consult first, replacing any previous delegate, may be {@code null}. + * Sets the delegate to consult first, replacing any previous delegate. + * <p> + * A null value removes the delegate and leaves a pure ignore-all floor. + * </p> * * @param delegate The delegate to consult first, replacing any previous delegate. */ diff --git a/src/main/java/org/apache/commons/xml/secure/SecureXMLInputFactory.java b/src/main/java/org/apache/commons/xml/secure/SecureXMLInputFactory.java index 1c69831..aa57196 100644 --- a/src/main/java/org/apache/commons/xml/secure/SecureXMLInputFactory.java +++ b/src/main/java/org/apache/commons/xml/secure/SecureXMLInputFactory.java @@ -60,8 +60,8 @@ public final class SecureXMLInputFactory { * * <p>Every resolver-valued entry point ({@link #setXMLResolver(XMLResolver)}, {@code setProperty(XMLInputFactory.RESOLVER, ...)} and the Woodstox * {@code com.ctc.wstx.*Resolver} keys) is routed uniformly: a caller who supplies their own {@link FallbackIgnoreXMLResolver} takes control and it is - * passed straight to the delegate; otherwise the caller's resolver is wrapped in a new floor installed on that hook, an opt-in the floor cannot be removed - * by. This matters because Woodstox does not chain resolvers: when a resolver returns {@code null}, {@code DefaultInputResolver} falls + * passed straight to the delegate; otherwise the caller's resolver is wrapped in a new floor installed on that hook, so the caller's opt-in cannot be removed + * by dropping the resolver. This matters because Woodstox does not chain resolvers: when a resolver returns {@code null}, {@code DefaultInputResolver} falls * through to fetching the systemId URL itself, so a caller-set resolver that returns {@code null} must still land behind the floor. {@link #getXMLResolver()} and * {@code getProperty} report the caller's resolver unwrapped.</p> * diff --git a/src/main/java/org/apache/commons/xml/secure/package-info.java b/src/main/java/org/apache/commons/xml/secure/package-info.java index 0fe8a23..17655e6 100644 --- a/src/main/java/org/apache/commons/xml/secure/package-info.java +++ b/src/main/java/org/apache/commons/xml/secure/package-info.java @@ -78,7 +78,7 @@ * they pin the platform's built-in implementation instead of whatever a classpath lookup would resolve, * which suits a library with minimal XML requirements that does not want to delegate the choice of implementation to the application developer. * The DOM, SAX and schema variants fall back to the standard lookup where the runtime provides neither the Java 9 method nor the JDK's built-in class - * (for example, Android, whose own lookup is pinned to the platform parser, and for schemas falls back to exactly the Xerces implementation). + * (for example, Android, whose own lookup is pinned to the platform parser, and whose schema lookup falls back to exactly the Xerces implementation). * </p> * <p> * An unresolved external reference resolves to empty content by default, so the parse continues without the resource. To reject it with an exception instead,
