This is an automated email from the ASF dual-hosted git repository.
garydgregory pushed a commit to branch 1.x
in repository https://gitbox.apache.org/repos/asf/commons-fileupload.git
The following commit(s) were added to refs/heads/1.x by this push:
new ee94c692 Flip null test
ee94c692 is described below
commit ee94c69268541443c9ad709e6c3bf21aecfa3336
Author: Gary Gregory <[email protected]>
AuthorDate: Sun Jul 5 09:52:48 2026 -0400
Flip null test
---
src/main/java/org/apache/commons/fileupload/FileUploadBase.java | 2 +-
.../org/apache/commons/fileupload/util/FileItemHeadersImpl.java | 6 +++---
.../java/org/apache/commons/fileupload/MockHttpServletRequest.java | 2 +-
3 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/main/java/org/apache/commons/fileupload/FileUploadBase.java
b/src/main/java/org/apache/commons/fileupload/FileUploadBase.java
index b0188a9f..b594be5c 100644
--- a/src/main/java/org/apache/commons/fileupload/FileUploadBase.java
+++ b/src/main/java/org/apache/commons/fileupload/FileUploadBase.java
@@ -291,7 +291,7 @@ public abstract class FileUploadBase {
FileItemIteratorImpl(final RequestContext ctx) throws
FileUploadException, IOException {
Objects.requireNonNull(ctx, "ctx");
final String contentType = ctx.getContentType();
- if (null == contentType ||
!contentType.toLowerCase(Locale.ROOT).startsWith(MULTIPART)) {
+ if (contentType == null ||
!contentType.toLowerCase(Locale.ROOT).startsWith(MULTIPART)) {
throw new InvalidContentTypeException(format("the request
neither contains a %s nor a %s nor a %s stream, content type header is %s",
MULTIPART_FORM_DATA, MULTIPART_MIXED,
MULTIPART_RELATED, contentType));
}
diff --git
a/src/main/java/org/apache/commons/fileupload/util/FileItemHeadersImpl.java
b/src/main/java/org/apache/commons/fileupload/util/FileItemHeadersImpl.java
index e478c1ff..a84e0a70 100644
--- a/src/main/java/org/apache/commons/fileupload/util/FileItemHeadersImpl.java
+++ b/src/main/java/org/apache/commons/fileupload/util/FileItemHeadersImpl.java
@@ -61,7 +61,7 @@ public class FileItemHeadersImpl implements FileItemHeaders,
Serializable {
public synchronized void addHeader(final String name, final String value) {
final String nameLower = name.toLowerCase(Locale.ROOT);
List<String> headerValueList = headerNameToValueListMap.get(nameLower);
- if (null == headerValueList) {
+ if (headerValueList == null) {
headerValueList = new ArrayList<>();
headerNameToValueListMap.put(nameLower, headerValueList);
}
@@ -72,7 +72,7 @@ public class FileItemHeadersImpl implements FileItemHeaders,
Serializable {
public String getHeader(final String name) {
final String nameLower = name.toLowerCase(Locale.ROOT);
final List<String> headerValueList =
headerNameToValueListMap.get(nameLower);
- if (null == headerValueList) {
+ if (headerValueList == null) {
return null;
}
return headerValueList.get(0);
@@ -87,7 +87,7 @@ public class FileItemHeadersImpl implements FileItemHeaders,
Serializable {
public Iterator<String> getHeaders(final String name) {
final String nameLower = name.toLowerCase(Locale.ROOT);
List<String> headerValueList = headerNameToValueListMap.get(nameLower);
- if (null == headerValueList) {
+ if (headerValueList == null) {
headerValueList = Collections.emptyList();
}
return headerValueList.iterator();
diff --git
a/src/test/java/org/apache/commons/fileupload/MockHttpServletRequest.java
b/src/test/java/org/apache/commons/fileupload/MockHttpServletRequest.java
index ba0cbc38..cec3c2be 100644
--- a/src/test/java/org/apache/commons/fileupload/MockHttpServletRequest.java
+++ b/src/test/java/org/apache/commons/fileupload/MockHttpServletRequest.java
@@ -139,7 +139,7 @@ public class MockHttpServletRequest implements
HttpServletRequest {
public int getContentLength() {
int iLength = 0;
- if (null == requestData) {
+ if (requestData == null) {
iLength = -1;
} else {
if (length > Integer.MAX_VALUE) {
