This is an automated email from the ASF dual-hosted git repository.
garydgregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-pool.git
The following commit(s) were added to refs/heads/master by this push:
new c3a56fdc Flip null test
c3a56fdc is described below
commit c3a56fdc9bdc7722b6f1030464f74c61c01dbf01
Author: Gary Gregory <[email protected]>
AuthorDate: Sun Jul 5 09:41:59 2026 -0400
Flip null test
---
doc/ReaderUtil.java | 2 +-
.../java/org/apache/commons/pool3/impl/SoftReferenceObjectPool.java | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/doc/ReaderUtil.java b/doc/ReaderUtil.java
index 0c292a56..ba64353b 100644
--- a/doc/ReaderUtil.java
+++ b/doc/ReaderUtil.java
@@ -60,7 +60,7 @@ public class ReaderUtil {
// ignored
}
try {
- if (null != buf) {
+ if (buf != null) {
pool.returnObject(buf);
}
} catch (Exception e) {
diff --git
a/src/main/java/org/apache/commons/pool3/impl/SoftReferenceObjectPool.java
b/src/main/java/org/apache/commons/pool3/impl/SoftReferenceObjectPool.java
index b61e71b0..e8e14d3f 100644
--- a/src/main/java/org/apache/commons/pool3/impl/SoftReferenceObjectPool.java
+++ b/src/main/java/org/apache/commons/pool3/impl/SoftReferenceObjectPool.java
@@ -193,7 +193,7 @@ public class SoftReferenceObjectPool<T, E extends
Exception> extends BaseObjectP
ref.getReference().clear();
ref.setReference(new SoftReference<>(obj));
}
- if (null != obj) {
+ if (obj != null) {
try {
factory.activateObject(ref);
if (!factory.validateObject(ref)) {
@@ -227,7 +227,7 @@ public class SoftReferenceObjectPool<T, E extends
Exception> extends BaseObjectP
public synchronized void clear() {
idleReferences.forEach(pooledSoftRef -> {
try {
- if (null != pooledSoftRef.getObject()) {
+ if (pooledSoftRef.getObject() != null) {
factory.destroyObject(pooledSoftRef);
}
} catch (final Exception ignored) {