This is an automated email from the ASF dual-hosted git repository.
garydgregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-collections.git
The following commit(s) were added to refs/heads/master by this push:
new 707613ea1 Flip null test
707613ea1 is described below
commit 707613ea1e36f228ce0fd90a6580ca9024c7ff18
Author: Gary Gregory <[email protected]>
AuthorDate: Sun Jul 5 09:19:44 2026 -0400
Flip null test
---
src/main/java/org/apache/commons/collections4/CollectionUtils.java | 6 +++---
.../commons/collections4/comparators/ComparableComparator.java | 2 +-
.../apache/commons/collections4/comparators/ComparatorChain.java | 4 ++--
.../org/apache/commons/collections4/queue/CircularFifoQueue.java | 2 +-
4 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/src/main/java/org/apache/commons/collections4/CollectionUtils.java
b/src/main/java/org/apache/commons/collections4/CollectionUtils.java
index 2ffe3c93c..b3019eff3 100644
--- a/src/main/java/org/apache/commons/collections4/CollectionUtils.java
+++ b/src/main/java/org/apache/commons/collections4/CollectionUtils.java
@@ -537,7 +537,7 @@ public class CollectionUtils {
public static <I, O> Collection<O> collect(final Iterable<I>
inputCollection,
final Transformer<? super I, ?
extends O> transformer) {
int size = 0;
- if (null != inputCollection) {
+ if (inputCollection != null) {
size = inputCollection instanceof Collection<?> ? ((Collection<?>)
inputCollection).size() : 0;
}
final Collection<O> answer = size == 0 ? new ArrayList<>() : new
ArrayList<>(size);
@@ -1705,7 +1705,7 @@ public class CollectionUtils {
public static <O> Collection<O> select(final Iterable<? extends O>
inputCollection,
final Predicate<? super O>
predicate) {
int size = 0;
- if (null != inputCollection) {
+ if (inputCollection != null) {
size = inputCollection instanceof Collection<?> ? ((Collection<?>)
inputCollection).size() : 0;
}
final Collection<O> answer = size == 0 ? new ArrayList<>() : new
ArrayList<>(size);
@@ -1802,7 +1802,7 @@ public class CollectionUtils {
public static <O> Collection<O> selectRejected(final Iterable<? extends O>
inputCollection,
final Predicate<? super O>
predicate) {
int size = 0;
- if (null != inputCollection) {
+ if (inputCollection != null) {
size = inputCollection instanceof Collection<?> ? ((Collection<?>)
inputCollection).size() : 0;
}
final Collection<O> answer = size == 0 ? new ArrayList<>() : new
ArrayList<>(size);
diff --git
a/src/main/java/org/apache/commons/collections4/comparators/ComparableComparator.java
b/src/main/java/org/apache/commons/collections4/comparators/ComparableComparator.java
index 10cb15ef3..b789512ec 100644
---
a/src/main/java/org/apache/commons/collections4/comparators/ComparableComparator.java
+++
b/src/main/java/org/apache/commons/collections4/comparators/ComparableComparator.java
@@ -107,7 +107,7 @@ public class ComparableComparator<E extends Comparable<?
super E>> implements Co
@Override
public boolean equals(final Object object) {
return this == object ||
- null != object && object.getClass().equals(this.getClass());
+ object != null && object.getClass().equals(this.getClass());
}
/**
diff --git
a/src/main/java/org/apache/commons/collections4/comparators/ComparatorChain.java
b/src/main/java/org/apache/commons/collections4/comparators/ComparatorChain.java
index 6425d54a9..2ef66bae2 100644
---
a/src/main/java/org/apache/commons/collections4/comparators/ComparatorChain.java
+++
b/src/main/java/org/apache/commons/collections4/comparators/ComparatorChain.java
@@ -263,10 +263,10 @@ public class ComparatorChain<E> implements Comparator<E>,
Serializable {
@Override
public int hashCode() {
int hash = 0;
- if (null != comparatorChain) {
+ if (comparatorChain != null) {
hash ^= comparatorChain.hashCode();
}
- if (null != orderingBits) {
+ if (orderingBits != null) {
hash ^= orderingBits.hashCode();
}
return hash;
diff --git
a/src/main/java/org/apache/commons/collections4/queue/CircularFifoQueue.java
b/src/main/java/org/apache/commons/collections4/queue/CircularFifoQueue.java
index b6358d945..b42f600ca 100644
--- a/src/main/java/org/apache/commons/collections4/queue/CircularFifoQueue.java
+++ b/src/main/java/org/apache/commons/collections4/queue/CircularFifoQueue.java
@@ -386,7 +386,7 @@ public class CircularFifoQueue<E> extends
AbstractCollection<E>
}
final E element = elements[start];
- if (null != element) {
+ if (element != null) {
elements[start++] = null;
if (start >= maxElements) {