(commons-validator) branch master updated: Pull up BigDecimalValidator .isFinite(Number) to AbstractNumberValidator

[ggregory]

This is an automated email from the ASF dual-hosted git repository.

garydgregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-validator.git


The following commit(s) were added to refs/heads/master by this push:
     new a3553643 Pull up BigDecimalValidator .isFinite(Number) to 
AbstractNumberValidator
     new 031d2dd0 Merge branch 'master' of 
https://github.com/apache/commons-validator.git
a3553643 is described below

commit a355364314898b3690c7fdcef22493568ea86bd6
Author: Gary Gregory <garydgreg...@gmail.com>
AuthorDate: Wed Jun 24 12:09:13 2026 +0000

    Pull up BigDecimalValidator .isFinite(Number) to AbstractNumberValidator
    
    See PR 410
---
 .../validator/routines/AbstractNumberValidator.java      | 16 ++++++++++++++++
 .../commons/validator/routines/BigDecimalValidator.java  | 10 ----------
 2 files changed, 16 insertions(+), 10 deletions(-)

diff --git 
a/src/main/java/org/apache/commons/validator/routines/AbstractNumberValidator.java
 
b/src/main/java/org/apache/commons/validator/routines/AbstractNumberValidator.java
index df92dd0b..8eb74ac2 100644
--- 
a/src/main/java/org/apache/commons/validator/routines/AbstractNumberValidator.java
+++ 
b/src/main/java/org/apache/commons/validator/routines/AbstractNumberValidator.java
@@ -84,6 +84,22 @@ public abstract class AbstractNumberValidator extends 
AbstractFormatValidator {
         return toBigDecimal(value).toBigInteger();
     }
 
+    /**
+     * Tests if the given value is finite.
+     *
+     * @param value The value to test.
+     * @return {@code true} if the value is finite, {@code false} otherwise.
+     */
+    static boolean isFinite(final Number value) {
+        if (value instanceof Double) {
+            return Double.isFinite((Double) value);
+        }
+        if (value instanceof Float) {
+            return Float.isFinite((Float) value);
+        }
+        return true;
+    }
+
     /**
      * {@code true} if fractions are allowed or {@code false} if integers only.
      */
diff --git 
a/src/main/java/org/apache/commons/validator/routines/BigDecimalValidator.java 
b/src/main/java/org/apache/commons/validator/routines/BigDecimalValidator.java
index 75d68a72..03c22bd4 100644
--- 
a/src/main/java/org/apache/commons/validator/routines/BigDecimalValidator.java
+++ 
b/src/main/java/org/apache/commons/validator/routines/BigDecimalValidator.java
@@ -88,16 +88,6 @@ public class BigDecimalValidator extends 
AbstractNumberValidator {
         return VALIDATOR;
     }
 
-    private static boolean isFinite(final Number value) {
-        if (value instanceof Double) {
-            return Double.isFinite((Double) value);
-        }
-        if (value instanceof Float) {
-            return Float.isFinite((Float) value);
-        }
-        return true;
-    }
-
     /**
      * Constructs a <em>strict</em> instance.
      */