(commons-validator) branch master updated: Revert change that causes warning

[sebb]

This is an automated email from the ASF dual-hosted git repository.

asf-gitbox-commits pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-validator.git


The following commit(s) were added to refs/heads/master by this push:
     new 717fb248 Revert change that causes warning
717fb248 is described below

commit 717fb2484d9f2a92d772ee70b2560194e388e758
Author: Sebb <s...@apache.org>
AuthorDate: Tue Jun 23 14:19:37 2026 +0100

    Revert change that causes warning
---
 .../org/apache/commons/validator/routines/DomainValidatorTest.java | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git 
a/src/test/java/org/apache/commons/validator/routines/DomainValidatorTest.java 
b/src/test/java/org/apache/commons/validator/routines/DomainValidatorTest.java
index 81fd1238..431fce1b 100644
--- 
a/src/test/java/org/apache/commons/validator/routines/DomainValidatorTest.java
+++ 
b/src/test/java/org/apache/commons/validator/routines/DomainValidatorTest.java
@@ -332,8 +332,11 @@ public class DomainValidatorTest {
                 }
                 ianaTlds.add(asciiTld);
                 // Don't merge these conditions; generateUnicodeTlds is final 
so needs to be separate to avoid a warning
-                if (generateUnicodeTlds && !unicodeTld.equals(asciiTld)) {
-                    ianaTlds.add(unicodeTld);
+                if (generateUnicodeTlds) {
+                    // DO NOT MERGE THIS CHECK INTO ITS PARENT (See above)
+                    if (!unicodeTld.equals(asciiTld)) {
+                        ianaTlds.add(unicodeTld);
+                    }
                 }
             }
         }