This is an automated email from the ASF dual-hosted git repository. garydgregory pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-collections.git
commit 02ce5bc21e5b5691029efec3692f74b6d837dd03 Author: Gary Gregory <[email protected]> AuthorDate: Sun Jun 14 21:06:19 2026 +0000 Sort members --- .../commons/collections4/MultiMapUtilsTest.java | 48 +++++++++++----------- 1 file changed, 24 insertions(+), 24 deletions(-) diff --git a/src/test/java/org/apache/commons/collections4/MultiMapUtilsTest.java b/src/test/java/org/apache/commons/collections4/MultiMapUtilsTest.java index 4bb3528d0..59687d64f 100644 --- a/src/test/java/org/apache/commons/collections4/MultiMapUtilsTest.java +++ b/src/test/java/org/apache/commons/collections4/MultiMapUtilsTest.java @@ -94,6 +94,21 @@ class MultiMapUtilsTest { } } + @Test + void testGetValuesAsBagIsSafeCopy() { + final String[] values = { "v1", "v2", "v3" }; + final MultiValuedMap<String, String> mockMap = createMock(MultiValuedMap.class); + final Bag<String> bagToReturn = new HashBag<>(); + bagToReturn.addAll(Arrays.asList(values)); + expect(mockMap.get("key1")).andReturn(bagToReturn); + replay(mockMap); + + final Bag<String> bag = MultiMapUtils.getValuesAsBag(mockMap, "key1"); + bag.add("v4"); + assertFalse(bagToReturn.contains("v4")); + verify(mockMap); + } + @Test void testGetValuesAsList() { assertNull(MultiMapUtils.getValuesAsList(null, "key1")); @@ -109,46 +124,31 @@ class MultiMapUtilsTest { } @Test - void testGetValuesAsSet() { - assertNull(MultiMapUtils.getValuesAsSet(null, "key1")); - + void testGetValuesAsListIsSafeCopy() { final String[] values = { "v1", "v2", "v3" }; final MultiValuedMap<String, String> map = new ArrayListValuedHashMap<>(); for (final String val : values) { map.put("key1", val); - map.put("key1", val); } - final Set<String> set = MultiMapUtils.getValuesAsSet(map, "key1"); - assertEquals(new HashSet<>(Arrays.asList(values)), set); + final List<String> list = MultiMapUtils.getValuesAsList(map, "key1"); + list.add("v4"); + assertFalse(map.containsMapping("key1", "v4")); } @Test - void testGetValuesAsBagIsSafeCopy() { - final String[] values = { "v1", "v2", "v3" }; - final MultiValuedMap<String, String> mockMap = createMock(MultiValuedMap.class); - final Bag<String> bagToReturn = new HashBag<>(); - bagToReturn.addAll(Arrays.asList(values)); - expect(mockMap.get("key1")).andReturn(bagToReturn); - replay(mockMap); - - final Bag<String> bag = MultiMapUtils.getValuesAsBag(mockMap, "key1"); - bag.add("v4"); - assertFalse(bagToReturn.contains("v4")); - verify(mockMap); - } + void testGetValuesAsSet() { + assertNull(MultiMapUtils.getValuesAsSet(null, "key1")); - @Test - void testGetValuesAsListIsSafeCopy() { final String[] values = { "v1", "v2", "v3" }; final MultiValuedMap<String, String> map = new ArrayListValuedHashMap<>(); for (final String val : values) { map.put("key1", val); + map.put("key1", val); } - final List<String> list = MultiMapUtils.getValuesAsList(map, "key1"); - list.add("v4"); - assertFalse(map.containsMapping("key1", "v4")); + final Set<String> set = MultiMapUtils.getValuesAsSet(map, "key1"); + assertEquals(new HashSet<>(Arrays.asList(values)), set); } @Test
