This is an automated email from the ASF dual-hosted git repository. garydgregory pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-lang.git
commit 1dd567ea0c8aeb7ecca2c7dedeef6f511e366760 Author: Gary Gregory <[email protected]> AuthorDate: Sat Jun 13 11:57:29 2026 +0000 Refactor NumberUtilsTest.testCreateBigInteger() test using @ParameterizedTest --- .../apache/commons/lang3/math/NumberUtilsTest.java | 36 +++++++++++++--------- 1 file changed, 21 insertions(+), 15 deletions(-) diff --git a/src/test/java/org/apache/commons/lang3/math/NumberUtilsTest.java b/src/test/java/org/apache/commons/lang3/math/NumberUtilsTest.java index aa16c4b02..a3d987de8 100644 --- a/src/test/java/org/apache/commons/lang3/math/NumberUtilsTest.java +++ b/src/test/java/org/apache/commons/lang3/math/NumberUtilsTest.java @@ -461,11 +461,7 @@ protected void testCreateBigDecimalFailure(final String str) { void testCreateBigInteger() { assertEquals(new BigInteger("12345"), NumberUtils.createBigInteger("12345"), "createBigInteger(String) failed"); assertNull(NumberUtils.createBigInteger(null), "createBigInteger(null) failed"); - testCreateBigIntegerFailure(""); - testCreateBigIntegerFailure(" "); - testCreateBigIntegerFailure("\b\t\n\f\r"); // Funky whitespaces - testCreateBigIntegerFailure("\u00A0\uFEFF\u000B\u000C\u001C\u001D\u001E\u001F"); assertEquals(new BigInteger("255"), NumberUtils.createBigInteger("0xff"), "createBigInteger(String) failed"); assertEquals(new BigInteger("255"), NumberUtils.createBigInteger("0Xff"), "createBigInteger(String) failed"); assertEquals(new BigInteger("255"), NumberUtils.createBigInteger("#ff"), "createBigInteger(String) failed"); @@ -475,24 +471,34 @@ void testCreateBigInteger() { assertEquals(new BigInteger("-255"), NumberUtils.createBigInteger("-0377"), "createBigInteger(String) failed"); assertEquals(new BigInteger("-0"), NumberUtils.createBigInteger("-0"), "createBigInteger(String) failed"); assertEquals(new BigInteger("0"), NumberUtils.createBigInteger("0"), "createBigInteger(String) failed"); - testCreateBigIntegerFailure("#"); - testCreateBigIntegerFailure("-#"); - testCreateBigIntegerFailure("0x"); - testCreateBigIntegerFailure("-0x"); // LANG-1645 assertEquals(new BigInteger("+FFFFFFFFFFFFFFFF", 16), NumberUtils.createBigInteger("+0xFFFFFFFFFFFFFFFF")); assertEquals(new BigInteger("+FFFFFFFFFFFFFFFF", 16), NumberUtils.createBigInteger("+#FFFFFFFFFFFFFFFF")); assertEquals(new BigInteger("+1234567", 8), NumberUtils.createBigInteger("+01234567")); // a doubled sign is not a valid number - testCreateBigIntegerFailure("--1"); - testCreateBigIntegerFailure("-+1"); - testCreateBigIntegerFailure("+-1"); - testCreateBigIntegerFailure("++1"); - testCreateBigIntegerFailure("--010"); - testCreateBigIntegerFailure("-0x-1"); } - protected void testCreateBigIntegerFailure(final String str) { + @ParameterizedTest + @ValueSource(strings = { + // @formatter:off + "", + " ", + "\b\t\n\f\r", + // Funky whitespaces + "\u00A0\uFEFF\u000B\u000C\u001C\u001D\u001E\u001F", + "#", + "-#", + "0x", + "-0x", + // a doubled sign is not a valid number + "--1", + "-+1", + "+-1", + "++1", + "--010", + "-0x-1" }) + // @formatter:on + void testCreateBigIntegerFailure(final String str) { assertThrows(NumberFormatException.class, () -> NumberUtils.createBigInteger(str), "createBigInteger(\"" + str + "\") should have failed."); // Should match java.math.BigInteger.BigInteger(String) assertThrows(NumberFormatException.class, () -> new BigInteger(str));
