This is an automated email from the ASF dual-hosted git repository. garydgregory pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-text.git
commit df89bdcd5c16567d2f3789a27a2c779dca8caa37 Author: Gary Gregory <[email protected]> AuthorDate: Tue Jun 2 07:33:47 2026 -0400 Use assertThrows() --- .../text/translate/NumericEntityUnescaperTest.java | 15 ++++----------- 1 file changed, 4 insertions(+), 11 deletions(-) diff --git a/src/test/java/org/apache/commons/text/translate/NumericEntityUnescaperTest.java b/src/test/java/org/apache/commons/text/translate/NumericEntityUnescaperTest.java index d98ef7a7..f0eedde7 100644 --- a/src/test/java/org/apache/commons/text/translate/NumericEntityUnescaperTest.java +++ b/src/test/java/org/apache/commons/text/translate/NumericEntityUnescaperTest.java @@ -18,7 +18,7 @@ package org.apache.commons.text.translate; import static org.junit.jupiter.api.Assertions.assertEquals; -import static org.junit.jupiter.api.Assertions.fail; +import static org.junit.jupiter.api.Assertions.assertThrows; import org.junit.jupiter.api.Test; @@ -71,24 +71,17 @@ class NumericEntityUnescaperTest { void testUnfinishedEntity() { // parse it NumericEntityUnescaper neu = new NumericEntityUnescaper(NumericEntityUnescaper.OPTION.semiColonOptional); - String input = "Test 0 not test"; + final String input = "Test 0 not test"; String expected = "Test \u0030 not test"; String result = neu.translate(input); assertEquals(expected, result, "Failed to support unfinished entities (i.e. missing semicolon)"); // ignore it neu = new NumericEntityUnescaper(); - input = "Test 0 not test"; expected = input; result = neu.translate(input); assertEquals(expected, result, "Failed to ignore unfinished entities (i.e. missing semicolon)"); // fail it - neu = new NumericEntityUnescaper(NumericEntityUnescaper.OPTION.errorIfNoSemiColon); - input = "Test 0 not test"; - try { - result = neu.translate(input); - fail("IllegalArgumentException expected"); - } catch (final IllegalArgumentException iae) { - // expected - } + assertThrows(IllegalArgumentException.class, + () -> new NumericEntityUnescaper(NumericEntityUnescaper.OPTION.errorIfNoSemiColon).translate("Test 0 not test")); } }
