This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-jexl.git
The following commit(s) were added to refs/heads/master by this push:
new 611e548f No need to end exception messages with an exclamation!
611e548f is described below
commit 611e548f4ba361bfe2be7c683a0c87d8b1292ff2
Author: Gary Gregory <[email protected]>
AuthorDate: Wed Apr 15 08:12:55 2026 -0400
No need to end exception messages with an exclamation!
---
src/test/java/org/apache/commons/jexl3/Issues300Test.java | 12 ++++++------
src/test/java/org/apache/commons/jexl3/MethodTest.java | 4 ++--
.../org/apache/commons/jexl3/introspection/SandboxTest.java | 12 ++++++------
3 files changed, 14 insertions(+), 14 deletions(-)
diff --git a/src/test/java/org/apache/commons/jexl3/Issues300Test.java
b/src/test/java/org/apache/commons/jexl3/Issues300Test.java
index f9879567..8bd6f6ca 100644
--- a/src/test/java/org/apache/commons/jexl3/Issues300Test.java
+++ b/src/test/java/org/apache/commons/jexl3/Issues300Test.java
@@ -641,7 +641,7 @@ class Issues300Test {
// nothing in context, ex
final JexlScript script0 = jexl.createScript("a.n.t.variable");
- JexlException.Variable xvar =
assertThrows(JexlException.Variable.class, () -> script0.execute(jc),
"a.n.t.variable is undefined!");
+ JexlException.Variable xvar =
assertThrows(JexlException.Variable.class, () -> script0.execute(jc),
"a.n.t.variable is undefined.");
assertTrue(xvar.toString().contains("a.n.t"));
// defined and null
@@ -653,26 +653,26 @@ class Issues300Test {
// defined and null, dereference
jc.set("a.n.t", null);
final JexlScript script1 = jexl.createScript("a.n.t[0].variable");
- xvar = assertThrows(JexlException.Variable.class, () ->
script1.execute(jc), "a.n.t is null!");
+ xvar = assertThrows(JexlException.Variable.class, () ->
script1.execute(jc), "a.n.t is null.");
assertTrue(xvar.toString().contains("a.n.t"));
// undefined, dereference
vars.remove("a.n.t");
final JexlScript script2 = jexl.createScript("a.n.t[0].variable");
- xvar = assertThrows(JexlException.Variable.class, () ->
script2.execute(jc), "a.n.t is undefined!");
+ xvar = assertThrows(JexlException.Variable.class, () ->
script2.execute(jc), "a.n.t is undefined.");
assertTrue(xvar.toString().contains("a.n.t"));
// defined, derefence undefined property
final List<Object> inner = new ArrayList<>();
vars.put("a.n.t", inner);
final JexlScript script3 = jexl.createScript("a.n.t[0].variable");
- JexlException.Property xprop =
assertThrows(JexlException.Property.class, () -> script3.execute(jc), "a.n.t is
null!");
+ JexlException.Property xprop =
assertThrows(JexlException.Property.class, () -> script3.execute(jc), "a.n.t is
null.");
assertTrue(xprop.toString().contains("0"));
// defined, derefence undefined property
inner.add(42);
final JexlScript script4 = jexl.createScript("a.n.t[0].variable");
- xprop = assertThrows(JexlException.Property.class, () ->
script4.execute(jc), "a.n.t is null!");
+ xprop = assertThrows(JexlException.Property.class, () ->
script4.execute(jc), "a.n.t is null.");
assertTrue(xprop.toString().contains("variable"));
}
@@ -861,7 +861,7 @@ class Issues300Test {
// undefined
final JexlExpression get1 = jexl.createExpression("phone");
assertFalse(ctxt.has("phone"));
- final JexlException.Variable xvar =
assertThrows(JexlException.Variable.class, () -> get1.evaluate(ctxt), "phone
should be undefined!");
+ final JexlException.Variable xvar =
assertThrows(JexlException.Variable.class, () -> get1.evaluate(ctxt), "phone
should be undefined.");
assertEquals("phone", xvar.getVariable());
}
diff --git a/src/test/java/org/apache/commons/jexl3/MethodTest.java
b/src/test/java/org/apache/commons/jexl3/MethodTest.java
index cd21e928..f96f64d6 100644
--- a/src/test/java/org/apache/commons/jexl3/MethodTest.java
+++ b/src/test/java/org/apache/commons/jexl3/MethodTest.java
@@ -418,8 +418,8 @@ class MethodTest extends JexlTestCase {
final Functor func = new Functor();
assertEquals(Integer.valueOf(10), JEXL.invokeMethod(func, "ten"));
assertEquals(Integer.valueOf(42), JEXL.invokeMethod(func, "PLUS20",
Integer.valueOf(22)));
- assertThrows(Exception.class, () -> JEXL.invokeMethod(func,
"nonExistentMethod"), "method does not exist!");
- assertThrows(Exception.class, () -> JEXL.invokeMethod(func,
"NPEIfNull", (Object[]) null), "method should have thrown!");
+ assertThrows(Exception.class, () -> JEXL.invokeMethod(func,
"nonExistentMethod"), "method does not exist.");
+ assertThrows(Exception.class, () -> JEXL.invokeMethod(func,
"NPEIfNull", (Object[]) null), "method should have thrown.");
Object result = JEXL.invokeMethod(func, "over", "foo", 42);
assertEquals("foo + 42", result);
assertThrows(Exception.class, () -> JEXL.invokeMethod(func, "over",
null, null));
diff --git
a/src/test/java/org/apache/commons/jexl3/introspection/SandboxTest.java
b/src/test/java/org/apache/commons/jexl3/introspection/SandboxTest.java
index 3f2537e6..b5e1c129 100644
--- a/src/test/java/org/apache/commons/jexl3/introspection/SandboxTest.java
+++ b/src/test/java/org/apache/commons/jexl3/introspection/SandboxTest.java
@@ -99,12 +99,12 @@ class SandboxTest extends JexlTestCase {
}
public @NoJexl Foo(final String name, final String notcallable) {
- throw new UnsupportedOperationException("should not be callable!");
+ throw new UnsupportedOperationException("should not be callable.");
}
@NoJexl
public String cantCallMe() {
- throw new UnsupportedOperationException("should not be callable!");
+ throw new UnsupportedOperationException("should not be callable.");
}
public int doIt() {
@@ -125,12 +125,12 @@ class SandboxTest extends JexlTestCase {
@Override
public void tryMe() {
- throw new UnsupportedOperationException("should not be callable!");
+ throw new UnsupportedOperationException("should not be callable.");
}
@Override
public void tryMeARiver() {
- throw new UnsupportedOperationException("should not be callable!");
+ throw new UnsupportedOperationException("should not be callable.");
}
}
@@ -460,9 +460,9 @@ class SandboxTest extends JexlTestCase {
final JexlEngine sjexl = new
JexlBuilder().permissions(JexlPermissions.UNRESTRICTED).sandbox(sandbox).safe(false).strict(true).create();
Object result;
final JexlScript script1 = sjexl.createScript("System.exit()");
- assertThrows(JexlException.class, () -> script1.execute(context),
"should not allow calling exit!");
+ assertThrows(JexlException.class, () -> script1.execute(context),
"should not allow calling exit.");
final JexlScript script2 = sjexl.createScript("System.exit(1)");
- assertThrows(JexlException.class, () -> script2.execute(context),
"should not allow calling exit!");
+ assertThrows(JexlException.class, () -> script2.execute(context),
"should not allow calling exit.");
final JexlScript script3 = sjexl.createScript("new('java.io.File',
'/tmp/should-not-be-created')");
assertThrows(JexlException.class, () -> script3.execute(context),
"should not allow creating a file");
final JexlScript script4 =
sjexl.createScript("System.currentTimeMillis()");
