This is an automated email from the ASF dual-hosted git repository. ggregory pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-fileupload.git
commit 2f4b043a96f018027a14ee65a563297b2e434ada Author: Gary Gregory <[email protected]> AuthorDate: Sun Mar 22 15:27:35 2026 -0700 [FILEUPLOAD-362] Unable to parse requests for file uploads with special characters in filename on Windows More tests --- .../fileupload2/core/DiskFileItemSerializeTest.java | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/commons-fileupload2-core/src/test/java/org/apache/commons/fileupload2/core/DiskFileItemSerializeTest.java b/commons-fileupload2-core/src/test/java/org/apache/commons/fileupload2/core/DiskFileItemSerializeTest.java index b50d4532..40e2da09 100644 --- a/commons-fileupload2-core/src/test/java/org/apache/commons/fileupload2/core/DiskFileItemSerializeTest.java +++ b/commons-fileupload2-core/src/test/java/org/apache/commons/fileupload2/core/DiskFileItemSerializeTest.java @@ -36,6 +36,8 @@ import org.apache.commons.lang3.SerializationUtils; import org.junit.jupiter.api.AfterEach; import org.junit.jupiter.api.BeforeEach; import org.junit.jupiter.api.Test; +import org.junit.jupiter.params.ParameterizedTest; +import org.junit.jupiter.params.provider.ValueSource; /** * Serialization Unit tests for {@link DiskFileItem}. @@ -193,9 +195,16 @@ class DiskFileItemSerializeTest { testInMemoryObject(testFieldValueBytes, THRESHOLD); } - @Test - void testCheckFileName() { - assertThrows(InvalidPathException.class, () -> DiskFileItem.checkFileName("\0")); + @ParameterizedTest + @ValueSource(strings = { "\0", "file\0name" }) + void testCheckFileNameInvalid(final String fileName) { + assertThrows(InvalidPathException.class, () -> DiskFileItem.checkFileName(fileName)); + } + + @ParameterizedTest + @ValueSource(strings = { "file name", "file name.txt", "file_name.txt", "file?name.txt" }) + void testCheckFileNameValid(final String fileName) { + assertEquals(fileName, DiskFileItem.checkFileName(fileName)); } /**
