This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch 1.x
in repository https://gitbox.apache.org/repos/asf/commons-fileupload.git

commit fbd8e54d6cfc0e872e518b5620314db9b08047b4
Author: Gary Gregory <[email protected]>
AuthorDate: Sat Mar 21 15:00:10 2026 -0700

    DiskFileItem.delete() and finalize() always ties to delete its backing
    file
---
 src/main/java/org/apache/commons/fileupload/disk/DiskFileItem.java | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/main/java/org/apache/commons/fileupload/disk/DiskFileItem.java 
b/src/main/java/org/apache/commons/fileupload/disk/DiskFileItem.java
index 42cfa831..a11ca2e3 100644
--- a/src/main/java/org/apache/commons/fileupload/disk/DiskFileItem.java
+++ b/src/main/java/org/apache/commons/fileupload/disk/DiskFileItem.java
@@ -197,7 +197,7 @@ public class DiskFileItem implements FileItem {
     @Override
     public void delete() {
         clear();
-        final File outputFile = getStoreLocation();
+        final File outputFile = dfos != null ? dfos.getFile() : null;
         if (outputFile != null && outputFile.exists()) {
             if (!outputFile.delete()) {
                 outputFile.deleteOnExit();

Reply via email to