This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-lang.git


The following commit(s) were added to refs/heads/master by this push:
     new e1852e78d Non-final Static Singleton Variables Break Thread Safety and 
Singleton Design in RandomStringUtils (#1513)
e1852e78d is described below

commit e1852e78d58631a782c6f1ac42247689e9679062
Author: IcoreE <[email protected]>
AuthorDate: Thu Dec 4 23:48:43 2025 +0800

    Non-final Static Singleton Variables Break Thread Safety and Singleton 
Design in RandomStringUtils (#1513)
---
 src/main/java/org/apache/commons/lang3/RandomStringUtils.java | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/main/java/org/apache/commons/lang3/RandomStringUtils.java 
b/src/main/java/org/apache/commons/lang3/RandomStringUtils.java
index 9ff104d6b..acf3c68d1 100644
--- a/src/main/java/org/apache/commons/lang3/RandomStringUtils.java
+++ b/src/main/java/org/apache/commons/lang3/RandomStringUtils.java
@@ -82,11 +82,11 @@ public class RandomStringUtils {
 
     private static final Supplier<RandomUtils> SECURE_SUPPLIER = 
RandomUtils::secure;
 
-    private static RandomStringUtils INSECURE = new 
RandomStringUtils(RandomUtils::insecure);
+    private static final RandomStringUtils INSECURE = new 
RandomStringUtils(RandomUtils::insecure);
 
-    private static RandomStringUtils SECURE = new 
RandomStringUtils(SECURE_SUPPLIER);
+    private static final RandomStringUtils SECURE = new 
RandomStringUtils(SECURE_SUPPLIER);
 
-    private static RandomStringUtils SECURE_STRONG = new 
RandomStringUtils(RandomUtils::secureStrong);
+    private static final RandomStringUtils SECURE_STRONG = new 
RandomStringUtils(RandomUtils::secureStrong);
 
     private static final char[] ALPHANUMERICAL_CHARS = { 'a', 'b', 'c', 'd', 
'e', 'f', 'g', 'h', 'i', 'j', 'k', 'l',
             'm', 'n', 'o', 'p', 'q', 'r', 's', 't', 'u', 'v', 'w', 'x', 'y', 
'z', 'A', 'B', 'C', 'D', 'E', 'F', 'G',

Reply via email to